[jira] [Updated] (GEODE-5732) TxCommitMessageTest doesn't actually test for presence/absence of shadow key flag
[ https://issues.apache.org/jira/browse/GEODE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-5732: -- Labels: pull-request-available swat (was: swat) > TxCommitMessageTest doesn't actually test for presence/absence of shadow key > flag > - > > Key: GEODE-5732 > URL: https://issues.apache.org/jira/browse/GEODE-5732 > Project: Geode > Issue Type: Bug > Components: transactions >Reporter: Bill >Assignee: Bill >Priority: Major > Labels: pull-request-available, swat > > The various toDataXX and fromDataXX methods purport to test > serialization/deserialization of TXCommitMessage between different product > versions. Primarily, this entails looking for presence/absence of the shadow > key boolean. Unfortunately, since the move to Mockito, only 1/7 of the tests > actually fail when we break the product. > The fix is to not use mocking for these tests, and to instead > serialize/deserialize to/from buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5732) TxCommitMessageTest doesn't actually test for presence/absence of shadow key flag
[ https://issues.apache.org/jira/browse/GEODE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill updated GEODE-5732: Labels: swat (was: ) > TxCommitMessageTest doesn't actually test for presence/absence of shadow key > flag > - > > Key: GEODE-5732 > URL: https://issues.apache.org/jira/browse/GEODE-5732 > Project: Geode > Issue Type: Bug > Components: transactions >Reporter: Bill >Priority: Major > Labels: swat > > The various toDataXX and fromDataXX methods purport to test > serialization/deserialization of TXCommitMessage between different product > versions. Primarily, this entails looking for presence/absence of the shadow > key boolean. Unfortunately, since the move to Mockito, only 1/7 of the tests > actually fail when we break the product. > The fix is to not use mocking for these tests, and to instead > serialize/deserialize to/from buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5732) TxCommitMessageTest doesn't actually test for presence/absence of shadow key flag
[ https://issues.apache.org/jira/browse/GEODE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill updated GEODE-5732: Description: The various toDataXX and fromDataXX methods purport to test serialization/deserialization of TXCommitMessage between different product versions. Primarily, this entails looking for presence/absence of the shadow key boolean. Unfortunately, since the move to Mockito, only 1/7 of the tests actually fail when we break the product. The fix is to not use mocking for these tests, and to instead serialize/deserialize to/from buffers. was:the various toDataXX > TxCommitMessageTest doesn't actually test for presence/absence of shadow key > flag > - > > Key: GEODE-5732 > URL: https://issues.apache.org/jira/browse/GEODE-5732 > Project: Geode > Issue Type: Bug > Components: transactions >Reporter: Bill >Priority: Major > Labels: swat > > The various toDataXX and fromDataXX methods purport to test > serialization/deserialization of TXCommitMessage between different product > versions. Primarily, this entails looking for presence/absence of the shadow > key boolean. Unfortunately, since the move to Mockito, only 1/7 of the tests > actually fail when we break the product. > The fix is to not use mocking for these tests, and to instead > serialize/deserialize to/from buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
