[jira] [Commented] (GUACAMOLE-876) RDP "reconnect" resizing breaks Drive Mapping
[
https://issues.apache.org/jira/browse/GUACAMOLE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009340#comment-17009340
]
Mike Jumper commented on GUACAMOLE-876:
---
{quote}
In the attached video you can see resizing a connection with the resize method
"reconnect", will halt any current file transfers (leaving corrupted files) ...
{quote}
Avoiding reconnect if a transfer is underway may be as simple as checking
whether {{filesystem->open_files}} is non-zero within
{{guac_rdp_disp_reconnect_needed()}}. That would avoid reconnecting for a
resize so long as anything has an open file on the shared drive. The same
should probably be done for print jobs and via {{rdp_client->active_job}}.
Worth addressing, but leveraging GUACAMOLE-249 and reliable support for the
Display Update channel is probably a better solution in general, assuming the
Windows machines in question are recent enough to support Display Update.
{quote}
... and sporadically leave the drive map unconnected for the new session.
{quote}
This has been reported separately as GUACAMOLE-900. I'd say let's use that
issue for that and leave this issue dedicated to allowing in-progress transfers
to complete despite "resize-method" being set set to "reconnect".
> RDP "reconnect" resizing breaks Drive Mapping
> -
>
> Key: GUACAMOLE-876
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-876
> Project: Guacamole
> Issue Type: Bug
> Components: guacd
>Affects Versions: 1.1.0
>Reporter: Richard Lancaster
>Priority: Minor
> Attachments: guacd.log, guacd_resize_file_trasfer.mp4
>
>
> In the attached video you can see resizing a connection with the resize
> method "reconnect", will halt any current file transfers (leaving corrupted
> files) and sporadically leave the drive map unconnected for the new session.
>
> The associated guacd logs associated with the video are attached.
>
> Running:
> * Web frontend - 1.0.0 (the official guacamole/guacamole docker image)
> * Guacd - staging/1.1.0 (381ff1a4214e06803f0f587f1ed97cf7e54853e7) (Built
> against ubuntu 18.04's libfreerdb-dev)
>
> Let me know if there is any more info you need.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GUACAMOLE-876) RDP "reconnect" resizing breaks Drive Mapping
[ https://issues.apache.org/jira/browse/GUACAMOLE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925530#comment-16925530 ] Richard Lancaster commented on GUACAMOLE-876: - > interrupting the file transfer with the "reconnect" method - I don't think >this is a bug in Guacamole, nor do I think it's an issue that is resolvable Is it feasible to know when a file is in transit? We could disable resizing (likely just ignoring the client's `size` command) whilst this is happening. I haven't reported this (as I haven't found a FreeRDP ca1cec6 build to be very stable, ended up removing it in hopes for FreeRDP 2 support soon), but a dynamic resize during a file transfer has other issues (segfault, broken drive map). Typically the entire RDP session just hung when I started the the file transfer (this didn't happen with strace attached, so it sounds like a race condition to me). Is this work reporting separately? > RDP "reconnect" resizing breaks Drive Mapping > - > > Key: GUACAMOLE-876 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-876 > Project: Guacamole > Issue Type: Bug > Components: guacd >Affects Versions: 1.1.0 >Reporter: Richard Lancaster >Priority: Minor > Attachments: guacd.log, guacd_resize_file_trasfer.mp4 > > > In the attached video you can see resizing a connection with the resize > method "reconnect", will halt any current file transfers (leaving corrupted > files) and sporadically leave the drive map unconnected for the new session. > > The associated guacd logs associated with the video are attached. > > Running: > * Web frontend - 1.0.0 (the official guacamole/guacamole docker image) > * Guacd - staging/1.1.0 (381ff1a4214e06803f0f587f1ed97cf7e54853e7) (Built > against ubuntu 18.04's libfreerdb-dev) > > Let me know if there is any more info you need. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (GUACAMOLE-876) RDP "reconnect" resizing breaks Drive Mapping
[ https://issues.apache.org/jira/browse/GUACAMOLE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924383#comment-16924383 ] Nick Couchman commented on GUACAMOLE-876: - Regarding the first issue - interrupting the file transfer with the "reconnect" method - I don't think this is a bug in Guacamole, nor do I think it's an issue that is resolvable. By its very nature, if you select "reconnect" as the resize method, the RDP connection will terminate and reconnect with the new size. This is not Guacamole, this is the RDP protocol for versions that don't support dynamic resizing, and it's the RDP connection (guacd -> RDP) that is terminated, not the Guacamole connection (Guacamole Client -> guacd). If you have some suggestion of how this ought to be handled, I'm open to discussing that, but otherwise I don't really see how this is a Guacamole issue?? The only reasonable solution to this seems to me to be to cancel the file transfer altogether, removing any artifacts (if possible) when this happens - but, again, because this happens at the RDP level, I'm not even sure this is feasible. The second issue may well be a guacd issue, but it also could be an RDP issue - we'll have to take a closer look and see if there's something we need to do to cleanly handle the drive reconnection. > RDP "reconnect" resizing breaks Drive Mapping > - > > Key: GUACAMOLE-876 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-876 > Project: Guacamole > Issue Type: Bug > Components: guacd >Affects Versions: 1.1.0 >Reporter: Richard Lancaster >Priority: Minor > Attachments: guacd.log, guacd_resize_file_trasfer.mp4 > > > In the attached video you can see resizing a connection with the resize > method "reconnect", will halt any current file transfers (leaving corrupted > files) and sporadically leave the drive map unconnected for the new session. > > The associated guacd logs associated with the video are attached. > > Running: > * Web frontend - 1.0.0 (the official guacamole/guacamole docker image) > * Guacd - staging/1.1.0 (381ff1a4214e06803f0f587f1ed97cf7e54853e7) (Built > against ubuntu 18.04's libfreerdb-dev) > > Let me know if there is any more info you need. -- This message was sent by Atlassian Jira (v8.3.2#803003)
