[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread xunzhang
Github user xunzhang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79295679 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

2016-09-17 Thread jiadexin
Github user jiadexin commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r79295676 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1144,9 +1144,15 @@ static char** create_pxf_plan(char **segdb_file_map, RelOptInfo *rel,

[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79295956 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79296004 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79295934 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79295805 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79295812 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79295886 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79296000 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

2016-09-17 Thread jiadexin
Github user jiadexin commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r79295630 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1144,9 +1144,15 @@ static char** create_pxf_plan(char **segdb_file_map, RelOptInfo *rel,

[GitHub] incubator-hawq issue #904: HAWQ-1060. Refactor hawq register with better rea...

2016-09-17 Thread ictmalili
Github user ictmalili commented on the issue: https://github.com/apache/incubator-hawq/pull/904 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79295436 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq pull request #904: HAWQ-1060. Refactor hawq register with bet...

2016-09-17 Thread ictmalili
Github user ictmalili commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/904#discussion_r79295485 --- Diff: tools/bin/hawqregister --- @@ -126,182 +127,319 @@ def option_parser_yml(yml_file): return 'AO', files, sizes,

[GitHub] incubator-hawq issue #904: HAWQ-1060. Refactor hawq register with better rea...

2016-09-17 Thread zhangh43
Github user zhangh43 commented on the issue: https://github.com/apache/incubator-hawq/pull/904 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if