[GitHub] incubator-hawq issue #1365: Adding equals() to Fragment, to facilitate compa...

2018-05-17 Thread mgoddard-pivotal
Github user mgoddard-pivotal commented on the issue: https://github.com/apache/incubator-hawq/pull/1365 I will embed the check for Fragment equality into my test and leave this class, Fragment, alone. ---

[GitHub] incubator-hawq issue #1365: Adding equals() to Fragment, to facilitate compa...

2018-05-15 Thread shivzone
Github user shivzone commented on the issue: https://github.com/apache/incubator-hawq/pull/1365 Nice reference @lavjain ---

[GitHub] incubator-hawq issue #1365: Adding equals() to Fragment, to facilitate compa...

2018-05-15 Thread mgoddard-pivotal
Github user mgoddard-pivotal commented on the issue: https://github.com/apache/incubator-hawq/pull/1365 Thanks for the feedback, folks! And for that excellent reference, @lavjain. ---

[GitHub] incubator-hawq issue #1365: Adding equals() to Fragment, to facilitate compa...

2018-05-15 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1365 https://ncrcoe.gitbooks.io/java-for-small-teams/content/specifics/100_know_how_to_implement_hashcode_and_equals.html ---