[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-09 Thread lavjain
Github user lavjain closed the pull request at: https://github.com/apache/incubator-hawq/pull/1249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119750193 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -111,30 +110,40 @@ public

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread sansanichfb
Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119746963 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -111,30 +110,40 @@ public

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119738385 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -111,30 +110,40 @@ public

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119739575 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenterTest.java --- @@ -164,8 +163,8 @@ public void

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119740279 --- Diff: pxf/build.gradle --- @@ -111,6 +111,10 @@ subprojects { subProject -> force

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119738227 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -111,30 +110,40 @@ public

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119739058 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -144,7 +153,7 @@ public

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119740046 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenterTest.java --- @@ -211,6 +210,90 @@ public void

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119738672 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -111,30 +110,40 @@ public

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread sansanichfb
Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119723516 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/StatsAccessor.java --- @@ -29,11 +29,13 @@ /** * Method

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread sansanichfb
Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1249#discussion_r119723348 --- Diff: pxf/build.gradle --- @@ -477,7 +481,7 @@ def buildNumber() { } task wrapper(type: Wrapper) { -gradleVersion =

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1249 HAWQ-1461. Improve partition parameters validation for PXF-JDBC plugin You can merge this pull request into a Git repository by running: $ git pull