[GitHub] incubator-hawq pull request #966: HAWQ-1112. Error message is not accurate w...

[linwen]

Github user linwen closed the pull request at:

https://github.com/apache/incubator-hawq/pull/966


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #966: HAWQ-1112. Error message is not accurate w...

[linwen]

Github user linwen commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/966#discussion_r83791311
  
--- Diff: tools/bin/hawqregister ---
@@ -498,7 +498,10 @@ class HawqRegister(object):
 hdfscmd = 'hadoop fs -du %s' % fn
 _, out, _ = local_ssh_output(hdfscmd)
 if self.sizes[k] > int(out.strip().split()[0]):
-logger.error('File size(%s) in yaml configuration file 
should not exceed actual length(%s) of file %s.' % (self.sizes[k], 
out.strip().split()[0], fn))
+if self.mode == 'usage1':
+logger.error('Specified file size(%s) should not 
exceed actual length(%s) of file %s.' % (self.sizes[k], out.strip().split()[0], 
fn))
+else:
+logger.error('File size(%s) in yaml configuration file 
should not exceed actual length(%s) of file %s.' % (self.sizes[k], 
out.strip().split()[0], fn))
--- End diff --

thank you! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #966: HAWQ-1112. Error message is not accurate w...

[xunzhang]

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/966#discussion_r83790589
  
--- Diff: tools/bin/hawqregister ---
@@ -498,7 +498,10 @@ class HawqRegister(object):
 hdfscmd = 'hadoop fs -du %s' % fn
 _, out, _ = local_ssh_output(hdfscmd)
 if self.sizes[k] > int(out.strip().split()[0]):
-logger.error('File size(%s) in yaml configuration file 
should not exceed actual length(%s) of file %s.' % (self.sizes[k], 
out.strip().split()[0], fn))
+if self.mode == 'usage1':
+logger.error('Specified file size(%s) should not 
exceed actual length(%s) of file %s.' % (self.sizes[k], out.strip().split()[0], 
fn))
+else:
+logger.error('File size(%s) in yaml configuration file 
should not exceed actual length(%s) of file %s.' % (self.sizes[k], 
out.strip().split()[0], fn))
--- End diff --

type for `%s`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #966: HAWQ-1112. Error message is not accurate w...

[linwen]

GitHub user linwen opened a pull request:

https://github.com/apache/incubator-hawq/pull/966

HAWQ-1112. Error message is not accurate when hawq register with sing…

Please review. Thanks! 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/linwen/incubator-hawq hawq-1112

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/966.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #966


commit c2084c7c7af9b5755b828e18f4c7f6b74f8d9ad1
Author: Wen Lin 
Date:   2016-10-18T06:22:06Z

HAWQ-1112. Error message is not accurate when hawq register with single 
file and the size is larger than real size.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---