[jira] [Commented] (HBASE-24347) Hadoop2 profiles are both active when pre-commit PR builds run

2020-06-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124709#comment-17124709 ] Guanghao Zhang commented on HBASE-24347: {quote}I think much of the CI refactoring I did to

[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC

2020-06-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124700#comment-17124700 ] Guanghao Zhang commented on HBASE-23296: {quote}Do you mean BucketCache with heap ioEngine?

[GitHub] [hbase] bsglz edited a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-03 Thread GitBox
bsglz edited a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-638046560 @saintstack @Apache9 Help to review it if you have time, Thanks. This is an automated message from the

[GitHub] [hbase] Apache9 opened a new pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache9 opened a new pull request #1840: URL: https://github.com/apache/hbase/pull/1840 …is strange This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Fix Version/s: 2.2.6 2.3.0 3.0.0-alpha-1 > The behavior of

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-638106437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-03 Thread GitBox
ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434376478 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java ## @@ -0,0 +1,60 @@ +/** + *

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124743#comment-17124743 ] Viraj Jasani commented on HBASE-24492: -- Let's wait for [~stack]'s confirmation. So far, pushed to

[GitHub] [hbase] gkanade opened a new pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-03 Thread GitBox
gkanade opened a new pull request #1841: URL: https://github.com/apache/hbase/pull/1841 removed RS entry from zk draining server znode on RS stopped This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache9 commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache9 commented on a change in pull request #1840: URL: https://github.com/apache/hbase/pull/1840#discussion_r434450351 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -3355,8 +3354,10 @@ public static String

[GitHub] [hbase] Apache9 commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache9 commented on a change in pull request #1840: URL: https://github.com/apache/hbase/pull/1840#discussion_r434450669 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfoBuilder.java ## @@ -302,30 +283,28 @@ public void

[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-03 Thread GitBox
bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-638046560 @saintstack @Apache9 Help review if you have time, Thanks. This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-638046066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638155059 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1837: HBASE-24496 The tab of Base Stats not actived by default in table.jsp

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-638023212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-03 Thread GitBox
ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434369134 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java ## @@ -0,0 +1,60 @@ +/** + *

[GitHub] [hbase] virajjasani commented on a change in pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1839: URL: https://github.com/apache/hbase/pull/1839#discussion_r434395602 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3521,20 +3522,33 @@ private void

[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

2020-06-03 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-21406: - Fix Version/s: 2.4.0 > "status 'replication'" should not show SINK if the

[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

2020-06-03 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-21406: - Affects Version/s: 2.4.0 2.3.0

[GitHub] [hbase] infraio commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
infraio commented on a change in pull request #1840: URL: https://github.com/apache/hbase/pull/1840#discussion_r434471121 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfoBuilder.java ## @@ -302,30 +283,28 @@ public void

[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-03 Thread GitBox
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638122516 @wchevreuil Sorry for the delay, since it remove the checkbox and use tabs in latest version, i add a new tab named Localities, including two metrics Locality and LocalityForSsd.

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638161407 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24500: - Summary: The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange Key: HBASE-24500 URL: https://issues.apache.org/jira/browse/HBASE-24500 Project: HBase

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124695#comment-17124695 ] Viraj Jasani commented on HBASE-24492: -- Thanks [~zhangduo] Exactly the loop is useless and

[jira] [Work started] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24500 started by Duo Zhang. - > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange >

[jira] [Assigned] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24500: - Assignee: Duo Zhang > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange >

[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Priority: Critical (was: Major) > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is

[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Component/s: read replicas Client > The behavior of

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-638043811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC

2020-06-03 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124834#comment-17124834 ] Anoop Sam John commented on HBASE-23296: The way we can introduce that can be this way (I

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638144743 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24492: -- Component/s: wal Replication > ProtobufLogReader.readNext does not need looping >

[GitHub] [hbase] virajjasani commented on a change in pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1839: URL: https://github.com/apache/hbase/pull/1839#discussion_r434406124 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3521,20 +3522,33 @@ private void

[GitHub] [hbase] bsglz edited a comment on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-03 Thread GitBox
bsglz edited a comment on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638122516 @wchevreuil Sorry for the delay, since it remove the checkbox and use tabs in latest version, i add a new tab named Localities, include two metrics Locality and

[GitHub] [hbase] virajjasani merged pull request #1831: HBASE-24492 : Remove infinite loop from ProtobufLogReader#readNext

2020-06-03 Thread GitBox
virajjasani merged pull request #1831: URL: https://github.com/apache/hbase/pull/1831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638076577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] infraio commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
infraio commented on a change in pull request #1840: URL: https://github.com/apache/hbase/pull/1840#discussion_r434428788 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -3355,8 +3354,10 @@ public static String

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-638083491 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638091249 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-638142852 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638149663 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124691#comment-17124691 ] Duo Zhang commented on HBASE-24492: --- OK, checked the code, there is a 'return true' at the last of the

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638074898 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] VicoWu commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-06-03 Thread GitBox
VicoWu commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-638133811 @Apache9 Thanks so much. I have fixed the checkstyle issue and also enhance the test case for my fix. Currently everything is fine now. Please help to re-review it. Thanks

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638132429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24499: - Fix Version/s: (was: 2.3.0) 2.4.0 > Use a client property for

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125106#comment-17125106 ] Hudson commented on HBASE-24492: Results for branch master [build #1746 on

[jira] [Commented] (HBASE-24488) Update docs re: ZooKeeper compatibility of 2.3.x release

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125101#comment-17125101 ] Hudson commented on HBASE-24488: Results for branch master [build #1746 on

[jira] [Commented] (HBASE-24418) Consolidate Normalizer implementations

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125103#comment-17125103 ] Hudson commented on HBASE-24418: Results for branch master [build #1746 on

[jira] [Commented] (HBASE-24486) Remove the unused method online in admin.rb

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125102#comment-17125102 ] Hudson commented on HBASE-24486: Results for branch master [build #1746 on

[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125105#comment-17125105 ] Hudson commented on HBASE-24412: Results for branch master [build #1746 on

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638310608 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-22738) Fallback to default group to choose RS when there are no RS in current group

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125104#comment-17125104 ] Hudson commented on HBASE-22738: Results for branch master [build #1746 on

[GitHub] [hbase] joshelser commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
joshelser commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434713054 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[jira] [Assigned] (HBASE-24503) Backport HBASE-24492 to all 2.x branch

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24503: Assignee: Viraj Jasani > Backport HBASE-24492 to all 2.x branch >

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-638330509 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk merged pull request #1845: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
ndimiduk merged pull request #1845: URL: https://github.com/apache/hbase/pull/1845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HBASE-24309) Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24309. -- Resolution: Fixed Pushed addendums to branch-2 and branch-2.3. > Avoid introducing log4j and

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638345198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1552: URL: https://github.com/apache/hbase/pull/1552#issuecomment-638345369 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r434758421 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,543 @@ +/* + * + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638371296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638371496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-638395777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

2020-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125093#comment-17125093 ] Andrew Kyle Purtell commented on HBASE-24499: - Sounds good > Use a client property for

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-638316749 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk opened a new pull request #1845: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
ndimiduk opened a new pull request #1845: URL: https://github.com/apache/hbase/pull/1845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-06-03 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125153#comment-17125153 ] Istvan Toth commented on HBASE-24252: - Don't worry about it [~elserj], there's no need to bloat the

[jira] [Commented] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125164#comment-17125164 ] Nick Dimiduk commented on HBASE-24280: -- For example,

[jira] [Reopened] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24280: -- > Hadoop2 and Hadoop3 profiles being activated simultaneously causing test > failures >

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638411813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-03 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124990#comment-17124990 ] ramkrishna.s.vasudevan commented on HBASE-24205: bq.Then I wonder if these Store-based

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638256596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk opened a new pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
ndimiduk opened a new pull request #1844: URL: https://github.com/apache/hbase/pull/1844 * Add a section calling out our categorical lack of support for non-LTS Java versions. * Provide clarification as to the meaning of the 'red x' in our support matrix. * Transpose the

[GitHub] [hbase] saintstack commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
saintstack commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638346107 bq. should a simple fact of deserialization have such a side effect on tasks... No. That is wonky. For this reason alone we should apply this patch. Will

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434744701 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotHFileCleaner.java ## @@ -148,15 +156,37 @@ public void

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434769865 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java ## @@ -383,25 +385,38 @@ public static

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125119#comment-17125119 ] Viraj Jasani commented on HBASE-24492: -- I just looked at branch-1 and this is applicable there also

[jira] [Assigned] (HBASE-24495) ExportSnapshot which does not honor the case that working dir/root dir are from different filesystem

2020-06-03 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-24495: Assignee: Huaxiang Sun > ExportSnapshot which does not honor the case that working

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638321971 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24492: - Fix Version/s: 1.7.0 Hadoop Flags: Reviewed Resolution: Fixed Status:

[jira] [Created] (HBASE-24503) Backport HBASE-24492 to all 2.x branch

2020-06-03 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-24503: Summary: Backport HBASE-24492 to all 2.x branch Key: HBASE-24503 URL: https://issues.apache.org/jira/browse/HBASE-24503 Project: HBase Issue Type: Sub-task

[jira] [Reopened] (HBASE-24309) Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24309: -- Looks like this one is cause of a new compiler warning. Reopening for addendum. {noformat}

[GitHub] [hbase] Apache-HBase commented on pull request #1845: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1845: URL: https://github.com/apache/hbase/pull/1845#issuecomment-638338450 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1845: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1845: URL: https://github.com/apache/hbase/pull/1845#issuecomment-638338358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434744521 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotHFileCleaner.java ## @@ -137,8 +138,15 @@ public void

[GitHub] [hbase] saintstack commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-03 Thread GitBox
saintstack commented on a change in pull request #1825: URL: https://github.com/apache/hbase/pull/1825#discussion_r434743949 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,

[jira] [Commented] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125169#comment-17125169 ] Nick Dimiduk commented on HBASE-24280: -- Oh, I see. The variable {{BRANCH_NAME}} is the name of the

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
anoopsjohn commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r434750284 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,543 @@ +/* + * + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638372347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434772239 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java ## @@ -93,12 +94,17 @@ public void

[GitHub] [hbase] huaxiangsun commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638405644 @z-york I uploaded a new patch which addresses some of your comments, put up explain for rest of your comments. Please let me know if there is anything missing, thanks.

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125098#comment-17125098 ] Viraj Jasani commented on HBASE-24492: -- Yup, it's committed to master and branch-2 both with Duo's

[jira] [Assigned] (HBASE-23927) hbck2 assigns command should accept a file containing a list of region names

2020-06-03 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-23927: Assignee: Clara Xiong (was: Huaxiang Sun) > hbck2 assigns command should accept a file

[jira] [Created] (HBASE-24502) hbase hfile command logs exception message at WARN level.

2020-06-03 Thread Rushabh Shah (Jira)
Rushabh Shah created HBASE-24502: Summary: hbase hfile command logs exception message at WARN level. Key: HBASE-24502 URL: https://issues.apache.org/jira/browse/HBASE-24502 Project: HBase

[GitHub] [hbase] saintstack commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-03 Thread GitBox
saintstack commented on a change in pull request #1825: URL: https://github.com/apache/hbase/pull/1825#discussion_r434763752 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,

[GitHub] [hbase] ndimiduk commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
ndimiduk commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638385363 Testing with #1833 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-638317257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24503) Backport HBASE-24492 to all 2.x branch

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24503: - Fix Version/s: 2.2.6 2.1.10 2.3.1 > Backport HBASE-24492

[GitHub] [hbase] Apache-HBase commented on pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1552: URL: https://github.com/apache/hbase/pull/1552#issuecomment-638341617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   3   >