[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-716101026 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-716102342 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Resolved] (HBASE-24015) Coverage for Assign and Unassign of Regions on RegionServer on failure

2020-10-25 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24015. -- Hadoop Flags: Reviewed Resolution: Fixed > Coverage for Assign and Unassign of Regions

[jira] [Updated] (HBASE-25131) While emitting the memstore read based metrics use # instead of _ while emitting them metric

2020-10-25 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25131: - Fix Version/s: (was: 2.2.7) (was: 2.3.3) (was:

[GitHub] [hbase] virajjasani commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-25 Thread GitBox
virajjasani commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-716120923 Triggered a new build in the meanwhile. This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (HBASE-25019) check if we're impacted by MASSEMBLY-941 and mitigate if needed

2020-10-25 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25019: - Fix Version/s: (was: 2.3.3) 2.3.4 2.4.0 > check if

[jira] [Updated] (HBASE-24813) ReplicationSource should clear buffer usage on ReplicationSourceManager upon termination

2020-10-25 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24813: - Fix Version/s: (was: 2.3.3) 2.3.4 > ReplicationSource should clear

[GitHub] [hbase] virajjasani commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-25 Thread GitBox
virajjasani commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-716121342 Since recent commits came 3-4 days back and we might not have more chances of nightlies running with this backport, maybe we can wait till 2.3.3 lands? WDYT @ndimiduk ?

[GitHub] [hbase] Reidddddd merged pull request #2549: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-25 Thread GitBox
Reidd merged pull request #2549: URL: https://github.com/apache/hbase/pull/2549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-25 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25156. -- Hadoop Flags: Reviewed Resolution: Fixed Now that  HBASE-24628 is resolved with

[jira] [Updated] (HBASE-25187) Improve SizeCachedKV variants initialization

2020-10-25 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25187: - Fix Version/s: (was: 2.3.3) 2.3.4 2.4.0 > Improve

[jira] [Updated] (HBASE-21946) Replace the byte[] pread by ByteBuffer pread in HFileBlock reading once HDFS-3246 prepared

2020-10-25 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-21946: - Fix Version/s: (was: 2.3.3) 2.3.4 > Replace the byte[] pread by

[jira] [Updated] (HBASE-24792) return value of LogRoller.walRollFinished may be wrong

2020-10-25 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24792: - Fix Version/s: (was: 2.3.3) 2.3.4 > return value of

[GitHub] [hbase] Apache-HBase commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-716125636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2583: HBASE-25215 TestClientOperationTimeout.testScanTimeout is flaky

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2583: URL: https://github.com/apache/hbase/pull/2583#issuecomment-716154418 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Work started] (HBASE-25215) TestClientOperationTimeout.testScanTimeout is flaky

2020-10-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25215 started by Duo Zhang. - > TestClientOperationTimeout.testScanTimeout is flaky >

[GitHub] [hbase] Apache-HBase commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-716141913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220291#comment-17220291 ] Hudson commented on HBASE-25206: Results for branch master [build #105 on

[jira] [Commented] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220356#comment-17220356 ] Hudson commented on HBASE-25206: Results for branch branch-2 [build #83 on

[GitHub] [hbase] Apache-HBase commented on pull request #2583: HBASE-25215 TestClientOperationTimeout.testScanTimeout is flaky

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2583: URL: https://github.com/apache/hbase/pull/2583#issuecomment-716171411 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2548: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2548: URL: https://github.com/apache/hbase/pull/2548#issuecomment-716145776 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 13m

[jira] [Commented] (HBASE-25215) TestClientOperationTimeout.testScanTimeout is flaky

2020-10-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220290#comment-17220290 ] Duo Zhang commented on HBASE-25215: --- I think the problem is that, when we add delay for scan, we will

[GitHub] [hbase] Apache9 opened a new pull request #2583: HBASE-25215 TestClientOperationTimeout.testScanTimeout is flaky

2020-10-25 Thread GitBox
Apache9 opened a new pull request #2583: URL: https://github.com/apache/hbase/pull/2583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220348#comment-17220348 ] Hudson commented on HBASE-25206: Results for branch branch-2.3 [build #89 on

[jira] [Created] (HBASE-25215) TestClientOperationTimeout.testScanTimeout is flaky

2020-10-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25215: - Summary: TestClientOperationTimeout.testScanTimeout is flaky Key: HBASE-25215 URL: https://issues.apache.org/jira/browse/HBASE-25215 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2374: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.3

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2374: URL: https://github.com/apache/hbase/pull/2374#issuecomment-716153139 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2583: HBASE-25215 TestClientOperationTimeout.testScanTimeout is flaky

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2583: URL: https://github.com/apache/hbase/pull/2583#issuecomment-716172622 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ddupg commented on a change in pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-25 Thread GitBox
ddupg commented on a change in pull request #2579: URL: https://github.com/apache/hbase/pull/2579#discussion_r511707449 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ReplicationServerManager.java ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #2586: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2586: URL: https://github.com/apache/hbase/pull/2586#issuecomment-716313488 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2542: URL: https://github.com/apache/hbase/pull/2542#issuecomment-716214478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

[GitHub] [hbase] huaxiangsun commented on pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-25 Thread GitBox
huaxiangsun commented on pull request #2570: URL: https://github.com/apache/hbase/pull/2570#issuecomment-716266724 Will post a new patch based on master, the major change in the master branch is that meta replica # is part of meta table, test and selector initialization needs to be

[jira] [Commented] (HBASE-25215) TestClientOperationTimeout.testScanTimeout is flaky

2020-10-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220445#comment-17220445 ] Duo Zhang commented on HBASE-25215: --- Merged to master. Thanks [~zghao] for reviewing. Let's see

[GitHub] [hbase] Reidddddd commented on pull request #2548: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-25 Thread GitBox
Reidd commented on pull request #2548: URL: https://github.com/apache/hbase/pull/2548#issuecomment-716272020 It is exactly the same as other codes ``` if (request.hasCondition()) { regionServer.metricsRegionServer.updateCheckAndDelete(

[GitHub] [hbase] Reidddddd merged pull request #2548: HBASE-25189 [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-25 Thread GitBox
Reidd merged pull request #2548: URL: https://github.com/apache/hbase/pull/2548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ddupg commented on a change in pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-25 Thread GitBox
ddupg commented on a change in pull request #2579: URL: https://github.com/apache/hbase/pull/2579#discussion_r511707355 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -288,39 +258,26 @@ public boolean

[jira] [Created] (HBASE-25217) [Metrics] Add metrics for Call in IPC response queue

2020-10-25 Thread Reid Chan (Jira)
Reid Chan created HBASE-25217: - Summary: [Metrics] Add metrics for Call in IPC response queue Key: HBASE-25217 URL: https://issues.apache.org/jira/browse/HBASE-25217 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-716293355 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Reidddddd opened a new pull request #2586: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

2020-10-25 Thread GitBox
Reidd opened a new pull request #2586: URL: https://github.com/apache/hbase/pull/2586 Seems there's no way to add this metrics for NettyRpcServer This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HBASE-22769) Runtime Error on join (with filter) when using hbase-spark connector

2020-10-25 Thread RISHAV DUTTA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220467#comment-17220467 ] RISHAV DUTTA commented on HBASE-22769: -- Hi can I work on this issue?   > Runtime Error on join

[GitHub] [hbase] Reidddddd opened a new pull request #2585: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

2020-10-25 Thread GitBox
Reidd opened a new pull request #2585: URL: https://github.com/apache/hbase/pull/2585 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-716298879 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2542: URL: https://github.com/apache/hbase/pull/2542#issuecomment-716198407 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-10-25 Thread GitBox
Apache-HBase commented on pull request #2542: URL: https://github.com/apache/hbase/pull/2542#issuecomment-716212572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio commented on a change in pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-25 Thread GitBox
infraio commented on a change in pull request #2579: URL: https://github.com/apache/hbase/pull/2579#discussion_r511674844 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ReplicationServerManager.java ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache

[jira] [Created] (HBASE-25216) TestSeparateClientZKCluster is brolem for branch-2

2020-10-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25216: - Summary: TestSeparateClientZKCluster is brolem for branch-2 Key: HBASE-25216 URL: https://issues.apache.org/jira/browse/HBASE-25216 Project: HBase Issue Type: Bug

[jira] [Resolved] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-25 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-25189. --- Hadoop Flags: Reviewed Resolution: Fixed > [Metrics] Add checkAndPut and checkAndDelete

[GitHub] [hbase] Apache9 merged pull request #2583: HBASE-25215 TestClientOperationTimeout.testScanTimeout is flaky

2020-10-25 Thread GitBox
Apache9 merged pull request #2583: URL: https://github.com/apache/hbase/pull/2583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-25 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25189: -- Fix Version/s: 2.2.7 1.7.0 2.3.3

[jira] [Updated] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-25 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25189: -- Description: Add *checkAndPut* and *checkAndDelete* table latency metrics. > [Metrics] Add

[jira] [Updated] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-25 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25189: -- Component/s: metrics > [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level >

[GitHub] [hbase] huaxiangsun opened a new pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-25 Thread GitBox
huaxiangsun opened a new pull request #2584: URL: https://github.com/apache/hbase/pull/2584 … load over meta replica regions It adds load balance support for meta lookup in AsyncTableRegionLocator. The existing meta replica mode is renamed as "HedgedRead", client sends scan