[GitHub] [hbase] Apache-HBase commented on pull request #3385: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3385: URL: https://github.com/apache/hbase/pull/3385#issuecomment-862100592 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3385: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3385: URL: https://github.com/apache/hbase/pull/3385#issuecomment-862162568 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652485054 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652487758 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652487568 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3378: HBASE-25968 Request compact to compaction server

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3378: URL: https://github.com/apache/hbase/pull/3378#issuecomment-862095896 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3390: HBASE-25976 Implement a master based ReplicationTracker

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3390: URL: https://github.com/apache/hbase/pull/3390#issuecomment-862175345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652482730 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java ## @@ -1465,37 +1465,6 @@ public void

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652490713 ## File path: hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift ## @@ -296,6 +318,187 @@ enum TCompareOp { NO_OP = 6 }

[GitHub] [hbase] Apache-HBase commented on pull request #3385: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3385: URL: https://github.com/apache/hbase/pull/3385#issuecomment-862070355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3378: HBASE-25968 Request compact to compaction server

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3378: URL: https://github.com/apache/hbase/pull/3378#issuecomment-862096283 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Reidddddd commented on a change in pull request #3385: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #3385: URL: https://github.com/apache/hbase/pull/3385#discussion_r652457713 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestPostIncrementAndAppendBeforeWAL.java ## @@ -232,4 +318,25 @@ private

[GitHub] [hbase] Apache-HBase commented on pull request #3373: HBASE-25980 Master table.jsp pointed at meta throws 500 when no all r…

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3373: URL: https://github.com/apache/hbase/pull/3373#issuecomment-862109028 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Reidddddd commented on a change in pull request #3385: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #3385: URL: https://github.com/apache/hbase/pull/3385#discussion_r652458898 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestPostIncrementAndAppendBeforeWAL.java ## @@ -161,6 +173,80 @@ public

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652491718 ## File path: hbase-thrift/src/main/resources/hbase-webapps/thrift/thrift.jsp ## @@ -93,11 +98,6 @@ String framed =

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652483439 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java ## @@ -97,8 +93,13 @@ import static

[GitHub] [hbase] Reidddddd commented on a change in pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-16 Thread GitBox
Reidd commented on a change in pull request #2941: URL: https://github.com/apache/hbase/pull/2941#discussion_r652488577 ## File path: hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java ## @@ -1,40 +1,49 @@ /* - * Copyright The Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3390: HBASE-25976 Implement a master based ReplicationTracker

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3390: URL: https://github.com/apache/hbase/pull/3390#issuecomment-862098596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3378: HBASE-25968 Request compact to compaction server

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3378: URL: https://github.com/apache/hbase/pull/3378#issuecomment-862146614 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3390: HBASE-25976 Implement a master based ReplicationTracker

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3390: URL: https://github.com/apache/hbase/pull/3390#issuecomment-862186013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26008) Fix typo in AsyncConnectionImpl

2021-06-16 Thread Yulin Niu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364236#comment-17364236 ] Yulin Niu commented on HBASE-26008: --- push to master, thanks [~zhangduo]'s reviewing > Fix typo in

[jira] [Resolved] (HBASE-26008) Fix typo in AsyncConnectionImpl

2021-06-16 Thread Yulin Niu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yulin Niu resolved HBASE-26008. --- Resolution: Fixed > Fix typo in AsyncConnectionImpl > --- > >

[GitHub] [hbase] nyl3532016 opened a new pull request #3391: HBASE-26008 Fix typo in AsyncConnectionImpl

2021-06-16 Thread GitBox
nyl3532016 opened a new pull request #3391: URL: https://github.com/apache/hbase/pull/3391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Updated] (HBASE-26008) Fix typo in AsyncConnectionImpl

2021-06-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26008: -- Component/s: Client > Fix typo in AsyncConnectionImpl > --- > >

[GitHub] [hbase] Apache-HBase commented on pull request #3378: HBASE-25968 Request compact to compaction server

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3378: URL: https://github.com/apache/hbase/pull/3378#issuecomment-862223592 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3391: HBASE-26008 Fix typo in AsyncConnectionImpl

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3391: URL: https://github.com/apache/hbase/pull/3391#issuecomment-862237947 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Reidddddd commented on pull request #3385: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

2021-06-16 Thread GitBox
Reidd commented on pull request #3385: URL: https://github.com/apache/hbase/pull/3385#issuecomment-862199002 Please also pay attention to the checkstyle warnings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Created] (HBASE-26008) Fix typo in AsyncConnectionImpl

2021-06-16 Thread Yulin Niu (Jira)
Yulin Niu created HBASE-26008: - Summary: Fix typo in AsyncConnectionImpl Key: HBASE-26008 URL: https://issues.apache.org/jira/browse/HBASE-26008 Project: HBase Issue Type: Improvement

[jira] [Commented] (HBASE-26000) Optimize the display of ZK dump in the master web UI

2021-06-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364296#comment-17364296 ] Hudson commented on HBASE-26000: Results for branch master [build #324 on

[jira] [Commented] (HBASE-25997) NettyRpcFrameDecoder decode request header wrong when handleTooBigRequest

2021-06-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364295#comment-17364295 ] Hudson commented on HBASE-25997: Results for branch master [build #324 on

[GitHub] [hbase] Apache-HBase commented on pull request #3378: HBASE-25968 Request compact to compaction server

2021-06-16 Thread GitBox
Apache-HBase commented on pull request #3378: URL: https://github.com/apache/hbase/pull/3378#issuecomment-86037 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26000) Optimize the display of ZK dump in the master web UI

2021-06-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364408#comment-17364408 ] Hudson commented on HBASE-26000: Results for branch branch-2.3 [build #238 on

[jira] [Commented] (HBASE-25998) Revisit synchronization in SyncFuture

2021-06-16 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364520#comment-17364520 ] Bharath Vissapragada commented on HBASE-25998: -- Thanks [~apurtell] for trying out the patch

[jira] [Commented] (HBASE-26000) Optimize the display of ZK dump in the master web UI

2021-06-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364446#comment-17364446 ] Hudson commented on HBASE-26000: Results for branch branch-2 [build #278 on

[jira] [Comment Edited] (HBASE-25998) Revisit synchronization in SyncFuture

2021-06-16 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364520#comment-17364520 ] Bharath Vissapragada edited comment on HBASE-25998 at 6/16/21, 9:21 PM:

[jira] [Commented] (HBASE-25975) Row commit sequencer

2021-06-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364618#comment-17364618 ] Andrew Kyle Purtell commented on HBASE-25975: - Latest code with better microbenchmark,

[jira] [Comment Edited] (HBASE-25975) Row commit sequencer

2021-06-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364618#comment-17364618 ] Andrew Kyle Purtell edited comment on HBASE-25975 at 6/17/21, 1:09 AM:

[jira] [Commented] (HBASE-25975) Row commit sequencer

2021-06-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364624#comment-17364624 ] Andrew Kyle Purtell commented on HBASE-25975: - Performance is good enough for the first

[jira] [Commented] (HBASE-22657) HBase : STUCK Region-In-Transition

2021-06-16 Thread kangTwang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364655#comment-17364655 ] kangTwang commented on HBASE-22657: --- Hi：     I also have this problem here. Have you solved it now？？

[jira] [Comment Edited] (HBASE-25975) Row commit sequencer

2021-06-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364618#comment-17364618 ] Andrew Kyle Purtell edited comment on HBASE-25975 at 6/17/21, 1:01 AM:

[jira] [Comment Edited] (HBASE-25975) Row commit sequencer

2021-06-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364618#comment-17364618 ] Andrew Kyle Purtell edited comment on HBASE-25975 at 6/17/21, 1:00 AM:

[jira] [Created] (HBASE-26009) Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-16 Thread Toshihiro Suzuki (Jira)
Toshihiro Suzuki created HBASE-26009: Summary: Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3 Key: HBASE-26009 URL:

[jira] [Updated] (HBASE-26009) Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-16 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-26009: - Fix Version/s: 2.3.6 > Backport HBASE-25766 "Introduce RegionSplitRestriction that

[jira] [Updated] (HBASE-26010) Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-16 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-26010: - Fix Version/s: 2.3.6 > Backport HBASE-25703 and HBASE-26002 to branch-2.3 >

[jira] [Updated] (HBASE-26010) Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-16 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-26010: - Issue Type: Improvement (was: Bug) > Backport HBASE-25703 and HBASE-26002 to

[jira] [Created] (HBASE-26010) Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-16 Thread Toshihiro Suzuki (Jira)
Toshihiro Suzuki created HBASE-26010: Summary: Backport HBASE-25703 and HBASE-26002 to branch-2.3 Key: HBASE-26010 URL: https://issues.apache.org/jira/browse/HBASE-26010 Project: HBase

[jira] [Issue Comment Deleted] (HBASE-25975) Row commit sequencer

2021-06-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Comment: was deleted (was: The microbenchmark is going to be very helpful. Right

[jira] [Comment Edited] (HBASE-25975) Row commit sequencer

2021-06-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364618#comment-17364618 ] Andrew Kyle Purtell edited comment on HBASE-25975 at 6/17/21, 2:16 AM: