[jira] [Commented] (HBASE-25739) TableSkewCostFunction need to use aggregated deviation

2021-06-22 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367582#comment-17367582 ] Clara Xiong commented on HBASE-25739: - subtask created.  

[GitHub] [hbase] Apache-HBase commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-866150388 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25739) TableSkewCostFunction need to use aggregated deviation

2021-06-22 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367577#comment-17367577 ] Clara Xiong commented on HBASE-25739: - There is another bug in the original tableSkew cost function

[GitHub] [hbase] joshelser commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2021-06-22 Thread GitBox
joshelser commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-866287839 Mentioning here as the recommendation of Zach, I'm trying to see if we can get an answer as to whether or not we think a default=false configuration option to automatically

[jira] [Commented] (HBASE-25992) Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596

2021-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367575#comment-17367575 ] Hudson commented on HBASE-25992: Results for branch branch-2 [build #283 on

[jira] [Created] (HBASE-26023) Overhaul of test cluster set up for table skew

2021-06-22 Thread Clara Xiong (Jira)
Clara Xiong created HBASE-26023: --- Summary: Overhaul of test cluster set up for table skew Key: HBASE-26023 URL: https://issues.apache.org/jira/browse/HBASE-26023 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-866153764 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25739) TableSkewCostFunction need to use aggregated deviation

2021-06-22 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367625#comment-17367625 ] Clara Xiong commented on HBASE-25739: - Because of the fix, the default 0.05 minCostNeedBalance will

[jira] [Updated] (HBASE-26023) Overhaul of test cluster set up for table skew

2021-06-22 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated HBASE-26023: Description: There is another bug in the original tableSkew cost function for aggregation of the

[jira] [Updated] (HBASE-26023) Overhaul of test cluster set up for table skew

2021-06-22 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated HBASE-26023: Environment: {code:java}  {code} was: There is another bug in the original tableSkew cost

[jira] [Created] (HBASE-26024) Region server JVM Crash - A fatal error has been detected by the Java Runtime Environment

2021-06-22 Thread Mohamed Mohideen Meeran (Jira)
Mohamed Mohideen Meeran created HBASE-26024: --- Summary: Region server JVM Crash - A fatal error has been detected by the Java Runtime Environment Key: HBASE-26024 URL:

[GitHub] [hbase] z-york commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
z-york commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656625420 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -297,6 +297,30 @@ public void enableCacheOnWrite() {

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-22 Thread GitBox
tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-866451946 Hi @jojochuang , could you please take a look at this? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] z-york commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
z-york commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656623653 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectInStoreFlushContext.java ## @@ -33,11 +33,11 @@ * To be used only

[GitHub] [hbase] Apache-HBase commented on pull request #3413: HBASE-21674 complement the admin operations in thrift2

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3413: URL: https://github.com/apache/hbase/pull/3413#issuecomment-866490203 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26024) Region server JVM Crash - A fatal error has been detected by the Java Runtime Environment

2021-06-22 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367840#comment-17367840 ] Anoop Sam John commented on HBASE-26024: bq.we used the workaround by switching

[GitHub] [hbase] z-york commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
z-york commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656622944 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectInStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + * Licensed

[GitHub] [hbase] jojochuang commented on pull request #3408: HBASE-26019 Remove reflections used in HBaseConfiguration.getPassword()

2021-06-22 Thread GitBox
jojochuang commented on pull request #3408: URL: https://github.com/apache/hbase/pull/3408#issuecomment-866445027 Thanks a lot for the review, @wchevreuil @virajjasani and @tomscut . I'll merge it. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] jojochuang merged pull request #3408: HBASE-26019 Remove reflections used in HBaseConfiguration.getPassword()

2021-06-22 Thread GitBox
jojochuang merged pull request #3408: URL: https://github.com/apache/hbase/pull/3408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (HBASE-26019) Remove reflections used in HBaseConfiguration.getPassword()

2021-06-22 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HBASE-26019. - Resolution: Fixed Thanks again for the review, [~wchevreuil] [~vjasani] and [~tomscut]

[jira] [Commented] (HBASE-25937) Clarify UnknownRegionException

2021-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367820#comment-17367820 ] Hudson commented on HBASE-25937: Results for branch branch-2.4 [build #148 on

[jira] [Commented] (HBASE-25877) Add access check for compactionSwitch

2021-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367821#comment-17367821 ] Hudson commented on HBASE-25877: Results for branch branch-2.4 [build #148 on

[GitHub] [hbase] ddupg commented on a change in pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

2021-06-22 Thread GitBox
ddupg commented on a change in pull request #3405: URL: https://github.com/apache/hbase/pull/3405#discussion_r656720923 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -163,6 +169,44 @@ private final ConcurrentNavigableMap

[jira] [Commented] (HBASE-22769) Runtime Error on join (with filter) when using hbase-spark connector

2021-06-22 Thread Nero Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367794#comment-17367794 ] Nero Wang commented on HBASE-22769: --- I'm also put scala-library-2.12.13 and SparkHbase_Connector under

[jira] [Commented] (HBASE-26023) Overhaul of test cluster set up for table skew

2021-06-22 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367770#comment-17367770 ] Clara Xiong commented on HBASE-26023: -   {code:java} 2021-06-22T15:51:12,959 INFO  [Time-limited

[GitHub] [hbase] Apache9 commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-22 Thread GitBox
Apache9 commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-866550414 Sorry for the delay... @virajjasani Please help merging this PR? I have a meeting soon. Thanks. -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-22 Thread GitBox
tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-866523876 > +1 Thanks @virajjasani for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-865622066 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Updated] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-26013: -- Fix Version/s: 3.0.0-alpha-1 > Get operations readRows metrics becomes zero after HBASE-25677 >

[jira] [Updated] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-26013: -- Priority: Minor (was: Major) > Get operations readRows metrics becomes zero after HBASE-25677 >

[GitHub] [hbase] Apache-HBase commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-865329254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] clarax commented on pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

2021-06-22 Thread GitBox
clarax commented on pull request #3356: URL: https://github.com/apache/hbase/pull/3356#issuecomment-865302988 Any more concerns? @busbey @saintstack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] virajjasani edited a comment on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-22 Thread GitBox
virajjasani edited a comment on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-864370215 I think rather than site config, having a switch command would be more beneficial. Something like `switch_cluster_normalizer /` would not require us to re-deploy

[GitHub] [hbase] ndimiduk commented on pull request #3396: HBASE-26010 Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-22 Thread GitBox
ndimiduk commented on pull request #3396: URL: https://github.com/apache/hbase/pull/3396#issuecomment-865447040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [hbase] virajjasani merged pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-06-22 Thread GitBox
virajjasani merged pull request #3215: URL: https://github.com/apache/hbase/pull/3215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Reidddddd merged pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-22 Thread GitBox
Reidd merged pull request #2941: URL: https://github.com/apache/hbase/pull/2941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (HBASE-26022) DNS jitter causes hbase client to get stuck

2021-06-22 Thread zhuobin zheng (Jira)
zhuobin zheng created HBASE-26022: - Summary: DNS jitter causes hbase client to get stuck Key: HBASE-26022 URL: https://issues.apache.org/jira/browse/HBASE-26022 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3403: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3403: URL: https://github.com/apache/hbase/pull/3403#issuecomment-864762862 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3406: HBASE-26015 Should implement getRegionServers(boolean) method in Asyn…

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3406: URL: https://github.com/apache/hbase/pull/3406#issuecomment-864809668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] Apache-HBase commented on pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #251: URL: https://github.com/apache/hbase/pull/251#issuecomment-865595259 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-865464340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Updated] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-26013: -- Fix Version/s: 1.7.1 > Get operations readRows metrics becomes zero after HBASE-25677 >

[jira] [Updated] (HBASE-26022) DNS jitter causes hbase client to get stuck

2021-06-22 Thread zhuobin zheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuobin zheng updated HBASE-26022: -- Description: In our product hbase cluster, we occasionally encounter below errors, and stuck

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367062#comment-17367062 ] Viraj Jasani commented on HBASE-26021: -- Found same issue with current branch-2.3. The moment when I

[jira] [Updated] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-26021: - Attachment: Screenshot 2021-06-22 at 12.54.30 PM.png Screenshot 2021-06-22 at

[GitHub] [hbase] Reidddddd merged pull request #3404: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread GitBox
Reidd merged pull request #3404: URL: https://github.com/apache/hbase/pull/3404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-865461147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] tomscut edited a comment on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-22 Thread GitBox
tomscut edited a comment on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864964892 > I see +1 already from @Apache9. Are we waiting for some one else's comments to be addressed? > Agree the test failures look unrelated. Rerunning tests just to be

[GitHub] [hbase] Apache-HBase commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-864984371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] Apache-HBase commented on pull request #3402: HBASE-25130 - Fix master in-memory server holding map after:

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3402: URL: https://github.com/apache/hbase/pull/3402#issuecomment-864842245 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26022) DNS jitter causes hbase client to get stuck

2021-06-22 Thread zhuobin zheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuobin zheng updated HBASE-26022: -- Description: In our product hbase cluster, we occasionally encounter  errors   > DNS jitter

[jira] [Comment Edited] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367062#comment-17367062 ] Viraj Jasani edited comment on HBASE-26021 at 6/22/21, 7:27 AM: Found

[jira] [Comment Edited] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367062#comment-17367062 ] Viraj Jasani edited comment on HBASE-26021 at 6/22/21, 7:26 AM: Found

[jira] [Comment Edited] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367062#comment-17367062 ] Viraj Jasani edited comment on HBASE-26021 at 6/22/21, 7:28 AM: Found

[GitHub] [hbase] Reidddddd merged pull request #3403: HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid

2021-06-22 Thread GitBox
Reidd merged pull request #3403: URL: https://github.com/apache/hbase/pull/3403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3408: HBASE-26019 Remove reflections used in HBaseConfiguration.getPassword()

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3408: URL: https://github.com/apache/hbase/pull/3408#issuecomment-865072654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] vli02 commented on pull request #3402: HBASE-25130 - Fix master in-memory server holding map after:

2021-06-22 Thread GitBox
vli02 commented on pull request #3402: URL: https://github.com/apache/hbase/pull/3402#issuecomment-865300183 @virajjasani @apurtell Can you please help review and merge this if everything looks good? thanks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] z-york commented on pull request #2114: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2021-06-22 Thread GitBox
z-york commented on pull request #2114: URL: https://github.com/apache/hbase/pull/2114#issuecomment-865234155 @petersomogyi It's probably worth pinging on https://github.com/apache/hbase/pull/2113 and subsequent PRs as that's where most of the conversation happened. I thought Stephen had

[GitHub] [hbase] anoopsjohn commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-22 Thread GitBox
anoopsjohn commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864961454 I see +1 already from @Apache9. Are we waiting for some one else's comments to be addressed? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] ndimiduk commented on a change in pull request #3395: HBASE-26009 Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-22 Thread GitBox
ndimiduk commented on a change in pull request #3395: URL: https://github.com/apache/hbase/pull/3395#discussion_r655802538 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DelimitedKeyPrefixRegionSplitPolicy.java ## @@ -37,7 +37,11 @@ *

[GitHub] [hbase] tomscut removed a comment on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-22 Thread GitBox
tomscut removed a comment on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864965924 > Agree the test failures look unrelated. Rerunning tests just to be sure. We can look at this. @anoopsjohn -- This is an automated message from the Apache Git

[jira] [Commented] (HBASE-25761) POC: hbase:meta,,1 as ROOT

2021-06-22 Thread Francis Christopher Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367137#comment-17367137 ] Francis Christopher Liu commented on HBASE-25761: - I see, thanks for clarifying. I think

[GitHub] [hbase] Apache-HBase commented on pull request #3411: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3411: URL: https://github.com/apache/hbase/pull/3411#issuecomment-865738028 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-864930429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3409: HBASE-26020 Split TestWALEntryStream.testDifferentCounts out

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3409: URL: https://github.com/apache/hbase/pull/3409#issuecomment-865198406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] Apache-HBase commented on pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3405: URL: https://github.com/apache/hbase/pull/3405#issuecomment-864915997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] GeorryHuang commented on pull request #3388: HBASE-26005 Update ref guide about the EOL for 2.2.x

2021-06-22 Thread GitBox
GeorryHuang commented on pull request #3388: URL: https://github.com/apache/hbase/pull/3388#issuecomment-864769346 > The hadoop support matrix is still broken? I can just see an empty table... Forgot to check my emails and missed this comment. Thanks for reviewing -- This is an

[GitHub] [hbase] Reidddddd merged pull request #3387: HBASE-26004: port HBASE-26001 (cell level tags invisible in atomic operations when access control is on)to branch-1

2021-06-22 Thread GitBox
Reidd merged pull request #3387: URL: https://github.com/apache/hbase/pull/3387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache9 commented on pull request #3395: HBASE-26009 Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-22 Thread GitBox
Apache9 commented on pull request #3395: URL: https://github.com/apache/hbase/pull/3395#issuecomment-865015410 This is a new feature? Is it suitable to be backported to 2.3? @ndimiduk -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] YutSean commented on pull request #3404: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread GitBox
YutSean commented on pull request #3404: URL: https://github.com/apache/hbase/pull/3404#issuecomment-864879844 It seems that the UT failures are not related with the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-22 Thread GitBox
tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-864953216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [hbase] GeorryHuang commented on a change in pull request #3373: HBASE-25980 Master table.jsp pointed at meta throws 500 when no all r…

2021-06-22 Thread GitBox
GeorryHuang commented on a change in pull request #3373: URL: https://github.com/apache/hbase/pull/3373#discussion_r655369081 ## File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp ## @@ -268,7 +269,12 @@ for (int j = 0; j <

[GitHub] [hbase] Apache9 commented on pull request #3396: HBASE-26010 Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-22 Thread GitBox
Apache9 commented on pull request #3396: URL: https://github.com/apache/hbase/pull/3396#issuecomment-865016704 Ping @ndimiduk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] brfrn169 commented on pull request #3395: HBASE-26009 Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-22 Thread GitBox
brfrn169 commented on pull request #3395: URL: https://github.com/apache/hbase/pull/3395#issuecomment-865434495 This may be a new feature but it doesn't break any compatibilities. So I thought we could put it into the next 2.3.x release. What do you guys think? Thanks. -- This is an

[GitHub] [hbase] petersomogyi commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
petersomogyi commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r651901792 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -266,6 +266,7 @@ public

[GitHub] [hbase] virajjasani commented on pull request #3407: HBASE-26018. Perf improvement in L1 cache

2021-06-22 Thread GitBox
virajjasani commented on pull request #3407: URL: https://github.com/apache/hbase/pull/3407#issuecomment-864949628 FYI @ben-manes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache-HBase commented on pull request #3410: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3410: URL: https://github.com/apache/hbase/pull/3410#issuecomment-865695601 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3409: HBASE-26020 Split TestWALEntryStream.testDifferentCounts out

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3409: URL: https://github.com/apache/hbase/pull/3409#issuecomment-865666853 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on a change in pull request #3397: HBASE-26012 Improve logging and dequeue logic in DelayQueue

2021-06-22 Thread GitBox
virajjasani commented on a change in pull request #3397: URL: https://github.com/apache/hbase/pull/3397#discussion_r655538100 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/util/DelayedUtil.java ## @@ -79,7 +84,13 @@ public String toString() {

[GitHub] [hbase] mnpoonia edited a comment on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-22 Thread GitBox
mnpoonia edited a comment on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-864997682 > I think rather than site config, having a switch command would be more beneficial. > Something like `switch_cluster_normalizer /` would not require us to re-deploy

[GitHub] [hbase] ndimiduk commented on a change in pull request #3396: HBASE-26010 Backport HBASE-25703 and HBASE-26002 to branch-2.3

2021-06-22 Thread GitBox
ndimiduk commented on a change in pull request #3396: URL: https://github.com/apache/hbase/pull/3396#discussion_r655805429 ## File path: hbase-protocol/src/main/protobuf/MultiRowMutation.proto ## @@ -37,9 +37,11 @@ message MutateRowsRequest { optional uint64 nonce_group =

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-06-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367088#comment-17367088 ] Viraj Jasani commented on HBASE-25902: -- [~stack] Curious if you have encountered HBASE-26021 issue

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655650248 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -266,6 +266,7 @@ public InternalScanner

[GitHub] [hbase] petersomogyi commented on pull request #2114: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2021-06-22 Thread GitBox
petersomogyi commented on pull request #2114: URL: https://github.com/apache/hbase/pull/2114#issuecomment-865087242 I've made some testing recently using this patch to be able to start an HBase cluster on a pre-existing HBase root directory. Currently I have to use `HBCK2 recoverUnknown`

[GitHub] [hbase] mnpoonia commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-06-22 Thread GitBox
mnpoonia commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-864997682 > I think rather than site config, having a switch command would be more beneficial. > Something like `switch_cluster_normalizer /` would not require us to re-deploy with

[GitHub] [hbase] ndimiduk commented on pull request #3395: HBASE-26009 Backport HBASE-25766 "Introduce RegionSplitRestriction that restricts the pattern of the split point" to branch-2.3

2021-06-22 Thread GitBox
ndimiduk commented on pull request #3395: URL: https://github.com/apache/hbase/pull/3395#issuecomment-865443807 I personally think this cannot be applied to any patch release. It introduces a new table configuration, which may cause problems during a rollback. What are the "Server-Server"

[GitHub] [hbase] z-york commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
z-york commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r655784451 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectInStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + * Licensed

[GitHub] [hbase] joshelser commented on pull request #2114: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2021-06-22 Thread GitBox
joshelser commented on pull request #2114: URL: https://github.com/apache/hbase/pull/2114#issuecomment-865145985 > I'm suggesting to hide this behind a feature flag Makes sense to me. I think that addresses some of the other concerns from @Apache9 (mentioning him to make sure that's

[GitHub] [hbase] YutSean opened a new pull request #3411: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread GitBox
YutSean opened a new pull request #3411: URL: https://github.com/apache/hbase/pull/3411 https://issues.apache.org/jira/browse/HBASE-26013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] Reidddddd merged pull request #3410: HBASE-26013 Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread GitBox
Reidd merged pull request #3410: URL: https://github.com/apache/hbase/pull/3410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] zhengzhuobinzzb opened a new pull request #3412: HBASE-26022. DNS jitter causes hbase client to get stuck

2021-06-22 Thread GitBox
zhengzhuobinzzb opened a new pull request #3412: URL: https://github.com/apache/hbase/pull/3412 Signed-off-by: Zhuobin Zheng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656045500 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectInStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #3409: HBASE-26020 Split TestWALEntryStream.testDifferentCounts out

2021-06-22 Thread GitBox
Apache-HBase commented on pull request #3409: URL: https://github.com/apache/hbase/pull/3409#issuecomment-865855187 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-22 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367200#comment-17367200 ] Anoop Sam John commented on HBASE-26021: Oh.. I was about to ask that Q next.. That means if u

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue

2021-06-22 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367202#comment-17367202 ] Viraj Jasani commented on HBASE-26021: -- Hmm that might be a possibility. Might have to figure out

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656098099 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectInStoreCompactor.java ## @@ -0,0 +1,90 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656100941 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectInStoreFlushContext.java ## @@ -33,11 +33,11 @@ * To be used only

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656009419 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectInStoreFlushContext.java ## @@ -33,11 +33,11 @@ * To be used only

[jira] [Comment Edited] (HBASE-20503) [AsyncFSWAL] Failed to get sync result after 300000 ms for txid=160912, WAL system stuck?

2021-06-22 Thread Emil Kleszcz (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365637#comment-17365637 ] Emil Kleszcz edited comment on HBASE-20503 at 6/22/21, 11:11 AM: - Hi, we

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-22 Thread GitBox
wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r656009419 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectInStoreFlushContext.java ## @@ -33,11 +33,11 @@ * To be used only

  1   2   >