[GitHub] saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-10-31 Thread GitBox
saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r229864093 ## File path: kafka/hbase-kafka-proxy/pom.xml ## @@ -76,43 +77,40 @@

[GitHub] saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-10-31 Thread GitBox
saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r229864154 ## File path: kafka/README ## @@ -0,0 +1,126 @@ +Hbase Kafka Proxy Review comment: Duh

[GitHub] saintstack closed pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-10-31 Thread GitBox
saintstack closed pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] saintstack commented on issue #3: HBASE-21002 make an assembly for hbase-connectors

2018-10-31 Thread GitBox
saintstack commented on issue #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#issuecomment-434862866 I applied the patch and was able to start up the proxy. I did not test if it worked replicating out to kafka. I figure

[GitHub] hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-10-31 Thread GitBox
hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r229867217 ## File path: kafka/hbase-kafka-proxy/pom.xml ## @@ -76,43 +77,40 @@

[GitHub] saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-10-31 Thread GitBox
saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r229882057 ## File path: kafka/hbase-kafka-proxy/pom.xml ## @@ -76,43 +77,40 @@

[GitHub] saintstack opened a new pull request #4: HBASE-21430 [hbase-connectors] Move hbase-spark* modules to hbase-connectors repo

2018-11-02 Thread GitBox
saintstack opened a new pull request #4: HBASE-21430 [hbase-connectors] Move hbase-spark* modules to hbase-connectors repo URL: https://github.com/apache/hbase-connectors/pull/4 Move over the hbase-spark* modules. TODO: profiles for hadoop2 and hadoop3. TODO: tests don't pass

[GitHub] petersomogyi opened a new pull request #5: HBASE-21431 Fix build and test issues

2018-11-04 Thread GitBox
petersomogyi opened a new pull request #5: HBASE-21431 Fix build and test issues URL: https://github.com/apache/hbase-connectors/pull/5 merge conflict in hbase-spark pom.xml can't resolve org.apache.directory.jdbm:apacheds-jdbm1 dependency (pulled in via org.apache.hadoop:hadoop-minikdc

[GitHub] saintstack opened a new pull request #8: HBASE-21430 [hbase-connectors] Move hbase-spark* modules to hbase-con…

2018-11-06 Thread GitBox
saintstack opened a new pull request #8: HBASE-21430 [hbase-connectors] Move hbase-spark* modules to hbase-con… URL: https://github.com/apache/hbase-connectors/pull/8 …nectors repo Tests pass. Cleaned up dependencies. Learned that mvn dependency:analyze is unreliable.

[GitHub] saintstack opened a new pull request #10: HBASE-21448 [hbase-connectors] Make compile/tests pass on scala 2.10 …

2018-11-07 Thread GitBox
saintstack opened a new pull request #10: HBASE-21448 [hbase-connectors] Make compile/tests pass on scala 2.10 … URL: https://github.com/apache/hbase-connectors/pull/10 …AND 2.11 This is an automated message from the Apache

[GitHub] saintstack closed pull request #10: HBASE-21448 [hbase-connectors] Make compile/tests pass on scala 2.10 …

2018-11-07 Thread GitBox
saintstack closed pull request #10: HBASE-21448 [hbase-connectors] Make compile/tests pass on scala 2.10 … URL: https://github.com/apache/hbase-connectors/pull/10 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] busbey opened a new pull request #1: Clean up for hbck2 now that 2.1.1 is out

2018-11-15 Thread GitBox
busbey opened a new pull request #1: Clean up for hbck2 now that 2.1.1 is out URL: https://github.com/apache/hbase-operator-tools/pull/1 * clean up the version checking so that folks can provide a patched version of 2.1.0 if needed * rely on a released version so that builds from clean

[GitHub] Reidddddd commented on issue #1: Clean up for hbck2 now that 2.1.1 is out

2018-11-15 Thread GitBox
Reidd commented on issue #1: Clean up for hbck2 now that 2.1.1 is out URL: https://github.com/apache/hbase-operator-tools/pull/1#issuecomment-439295927 LGTM May i ask how to run QA or BOT? Expecting UTs result.

[GitHub] busbey commented on issue #1: Clean up for hbck2 now that 2.1.1 is out

2018-11-16 Thread GitBox
busbey commented on issue #1: Clean up for hbck2 now that 2.1.1 is out URL: https://github.com/apache/hbase-operator-tools/pull/1#issuecomment-439373422 thanks for the review! for now folks have to run the UTs locally. getting qa integration for these new repos is still an open

[GitHub] busbey closed pull request #1: Clean up for hbck2 now that 2.1.1 is out

2018-11-16 Thread GitBox
busbey closed pull request #1: Clean up for hbck2 now that 2.1.1 is out URL: https://github.com/apache/hbase-operator-tools/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] saintstack closed pull request #9: HBASE-21446 [hbase-connectors] Update spark and scala versions;

2018-11-06 Thread GitBox
saintstack closed pull request #9: HBASE-21446 [hbase-connectors] Update spark and scala versions; URL: https://github.com/apache/hbase-connectors/pull/9 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] saintstack opened a new pull request #9: HBASE-21446 [hbase-connectors] Update spark and scala versions;

2018-11-06 Thread GitBox
saintstack opened a new pull request #9: HBASE-21446 [hbase-connectors] Update spark and scala versions; URL: https://github.com/apache/hbase-connectors/pull/9 add some doc on how to generate artifacts with different versions

[GitHub] saintstack commented on issue #5: HBASE-21431 Fix build and test issues

2018-11-04 Thread GitBox
saintstack commented on issue #5: HBASE-21431 Fix build and test issues URL: https://github.com/apache/hbase-connectors/pull/5#issuecomment-435701922 Sorry about that. I have a patch to fix. Didn't think anyone else was looking at this. Let me merge this in though and then take it from

[GitHub] saintstack closed pull request #5: HBASE-21431 Fix build and test issues

2018-11-04 Thread GitBox
saintstack closed pull request #5: HBASE-21431 Fix build and test issues URL: https://github.com/apache/hbase-connectors/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] saintstack opened a new pull request #6: HBASE-21434 [hbase-connectors] Cleanup of kafka dependencies; clarify…

2018-11-04 Thread GitBox
saintstack opened a new pull request #6: HBASE-21434 [hbase-connectors] Cleanup of kafka dependencies; clarify… URL: https://github.com/apache/hbase-connectors/pull/6 … hadoop version This is an automated message from the

[GitHub] saintstack closed pull request #6: HBASE-21434 [hbase-connectors] Cleanup of kafka dependencies; clarify…

2018-11-04 Thread GitBox
saintstack closed pull request #6: HBASE-21434 [hbase-connectors] Cleanup of kafka dependencies; clarify… URL: https://github.com/apache/hbase-connectors/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] saintstack opened a new pull request #7: HBASE-21435 [hbase-connectors] Cleanup of kafka dependencies; clarify…

2018-11-04 Thread GitBox
saintstack opened a new pull request #7: HBASE-21435 [hbase-connectors] Cleanup of kafka dependencies; clarify… URL: https://github.com/apache/hbase-connectors/pull/7 … hadoop version; addendum This is an automated message

[GitHub] saintstack closed pull request #7: HBASE-21435 [hbase-connectors] Cleanup of kafka dependencies; clarify…

2018-11-04 Thread GitBox
saintstack closed pull request #7: HBASE-21435 [hbase-connectors] Cleanup of kafka dependencies; clarify… URL: https://github.com/apache/hbase-connectors/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-19 Thread GitBox
hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218809228 ## File path: kafka/hbase-kafka-proxy/pom.xml ## @@ -76,43 +77,40 @@

[GitHub] hbasejanitor commented on issue #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-19 Thread GitBox
hbasejanitor commented on issue #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#issuecomment-422848121 I think the exception was a classpath issue. I've trimmed down the dependencies.

[GitHub] hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-19 Thread GitBox
hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218810828 ## File path: kafka/README ## @@ -0,0 +1,126 @@ +Hbase Kafka Proxy Review comment:

[GitHub] hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-19 Thread GitBox
hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218788287 ## File path: kafka/hbase-kafka-proxy/src/main/java/org/apache/hadoop/hbase/kafka/KafkaProxy.java

[GitHub] busbey commented on issue #1: Clean up for hbck2 now that 2.1.1 is out

2018-11-16 Thread GitBox
busbey commented on issue #1: Clean up for hbck2 now that 2.1.1 is out URL: https://github.com/apache/hbase-operator-tools/pull/1#issuecomment-439442949 There were two associated JIRA. They're referenced in the commit messages.

[GitHub] saintstack opened a new pull request #11: HBASE-21491 [hbase-connectors] Edit on spark connector README

2018-11-16 Thread GitBox
saintstack opened a new pull request #11: HBASE-21491 [hbase-connectors] Edit on spark connector README URL: https://github.com/apache/hbase-connectors/pull/11 Trivial change just to see if any difference made by INFRA-17217

[GitHub] saintstack closed pull request #11: HBASE-21491 [hbase-connectors] Edit on spark connector README

2018-11-16 Thread GitBox
saintstack closed pull request #11: HBASE-21491 [hbase-connectors] Edit on spark connector README URL: https://github.com/apache/hbase-connectors/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] saintstack commented on issue #1: Clean up for hbck2 now that 2.1.1 is out

2018-11-16 Thread GitBox
saintstack commented on issue #1: Clean up for hbck2 now that 2.1.1 is out URL: https://github.com/apache/hbase-operator-tools/pull/1#issuecomment-439437881 Writing a glowing review here to see effect of INFRA changes to our github/JIRA channel.

[GitHub] saintstack commented on issue #1: Clean up for hbck2 now that 2.1.1 is out

2018-11-16 Thread GitBox
saintstack commented on issue #1: Clean up for hbck2 now that 2.1.1 is out URL: https://github.com/apache/hbase-operator-tools/pull/1#issuecomment-439438360 Hmm.. So this is pure PR. No associated JIRA. This is an automated

[GitHub] saintstack commented on issue #1: Clean up for hbck2 now that 2.1.1 is out

2018-11-16 Thread GitBox
saintstack commented on issue #1: Clean up for hbck2 now that 2.1.1 is out URL: https://github.com/apache/hbase-operator-tools/pull/1#issuecomment-439453798 Thanks for fixing my dumb check. Was trying to see if INFRA-17217 has been done. Will file new noop issue to see whats

[GitHub] saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-18 Thread GitBox
saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218127341 ## File path: kafka/hbase-kafka-proxy/pom.xml ## @@ -76,43 +77,40 @@

[GitHub] saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-18 Thread GitBox
saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218127793 ## File path: kafka/hbase-kafka-proxy/src/main/java/org/apache/hadoop/hbase/kafka/KafkaProxy.java

[GitHub] saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-18 Thread GitBox
saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218131154 ## File path: pom.xml ## @@ -167,21 +170,34 @@ hbase-client

[GitHub] saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-18 Thread GitBox
saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218108464 ## File path: kafka/README ## @@ -0,0 +1,126 @@ +Hbase Kafka Proxy Review comment:

[GitHub] saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-18 Thread GitBox
saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218126550 ## File path: kafka/README ## @@ -0,0 +1,126 @@ +Hbase Kafka Proxy + +Welcome to the hbase

[GitHub] hbasejanitor opened a new pull request #2: HBASE-29034 make an assembly for hbase-connectors

2018-09-17 Thread GitBox
hbasejanitor opened a new pull request #2: HBASE-29034 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/2 Implement assembly, some code tweaks to work with hbase 2.X, README to explain usage.

[GitHub] hbasejanitor closed pull request #2: HBASE-29034 make an assembly for hbase-connectors

2018-09-17 Thread GitBox
hbasejanitor closed pull request #2: HBASE-29034 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] hbasejanitor opened a new pull request #3: HBASE-21002 make an assembly for hbase-connectors

2018-09-17 Thread GitBox
hbasejanitor opened a new pull request #3: HBASE-21002 make an assembly for hbase-connectors URL: https://github.com/apache/hbase-connectors/pull/3 README for usage, assembly, some tweaks to get it working with Hbase 2.X.

[GitHub] [hbase] Apache9 opened a new pull request #110: For testing github PR

2019-04-03 Thread GitBox
Apache9 opened a new pull request #110: For testing github PR URL: https://github.com/apache/hbase/pull/110 Check whether we could trigger a yetus build This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] hadoop-yetus commented on issue #110: For testing github PR

2019-04-03 Thread GitBox
hadoop-yetus commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479754495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec |

[GitHub] [hbase] maoling commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
maoling commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479840393 awesome work! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache9 commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
Apache9 commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479888338 @busbey You can see the config of this job https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/ On the Credentials, you can select the hadoop-yetus.

[GitHub] [hbase] busbey commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
busbey commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479857296 We need our own commenting account. We shouldn't be using Hadoop's. I'm a bit surprised we were able to.

[GitHub] [hbase] hadoop-yetus commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
hadoop-yetus commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479860479 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec |

[GitHub] [hbase] busbey commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
busbey commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479894587 IIRC Steve L over in Hadoop set things up. Essentially he made the GitHub account and made sure the Hadoop pmc had control of it. I'm not sure if getting the

[GitHub] [hbase] Apache9 commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
Apache9 commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479897195 The token can be added by ourselves I believe, there is an 'Add' button after the Credentials config. And hadoop-yetus account is a member of the Apache on

[GitHub] [hbase] joshelser commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
joshelser commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479910598 > We need an email address when creating a github account, so just the private@hbase? That'd be my suggestion.

[GitHub] [hbase] Apache9 commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
Apache9 commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479914234 > If I'm correct the hadoop-yetus email address was created for this and made it private. We could do the same and request an hbase-yetus list for this purpose.

[GitHub] [hbase] Apache9 commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
Apache9 commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479914026 And another thing is that, seems the hadoop-yetus can only comment on this PR but for the PRs of hadoop, the hadoop-yetus can start a review. Maybe this also means

[GitHub] [hbase] Apache9 commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
Apache9 commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479903086 Oh, it is just the company field of the github profile, not the Organizations... OK, the only problem is that how do we share the github account across the

[GitHub] [hbase] joshelser commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
joshelser commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479904928 > OK, the only problem is that how do we share the github account across the PMC members... Maybe just a randomly generated password sent to private@hbase

[GitHub] [hbase] busbey commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
busbey commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479920380 we could use private@hbase. I believe the apache-yetus account uses private@yetus. If I had to guess, I'd say making a new email list as hadoop-yetus did would

[GitHub] [hbase] Apache9 commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
Apache9 commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479910021 @joshelser We need an email address when creating a github account, so just the private@hbase? It seems that we also have an apache-yetus account, so how do

[GitHub] [hbase] Apache9 commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
Apache9 commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479923647 Oh, I deleted the HBASE-22147 branch after committing HBASE-22152... Let continue the discussion on HBASE-22147.

[GitHub] [hbase] petersomogyi commented on issue #110: For testing github PR

2019-04-04 Thread GitBox
petersomogyi commented on issue #110: For testing github PR URL: https://github.com/apache/hbase/pull/110#issuecomment-479911199 If I'm correct the hadoop-yetus email address was created for this and made it private. We could do the same and request an hbase-yetus list for this purpose.

[GitHub] [hbase] asfgit closed pull request #110: For testing github PR

2019-04-04 Thread GitBox
asfgit closed pull request #110: For testing github PR URL: https://github.com/apache/hbase/pull/110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] hadoop-yetus commented on issue #109: a bug of checking if restoreDir is subDir of rootDir

2019-04-05 Thread GitBox
hadoop-yetus commented on issue #109: a bug of checking if restoreDir is subDir of rootDir URL: https://github.com/apache/hbase/pull/109#issuecomment-480237093 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] openinx commented on issue #112: HBASE-22152 Addendum use hbase account instead of hadoop

2019-04-05 Thread GitBox
openinx commented on issue #112: HBASE-22152 Addendum use hbase account instead of hadoop URL: https://github.com/apache/hbase/pull/112#issuecomment-480265869 LGTM This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache9 opened a new pull request #112: HBASE-22152 Addendum use hbase account instead of hadoop

2019-04-05 Thread GitBox
Apache9 opened a new pull request #112: HBASE-22152 Addendum use hbase account instead of hadoop URL: https://github.com/apache/hbase/pull/112 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] openinx merged pull request #112: HBASE-22152 Addendum use hbase account instead of hadoop

2019-04-05 Thread GitBox
openinx merged pull request #112: HBASE-22152 Addendum use hbase account instead of hadoop URL: https://github.com/apache/hbase/pull/112 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] hadoop-yetus commented on issue #111: HBASE-22170 Add an import order template under the dev-support directory

2019-04-05 Thread GitBox
hadoop-yetus commented on issue #111: HBASE-22170 Add an import order template under the dev-support directory URL: https://github.com/apache/hbase/pull/111#issuecomment-480202970 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache9 opened a new pull request #111: HBASE-22170 Add an import order template under the dev-support directory

2019-04-05 Thread GitBox
Apache9 opened a new pull request #111: HBASE-22170 Add an import order template under the dev-support directory URL: https://github.com/apache/hbase/pull/111 This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on issue #112: HBASE-22152 Addendum use hbase account instead of hadoop

2019-04-05 Thread GitBox
Apache-HBase commented on issue #112: HBASE-22152 Addendum use hbase account instead of hadoop URL: https://github.com/apache/hbase/pull/112#issuecomment-480232158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #111: HBASE-22170 Add an import order template under the dev-support directory

2019-04-05 Thread GitBox
Apache-HBase commented on issue #111: HBASE-22170 Add an import order template under the dev-support directory URL: https://github.com/apache/hbase/pull/111#issuecomment-480296694 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache9 closed pull request #111: HBASE-22170 Add an import order template under the dev-support directory

2019-04-05 Thread GitBox
Apache9 closed pull request #111: HBASE-22170 Add an import order template under the dev-support directory URL: https://github.com/apache/hbase/pull/111 This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] Apache9 commented on issue #111: HBASE-22170 Add an import order template under the dev-support directory

2019-04-05 Thread GitBox
Apache9 commented on issue #111: HBASE-22170 Add an import order template under the dev-support directory URL: https://github.com/apache/hbase/pull/111#issuecomment-480453752 Duplicate with HBASE-20912. This is an automated

[GitHub] [hbase] Apache9 opened a new pull request #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-05 Thread GitBox
Apache9 opened a new pull request #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113 The output of the error prone check is not stable, sometimes we miss several warnings, and sometimes the order of the warnings are changed.

[GitHub] [hbase] Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]

2019-04-05 Thread GitBox
Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480455829 Hey @gangxueZhang the GitHub integration for HBase has been set up, could you please update the PR since there are conflicts?

[GitHub] [hbase] busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-05 Thread GitBox
busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480464387 could we make this a CLI flag and turn it on during nightly runs? nightly doesn't do a before/after so the stability shouldn't

[GitHub] [hbase] Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-05 Thread GitBox
Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480464535 Nightly will also use the hbase-personality script? Do not know that before... Then the fix will be a bit different.

[GitHub] [hbase] Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]

2019-04-05 Thread GitBox
Apache-HBase commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480473410 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-05 Thread GitBox
busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480474364 yeah, nightly runs up to 3 of 4 potential different yetus invocations and all of them use the personality.

[GitHub] [hbase] Apache-HBase commented on issue #114: for testing whether we skip the error prone check

2019-04-06 Thread GitBox
Apache-HBase commented on issue #114: for testing whether we skip the error prone check URL: https://github.com/apache/hbase/pull/114#issuecomment-480479908 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-05 Thread GitBox
Apache-HBase commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480464960 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-05 Thread GitBox
Apache-HBase commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480477010 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache9 opened a new pull request #114: for testing whether we skip the error prone check

2019-04-06 Thread GitBox
Apache9 opened a new pull request #114: for testing whether we skip the error prone check URL: https://github.com/apache/hbase/pull/114 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] hadoop-yetus commented on issue #115: test merge

2019-04-06 Thread GitBox
hadoop-yetus commented on issue #115: test merge URL: https://github.com/apache/hbase/pull/115#issuecomment-480521154 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 268 | Docker

[GitHub] [hbase] Apache9 closed pull request #114: for testing whether we skip the error prone check

2019-04-06 Thread GitBox
Apache9 closed pull request #114: for testing whether we skip the error prone check URL: https://github.com/apache/hbase/pull/114 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache9 commented on issue #114: for testing whether we skip the error prone check

2019-04-06 Thread GitBox
Apache9 commented on issue #114: for testing whether we skip the error prone check URL: https://github.com/apache/hbase/pull/114#issuecomment-480494900 Seems worked. There is no '-PerrorProne'

[GitHub] [hbase] Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-06 Thread GitBox
Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480495438 Oh a bit strange, the merge operation will generate a merge commit...

[GitHub] [hbase] Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-06 Thread GitBox
Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480504849 Yes, the default action is create a merge commit... I just clicked the button and then clicked confirm merge...

[GitHub] [hbase] petersomogyi commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-06 Thread GitBox
petersomogyi commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480505793 If I remember correctly on hbase-connectors after I submitted a PR with "Squash and merge" the next time that became the

[GitHub] [hbase] Apache9 merged pull request #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-06 Thread GitBox
Apache9 merged pull request #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache9 closed pull request #115: test merge

2019-04-06 Thread GitBox
Apache9 closed pull request #115: test merge URL: https://github.com/apache/hbase/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-06 Thread GitBox
busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480504730 Looks like we'll need to ask infra to change it; I don't see repo settings.

[GitHub] [hbase] Apache9 opened a new pull request #115: test merge

2019-04-06 Thread GitBox
Apache9 opened a new pull request #115: test merge URL: https://github.com/apache/hbase/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]

2019-04-06 Thread GitBox
Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480498626 @gangxueZhang Please combine your commits into one commit? Thanks. This

[GitHub] [hbase] busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check

2019-04-06 Thread GitBox
busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480504547 There's a different option when accepting a PR that avoids the merge commit. I guess we didn't make it the default for the

[GitHub] [hbase] Apache9 opened a new pull request #116: HBASE-22177 Do not recreate IOException in RawAsyncHBaseAdmin.adminCall

2019-04-06 Thread GitBox
Apache9 opened a new pull request #116: HBASE-22177 Do not recreate IOException in RawAsyncHBaseAdmin.adminCall URL: https://github.com/apache/hbase/pull/116 This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache9 opened a new pull request #118: HBASE-22179 Fix RawAsyncHBaseAdmin.getCompactionState

2019-04-06 Thread GitBox
Apache9 opened a new pull request #118: HBASE-22179 Fix RawAsyncHBaseAdmin.getCompactionState URL: https://github.com/apache/hbase/pull/118 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] petersomogyi commented on issue #109: a bug of checking if restoreDir is subDir of rootDir

2019-04-06 Thread GitBox
petersomogyi commented on issue #109: a bug of checking if restoreDir is subDir of rootDir URL: https://github.com/apache/hbase/pull/109#issuecomment-480508548 Merged patch from Jira. This is an automated message from the

[GitHub] [hbase] petersomogyi closed pull request #109: a bug of checking if restoreDir is subDir of rootDir

2019-04-06 Thread GitBox
petersomogyi closed pull request #109: a bug of checking if restoreDir is subDir of rootDir URL: https://github.com/apache/hbase/pull/109 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on issue #116: HBASE-22177 Do not recreate IOException in RawAsyncHBaseAdmin.adminCall

2019-04-06 Thread GitBox
Apache-HBase commented on issue #116: HBASE-22177 Do not recreate IOException in RawAsyncHBaseAdmin.adminCall URL: https://github.com/apache/hbase/pull/116#issuecomment-480510674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache9 opened a new pull request #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method …

2019-04-06 Thread GitBox
Apache9 opened a new pull request #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method … URL: https://github.com/apache/hbase/pull/117 …in Admin This is an automated message from the Apache Git Service.

[GitHub] [hbase] Apache9 opened a new pull request #119: HBASE-22180 Make TestBlockEvictionFromClient.testBlockRefCountAfterSp…

2019-04-06 Thread GitBox
Apache9 opened a new pull request #119: HBASE-22180 Make TestBlockEvictionFromClient.testBlockRefCountAfterSp… URL: https://github.com/apache/hbase/pull/119 …lits more stable This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on issue #118: HBASE-22179 Fix RawAsyncHBaseAdmin.getCompactionState

2019-04-06 Thread GitBox
Apache-HBase commented on issue #118: HBASE-22179 Fix RawAsyncHBaseAdmin.getCompactionState URL: https://github.com/apache/hbase/pull/118#issuecomment-480510428 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method …

2019-04-06 Thread GitBox
Apache-HBase commented on issue #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method … URL: https://github.com/apache/hbase/pull/117#issuecomment-480511228 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

  1   2   3   4   5   6   7   8   9   10   >