[jira] [Created] (HBASE-11317) Mockito section of HBase Book missing examples

2014-06-10 Thread Mike Drob (JIRA)
Mike Drob created HBASE-11317: - Summary: Mockito section of HBase Book missing examples Key: HBASE-11317 URL: https://issues.apache.org/jira/browse/HBASE-11317 Project: HBase Issue Type: Task

[jira] [Updated] (HBASE-11413) [findbugs] RV: Negating the result of compareTo()/compare()

2014-06-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11413: -- Attachment: HBASE-11413.patch [findbugs] RV: Negating the result of compareTo()/compare()

[jira] [Created] (HBASE-11413) [findbugs] RV: Negating the result of compareTo()/compare()

2014-06-25 Thread Mike Drob (JIRA)
Mike Drob created HBASE-11413: - Summary: [findbugs] RV: Negating the result of compareTo()/compare() Key: HBASE-11413 URL: https://issues.apache.org/jira/browse/HBASE-11413 Project: HBase Issue

[jira] [Updated] (HBASE-11413) [findbugs] RV: Negating the result of compareTo()/compare()

2014-06-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11413: -- Status: Patch Available (was: Open) Patch attached for trunk/master. [findbugs] RV: Negating the

[jira] [Updated] (HBASE-11413) [findbugs] RV: Negating the result of compareTo()/compare()

2014-06-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11413: -- Priority: Trivial (was: Major) [findbugs] RV: Negating the result of compareTo()/compare()

[jira] [Updated] (HBASE-11413) [findbugs] RV: Negating the result of compareTo()/compare()

2014-06-27 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11413: -- Status: Patch Available (was: Open) [findbugs] RV: Negating the result of compareTo()/compare()

[jira] [Updated] (HBASE-11413) [findbugs] RV: Negating the result of compareTo()/compare()

2014-06-27 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11413: -- Status: Open (was: Patch Available) [findbugs] RV: Negating the result of compareTo()/compare()

[jira] [Updated] (HBASE-11413) [findbugs] RV: Negating the result of compareTo()/compare()

2014-07-01 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11413: -- Status: Open (was: Patch Available) [findbugs] RV: Negating the result of compareTo()/compare()

[jira] [Updated] (HBASE-11413) [findbugs] RV: Negating the result of compareTo()/compare()

2014-07-01 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11413: -- Status: Patch Available (was: Open) Resubmitting for QA Bot [findbugs] RV: Negating the result of

[jira] [Created] (HBASE-11463) (findbugs) HE: Class defines equals() and uses Object.hashCode()

2014-07-03 Thread Mike Drob (JIRA)
Mike Drob created HBASE-11463: - Summary: (findbugs) HE: Class defines equals() and uses Object.hashCode() Key: HBASE-11463 URL: https://issues.apache.org/jira/browse/HBASE-11463 Project: HBase

[jira] [Updated] (HBASE-11463) (findbugs) HE: Class defines equals() and uses Object.hashCode()

2014-07-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11463: -- Attachment: HBASE-11463.patch.txt Patch attached that implements several {{hashCode()}} methods to be

[jira] [Updated] (HBASE-11463) (findbugs) HE: Class defines equals() and uses Object.hashCode()

2014-07-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11463: -- Status: Patch Available (was: Open) (findbugs) HE: Class defines equals() and uses

[jira] [Commented] (HBASE-11463) (findbugs) HE: Class defines equals() and uses Object.hashCode()

2014-07-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051936#comment-14051936 ] Mike Drob commented on HBASE-11463: --- Well, in an ideal world, we could wire up

[jira] [Updated] (HBASE-11463) (findbugs) HE: Class defines equals() and uses Object.hashCode()

2014-07-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11463: -- Attachment: HBASE-11463.v2.patch.txt Attaching patch with expanded testing. (findbugs) HE: Class

[jira] [Commented] (HBASE-11463) (findbugs) HE: Class defines equals() and uses Object.hashCode()

2014-07-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053611#comment-14053611 ] Mike Drob commented on HBASE-11463: --- Ah, missed that because everything ran fine in my

[jira] [Commented] (HBASE-11317) Expand unit testing to cover Mockito and MRUnit and give more examples

2014-07-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053654#comment-14053654 ] Mike Drob commented on HBASE-11317: --- Very helpful, thanks! Expand unit testing to

[jira] [Created] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop

2014-07-10 Thread Mike Drob (JIRA)
Mike Drob created HBASE-11499: - Summary: AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop Key: HBASE-11499 URL: https://issues.apache.org/jira/browse/HBASE-11499 Project:

[jira] [Updated] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop

2014-07-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11499: -- Attachment: HBASE-11499.patch.txt AsyncProcess.buildDetailedErrorMessage concatenates strings using

[jira] [Updated] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop

2014-07-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11499: -- Labels: findbugs (was: ) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a

[jira] [Updated] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop

2014-07-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11499: -- Status: Patch Available (was: Open) AsyncProcess.buildDetailedErrorMessage concatenates strings

[jira] [Created] (HBASE-11500) Possible null pointer dereference of regionLocation in ReversedScannerCallable

2014-07-10 Thread Mike Drob (JIRA)
Mike Drob created HBASE-11500: - Summary: Possible null pointer dereference of regionLocation in ReversedScannerCallable Key: HBASE-11500 URL: https://issues.apache.org/jira/browse/HBASE-11500 Project:

[jira] [Updated] (HBASE-11500) Possible null pointer dereference of regionLocation in ReversedScannerCallable

2014-07-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11500: -- Labels: findbugs (was: ) Status: Patch Available (was: Open) Possible null pointer dereference

[jira] [Updated] (HBASE-11500) Possible null pointer dereference of regionLocation in ReversedScannerCallable

2014-07-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11500: -- Attachment: HBASE-11500.patch.txt Possible null pointer dereference of regionLocation in

[jira] [Commented] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop

2014-07-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057983#comment-14057983 ] Mike Drob commented on HBASE-11499: --- It looks like HadoopQA is applying the patches

[jira] [Updated] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop

2014-07-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11499: -- Status: Patch Available (was: Open) AsyncProcess.buildDetailedErrorMessage concatenates strings

[jira] [Updated] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop

2014-07-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11499: -- Attachment: HBASE-11499.v2.patch.txt Attaching a patch created with {{git --format-patch}} that can

[jira] [Updated] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop

2014-07-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11499: -- Status: Open (was: Patch Available) AsyncProcess.buildDetailedErrorMessage concatenates strings

[jira] [Commented] (HBASE-4593) Design and document the official procedure for posting patches, commits, commit messages, etc. to smooth process and make integration with tools easier

2014-07-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063440#comment-14063440 ] Mike Drob commented on HBASE-4593: -- bq. Save your changes to a patch: git diff

[jira] [Created] (HBASE-11537) Avoid synchronization on instances of ConcurrentMap

2014-07-17 Thread Mike Drob (JIRA)
Mike Drob created HBASE-11537: - Summary: Avoid synchronization on instances of ConcurrentMap Key: HBASE-11537 URL: https://issues.apache.org/jira/browse/HBASE-11537 Project: HBase Issue Type:

[jira] [Updated] (HBASE-11537) Avoid synchronization on instances of ConcurrentMap

2014-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11537: -- Attachment: HBASE-11537.patch.txt This patch swaps out the use of synchronization on a

[jira] [Updated] (HBASE-11537) Avoid synchronization on instances of ConcurrentMap

2014-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-11537: -- Status: Patch Available (was: Open) Avoid synchronization on instances of ConcurrentMap

[jira] [Commented] (HBASE-7910) Dont use reflection for security

2014-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066025#comment-14066025 ] Mike Drob commented on HBASE-7910: -- [~enis] - do you mind if I try and take this one on?

[jira] [Commented] (HBASE-11537) Avoid synchronization on instances of ConcurrentMap

2014-07-18 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067201#comment-14067201 ] Mike Drob commented on HBASE-11537: --- [~jmhsieh] - Thanks for looking. I agree that the

[jira] [Commented] (HBASE-11537) Avoid synchronization on instances of ConcurrentMap

2014-07-18 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067205#comment-14067205 ] Mike Drob commented on HBASE-11537: --- [~apurtell] - LGTM. Avoid synchronization on

[jira] [Updated] (HBASE-7910) Dont use reflection for security

2014-07-18 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-7910: - Attachment: HBASE-7910.patch.txt I wasn't able to remove the reflective calls for

[jira] [Updated] (HBASE-7910) Dont use reflection for security

2014-07-18 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-7910: - Status: Patch Available (was: Open) Dont use reflection for security

[jira] [Commented] (HBASE-11605) All classes that override equals should have a corresponding hashCode

2014-07-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077116#comment-14077116 ] Mike Drob commented on HBASE-11605: --- I think this was fixed in later versions with

[jira] [Created] (HBASE-11615) TestZKLessAMOnCluster.testForceAssignWhileClosing failed on Jenkins

2014-07-30 Thread Mike Drob (JIRA)
Mike Drob created HBASE-11615: - Summary: TestZKLessAMOnCluster.testForceAssignWhileClosing failed on Jenkins Key: HBASE-11615 URL: https://issues.apache.org/jira/browse/HBASE-11615 Project: HBase

[jira] [Commented] (HBASE-11615) TestZKLessAMOnCluster.testForceAssignWhileClosing failed on Jenkins

2014-07-30 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079384#comment-14079384 ] Mike Drob commented on HBASE-11615: --- Potentially related to HBASE-8899? It's the same

[jira] [Commented] (HBASE-11210) Consider restoring Filter class back to an interface

2014-08-04 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085192#comment-14085192 ] Mike Drob commented on HBASE-11210: --- IIRC, as long as you are only adding methods, then

[jira] [Commented] (HBASE-11936) IsolationLevel must be attribute of a Query not a Scan

2014-09-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130460#comment-14130460 ] Mike Drob commented on HBASE-11936: --- bq. ? LGTM: Looks Good To Me IsolationLevel must

[jira] [Commented] (HBASE-12207) A script to help keep your Git repo fresh

2014-10-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165490#comment-14165490 ] Mike Drob commented on HBASE-12207: --- bq. {{echo $1|sed 's/ *$//'}} I think this could

[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies

2017-07-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104988#comment-16104988 ] Mike Drob commented on HBASE-18304: --- Hi [~tamaas], when I said to exclude the protobuf dep I meant to

[jira] [Commented] (HBASE-12387) committer guidelines should include patch signoff

2017-07-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105247#comment-16105247 ] Mike Drob commented on HBASE-12387: --- Did the proposed DISCUSS thread ever happen? > committer

[jira] [Commented] (HBASE-18472) Add guava license and update supplemental-models.xml

2017-07-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105253#comment-16105253 ] Mike Drob commented on HBASE-18472: --- Hi [~easyliangjob] - is this on a specific branch? Possibly

[jira] [Commented] (HBASE-18472) Add guava license and update supplemental-models.xml

2017-07-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105295#comment-16105295 ] Mike Drob commented on HBASE-18472: --- HBASE-16351 made the error reporting friendlier, it shouldn't have

[jira] [Commented] (HBASE-15607) Remove PB references from Admin for 2.0

2017-07-31 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107907#comment-16107907 ] Mike Drob commented on HBASE-15607: --- I think this same discussion is happening on HBASE-18431 - let's

[jira] [Commented] (HBASE-15666) shaded dependencies for hbase-testing-util

2017-08-15 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127310#comment-16127310 ] Mike Drob commented on HBASE-15666: --- I'm not sure. Let me try to repeat what you said in the context of

[jira] [Updated] (HBASE-15666) shaded dependencies for hbase-testing-util

2017-08-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-15666: -- Fix Version/s: (was: 2.0.0-alpha-2) 2.0.0-alpha-3 > shaded dependencies for

[jira] [Commented] (HBASE-18503) Change ***Util and Master to use TableDescriptor and ColumnFamilyDescriptor

2017-08-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129038#comment-16129038 ] Mike Drob commented on HBASE-18503: --- [~chia7712] - not 100% related here, but can you elaborate on why

[jira] [Updated] (HBASE-18303) Clean up some parameterized test declarations

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-18303: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Clean up some parameterized test

[jira] [Commented] (HBASE-18440) ITs and Actions modify immutable TableDescriptors

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126280#comment-16126280 ] Mike Drob commented on HBASE-18440: --- Not yet, I got distracted with some other stuff, will hopefully

[jira] [Updated] (HBASE-18238) Address ruby static analysis for bin directory

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-18238: -- Fix Version/s: (was: 2.0.0) 2.0.0-alpha-2 3.0.0 > Address

[jira] [Updated] (HBASE-18238) Address ruby static analysis for bin directory

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-18238: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for review, Stack! >

[jira] [Updated] (HBASE-18303) Clean up some parameterized test declarations

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-18303: -- Fix Version/s: (was: 2.0.0) 2.0.0-alpha-2 3.0.0 > Clean up

[jira] [Assigned] (HBASE-17921) TestBlockReorder always fails against hadoop3.0.0-alpha2

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned HBASE-17921: - Assignee: Mike Drob > TestBlockReorder always fails against hadoop3.0.0-alpha2 >

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

2017-08-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121851#comment-16121851 ] Mike Drob commented on HBASE-18555: --- This seems like the perfect use case for {{putIfAbsent}} > Remove

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

2017-08-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121898#comment-16121898 ] Mike Drob commented on HBASE-18555: --- Your modification to getCellList makes it look almost identical to

[jira] [Commented] (HBASE-18271) Shade netty

2017-08-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123895#comment-16123895 ] Mike Drob commented on HBASE-18271: --- Ah, yea, I didn't understand the point of the bin/hbase change at

[jira] [Commented] (HBASE-18271) Shade netty

2017-08-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123820#comment-16123820 ] Mike Drob commented on HBASE-18271: --- {quote} In essence we need the below define whenever we run:

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

2017-08-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123394#comment-16123394 ] Mike Drob commented on HBASE-18555: --- Ah, ok, I see now. With putIfAbsent the code would have an extra

[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Attachment: HBASE-12349.v5.patch v5: rebased on latest master > Add Maven build support module for a

[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Status: Open (was: Patch Available) > Add Maven build support module for a custom version of

[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125976#comment-16125976 ] Mike Drob commented on HBASE-12349: --- Missed your question earlier, [~stack]. The bin tarball doesn't

[jira] [Commented] (HBASE-15666) shaded dependencies for hbase-testing-util

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126031#comment-16126031 ] Mike Drob commented on HBASE-15666: --- [~busbey] - can you outline what needs to be done here? I'm not

[jira] [Updated] (HBASE-15666) shaded dependencies for hbase-testing-util

2017-08-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-15666: -- Fix Version/s: (was: 2.0.0) 2.0.0-alpha-2 > shaded dependencies for

[jira] [Commented] (HBASE-18260) Address new license dependencies from hadoop3-alpha4

2017-07-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083348#comment-16083348 ] Mike Drob commented on HBASE-18260: --- [~busbey] - Any blockers on this? > Address new license

[jira] [Commented] (HBASE-17922) TestRegionServerHostname always fails against hadoop 3.0.0-alpha2

2017-07-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083491#comment-16083491 ] Mike Drob commented on HBASE-17922: --- Chatted with [~appy] about this offline a bit... It looks like

[jira] [Commented] (HBASE-18177) FanOutOneBlockAsyncDFSOutputHelper fails to compile against Hadoop 3

2017-07-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083349#comment-16083349 ] Mike Drob commented on HBASE-18177: --- [~Apache9] - Ping. Do we need anything else? >

[jira] [Commented] (HBASE-17922) TestRegionServerHostname always fails against hadoop 3.0.0-alpha2

2017-07-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083495#comment-16083495 ] Mike Drob commented on HBASE-17922: --- tl;dr - either fix this test by applying the patch I have posted,

[jira] [Updated] (HBASE-18303) Clean up some parameterized test declarations

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-18303: -- Status: Patch Available (was: Open) > Clean up some parameterized test declarations >

[jira] [Updated] (HBASE-18303) Clean up some parameterized test declarations

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-18303: -- Status: Open (was: Patch Available) > Clean up some parameterized test declarations >

[jira] [Commented] (HBASE-18175) Add hbase-spark integration test into hbase-spark-it

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085966#comment-16085966 ] Mike Drob commented on HBASE-18175: --- +1. QA Test failure is unrelated and known to be flaky. Please

[jira] [Updated] (HBASE-18303) Clean up some parameterized test declarations

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-18303: -- Attachment: HBASE-18303.patch Attaching same patch to try for QA again. > Clean up some parameterized

[jira] [Commented] (HBASE-18339) Update test-patch to use hadoop 3.0.0-alpha4

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085851#comment-16085851 ] Mike Drob commented on HBASE-18339: --- Thanks for adding a release note. Are the release note fields all

[jira] [Resolved] (HBASE-11249) Missing null check in finally block of HRegion#processRowsWithLocks() may lead to partially rolled back state in memstore.

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved HBASE-11249. --- Resolution: Not A Problem This code was rewritten in HBASE-15158, doesn't look like a problem

[jira] [Commented] (HBASE-17922) TestRegionServerHostname always fails against hadoop 3.0.0-alpha2

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085787#comment-16085787 ] Mike Drob commented on HBASE-17922: --- Ping [~appy] - do you have time to push this to master and

[jira] [Commented] (HBASE-18339) Update test-patch to use hadoop 3.0.0-alpha4

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085827#comment-16085827 ] Mike Drob commented on HBASE-18339: --- {noformat} [ERROR] Failed to execute goal

[jira] [Updated] (HBASE-18339) Update test-patch to use hadoop 3.0.0-alpha4

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-18339: -- Fix Version/s: 2.0.0-alpha-2 3.0.0 > Update test-patch to use hadoop 3.0.0-alpha4 >

[jira] [Commented] (HBASE-17922) TestRegionServerHostname always fails against hadoop 3.0.0-alpha2

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086138#comment-16086138 ] Mike Drob commented on HBASE-17922: --- Yep, I've verified it manually. Check my first comment for

[jira] [Commented] (HBASE-18377) Error handling for FileNotFoundException should consider RemoteException in ReplicationSource#openReader()

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086159#comment-16086159 ] Mike Drob commented on HBASE-18377: --- [~tedyu] - is this something that makes sense to add a test for?

[jira] [Comment Edited] (HBASE-17919) HBase 2.x over hadoop 3.x umbrella

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086143#comment-16086143 ] Mike Drob edited comment on HBASE-17919 at 7/13/17 6:18 PM: Possibly relevant

[jira] [Commented] (HBASE-17919) HBase 2.x over hadoop 3.x umbrella

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086143#comment-16086143 ] Mike Drob commented on HBASE-17919: --- DFSMiniClluster changed some behavior going into hadoop3 where it

[jira] [Commented] (HBASE-18147) nightly job to check health of active branches

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086472#comment-16086472 ] Mike Drob commented on HBASE-18147: --- Can you point us at a specific build number that has sample

[jira] [Commented] (HBASE-18175) Add hbase-spark integration test into hbase-spark-it

2017-07-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086693#comment-16086693 ] Mike Drob commented on HBASE-18175: --- To clarify, I think you've iterated a lot on this patch already

[jira] [Commented] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090032#comment-16090032 ] Mike Drob commented on HBASE-18393: --- Filed https://github.com/jruby/jruby/issues/4719 > hbase shell

[jira] [Commented] (HBASE-18185) IntegrationTestTimeBoundedRequestsWithRegionReplicas unbalanced tests fails with AssertionError

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089997#comment-16089997 ] Mike Drob commented on HBASE-18185: --- This LGTM, [~huaxiang] do you have any further comments? >

[jira] [Commented] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090012#comment-16090012 ] Mike Drob commented on HBASE-18393: --- I think this is a JRuby issue, I can reproduce it easily:

[jira] [Commented] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090185#comment-16090185 ] Mike Drob commented on HBASE-18393: --- Apparently this is also a bug in MRI, so let's think about the

[jira] [Commented] (HBASE-18161) Incremental Load support for Multiple-Table HFileOutputFormat

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090204#comment-16090204 ] Mike Drob commented on HBASE-18161: --- This looks committed already, can you resolve the issue [~tedyu]

[jira] [Commented] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090311#comment-16090311 ] Mike Drob commented on HBASE-18393: --- I _think_ that RubyLex will handle line continuations while ARGF

[jira] [Comment Edited] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090315#comment-16090315 ] Mike Drob edited comment on HBASE-18393 at 7/17/17 6:46 PM: We should do

[jira] [Commented] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090315#comment-16090315 ] Mike Drob commented on HBASE-18393: --- We should do the minimal fix here and then file a new JIRA to

[jira] [Assigned] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned HBASE-18393: - Assignee: Mike Drob (was: Samir Ahmic) Yes, I can take this. Thanks for helping investigate!

[jira] [Commented] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090423#comment-16090423 ] Mike Drob commented on HBASE-18393: --- With ARGF: {noformat} mdrob@mdrob-MBP:~/IdeaProjects/hbase$ cat

[jira] [Commented] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090435#comment-16090435 ] Mike Drob commented on HBASE-18393: --- [~asamir] - if you're end up creating a patch, please include a

[jira] [Commented] (HBASE-18396) Encode ZNode names to reduce ZooKeeper jute buffer length requirements and thus reduce memory usage

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090440#comment-16090440 ] Mike Drob commented on HBASE-18396: --- The problem here is usually that you have some set of children

[jira] [Commented] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090495#comment-16090495 ] Mike Drob commented on HBASE-18393: --- Hmmm, was thinking about this and adding an explicit test for

[jira] [Commented] (HBASE-18393) hbase shell non-interactive broken

2017-07-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090515#comment-16090515 ] Mike Drob commented on HBASE-18393: --- We already have tests that calling non interactive mode on the

[jira] [Created] (HBASE-18337) hbase-shaded-server brings in signed jars

2017-07-07 Thread Mike Drob (JIRA)
Mike Drob created HBASE-18337: - Summary: hbase-shaded-server brings in signed jars Key: HBASE-18337 URL: https://issues.apache.org/jira/browse/HBASE-18337 Project: HBase Issue Type: Bug

  1   2   3   4   5   6   7   8   9   10   >