[GitHub] [hbase] Apache9 commented on pull request #1753: HBAE-24408 Introduce a general 'local region' to store data on master

2020-05-22 Thread GitBox
Apache9 commented on pull request #1753: URL: https://github.com/apache/hbase/pull/1753#issuecomment-632546165 Let me check the failed UTs. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache9 commented on pull request #1753: HBAE-24408 Introduce a general 'local region' to store data on master

2020-05-22 Thread GitBox
Apache9 commented on pull request #1753: URL: https://github.com/apache/hbase/pull/1753#issuecomment-632537481 > Looks great. Some questions. > > Another question is those who have deployed tests on branch-2.3 will have to shutdown these tests, remove the procedure store dir and then

[GitHub] [hbase] Apache9 commented on pull request #1753: HBAE-24408 Introduce a general 'local region' to store data on master

2020-05-21 Thread GitBox
Apache9 commented on pull request #1753: URL: https://github.com/apache/hbase/pull/1753#issuecomment-632165806 Another benefit for this patch is that, now HFile will be stored on the root file system instead of wal filesystem, so we can reuse the HFileCleaner instead of creating a new one

[GitHub] [hbase] Apache9 commented on pull request #1753: HBAE-24408 Introduce a general 'local region' to store data on master

2020-05-21 Thread GitBox
Apache9 commented on pull request #1753: URL: https://github.com/apache/hbase/pull/1753#issuecomment-632160822 The implementation is not perfect, as it initialize the store in RegionProcedureStore, and also the HFilePrinter and WALPrinter can not handle more than 1 family correctly.