[GitHub] [hbase] Apache9 commented on pull request #1753: HBAE-24408 Introduce a general 'local region' to store data on master
Apache9 commented on pull request #1753: URL: https://github.com/apache/hbase/pull/1753#issuecomment-632546165 Let me check the failed UTs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1753: HBAE-24408 Introduce a general 'local region' to store data on master
Apache9 commented on pull request #1753: URL: https://github.com/apache/hbase/pull/1753#issuecomment-632537481 > Looks great. Some questions. > > Another question is those who have deployed tests on branch-2.3 will have to shutdown these tests, remove the procedure store dir and then restart w/ a later version of 2.3 that has this in it? i.e. how to migrate existing 2.3s? A shutdown, remove, and restart seems fine since no 2.3 release as yet. > > Good stuff. Leaving it there or removing it are both fine, if you want to keep the data then just follow the new naming to rename the old directory. We do not change the data format of the region. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1753: HBAE-24408 Introduce a general 'local region' to store data on master
Apache9 commented on pull request #1753: URL: https://github.com/apache/hbase/pull/1753#issuecomment-632165806 Another benefit for this patch is that, now HFile will be stored on the root file system instead of wal filesystem, so we can reuse the HFileCleaner instead of creating a new one by our own. And it is also a good news if later we want to implement WAL on a system other than file system. Added a UT called TestLocalRegionOnTwoFileSystems to confirm it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1753: HBAE-24408 Introduce a general 'local region' to store data on master
Apache9 commented on pull request #1753: URL: https://github.com/apache/hbase/pull/1753#issuecomment-632160822 The implementation is not perfect, as it initialize the store in RegionProcedureStore, and also the HFilePrinter and WALPrinter can not handle more than 1 family correctly. But anyway, it is enough for shipping with 2.3.0, later when we want to store more data in the region, we can refactor the code, maybe in HBASE-24388. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
