[GitHub] [hbase] PierreZ commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment

2019-08-16 Thread GitBox
PierreZ commented on issue #439: HBASE-22618 Provide a way to have 
Heterogeneous deployment
URL: https://github.com/apache/hbase/pull/439#issuecomment-521930519
 
 
   > The intermittent failures are not really related. Latest changes look 
good. Let me rebase it locally, get a patch and submit it in the jira for a 
last round of pre-commit tests.
   
   Thank you @wchevreuil !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] PierreZ commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment

2019-08-14 Thread GitBox
PierreZ commented on issue #439: HBASE-22618 Provide a way to have 
Heterogeneous deployment
URL: https://github.com/apache/hbase/pull/439#issuecomment-521171549
 
 
   Hi!
   
   It seems I have different failed junit tests at each run, should I be 
worried?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] PierreZ commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment

2019-08-09 Thread GitBox
PierreZ commented on issue #439: HBASE-22618 Provide a way to have 
Heterogeneous deployment
URL: https://github.com/apache/hbase/pull/439#issuecomment-519975242
 
 
   I can't understand the checkstyle problem with the import order, here's the 
report:
   
   ```
   
./hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java:47:import
 java.util.Arrays;: Wrong order for 'java.util.Arrays' import. [ImportOrder]
   
./hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java:48:import
 java.util.ArrayList;: Wrong order for 'java.util.ArrayList' import. 
[ImportOrder]
   ```
   
   But [lines 47/48 does not correspond to the specified lines in the 
report](https://github.com/PierreZ/hbase/blob/4392a43a21643e45857c3872c85e6fcf95839cb6/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java#L47-L48).
 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] PierreZ commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment

2019-08-04 Thread GitBox
PierreZ commented on issue #439: HBASE-22618 Provide a way to have 
Heterogeneous deployment
URL: https://github.com/apache/hbase/pull/439#issuecomment-518016710
 
 
   Thanks for your comments @wchevreuil! The checkstyles issues should be fixed 
now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services