[GitHub] [hbase] apurtell commented on pull request #3234: HBASE-25854 Remove redundant AM in-memory state changes in CatalogJanitor

2021-05-05 Thread GitBox
apurtell commented on pull request #3234: URL: https://github.com/apache/hbase/pull/3234#issuecomment-833220235 `TestReplicationSource` failure is not related. [INFO] --- [INFO] T E S T S [INFO]

[GitHub] [hbase] apurtell commented on pull request #3234: HBASE-25854 Remove redundant AM in-memory state changes in CatalogJanitor

2021-05-05 Thread GitBox
apurtell commented on pull request #3234: URL: https://github.com/apache/hbase/pull/3234#issuecomment-833128705 Ok, let me rebase this and fix the unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] apurtell commented on pull request #3234: HBASE-25854 Remove redundant AM in-memory state changes in CatalogJanitor

2021-05-05 Thread GitBox
apurtell commented on pull request #3234: URL: https://github.com/apache/hbase/pull/3234#issuecomment-833127897 > (I just noticed the wonky split message -- have started a bit of ITBLL over here...) I've committed a few changes over the past couple of days. One was an accumulation

[GitHub] [hbase] apurtell commented on pull request #3234: HBASE-25854 Remove redundant AM in-memory state changes in CatalogJanitor

2021-05-05 Thread GitBox
apurtell commented on pull request #3234: URL: https://github.com/apache/hbase/pull/3234#issuecomment-832857609 Although the unit test will fail, when I tried this change out on a cluster in a very write heavy ingestion test, the end result was good. The ingestion test completes

[GitHub] [hbase] apurtell commented on pull request #3234: HBASE-25854 Remove redundant AM in-memory state changes in CatalogJanitor

2021-05-05 Thread GitBox
apurtell commented on pull request #3234: URL: https://github.com/apache/hbase/pull/3234#issuecomment-832855720 @Apache9 added some context on https://github.com/apache/hbase/pull/3230 > Some background > > https://issues.apache.org/jira/browse/HBASE-24942 > > I've

[GitHub] [hbase] apurtell commented on pull request #3234: HBASE-25854 Remove redundant AM in-memory state changes in CatalogJanitor

2021-05-05 Thread GitBox
apurtell commented on pull request #3234: URL: https://github.com/apache/hbase/pull/3234#issuecomment-832854650 This change is moved here from https://github.com/apache/hbase/pull/3230. We know from the test report there that `TestCatalogJanitorInMemoryStates` will fail. Let's let