[GitHub] [hbase] bharathv commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-16 Thread GitBox
bharathv commented on issue #1051: HBASE-23665: Split unit tests from 
TestTableName into a separate test…
URL: https://github.com/apache/hbase/pull/1051#issuecomment-575359963
 
 
   Fixed the check style nit and removed some dead code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] bharathv commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-15 Thread GitBox
bharathv commented on issue #1051: HBASE-23665: Split unit tests from 
TestTableName into a separate test…
URL: https://github.com/apache/hbase/pull/1051#issuecomment-574901875
 
 
   @ndimiduk I think this has to do with the mvn version. Maven 3.2.3 and later 
fixed it out of the box[1]. Apache repos are https by default. Only the central 
repo is defaulting to http.
   
   [1] http://maven.apache.org/docs/3.2.3/release-notes.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] bharathv commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-15 Thread GitBox
bharathv commented on issue #1051: HBASE-23665: Split unit tests from 
TestTableName into a separate test…
URL: https://github.com/apache/hbase/pull/1051#issuecomment-574897876
 
 
   Ah found it... here is the reason: 
https://blog.sonatype.com/central-repository-moving-to-https


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] bharathv commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-15 Thread GitBox
bharathv commented on issue #1051: HBASE-23665: Split unit tests from 
TestTableName into a separate test…
URL: https://github.com/apache/hbase/pull/1051#issuecomment-574895814
 
 
   Hmm, its weird that only this patch is running into the flaky maven download 
issue. Patch didn't touch anything in the build system. Digging into it to see 
if I can find some clues.
   
   > The project org.apache.hbase:hbase-common:1.6.0-SNAPSHOT 
(/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1051/src/hbase-common/pom.xml)
 has 1 error
   > [ERROR] Unresolveable build extension: Plugin 
org.apache.felix:maven-bundle-plugin:2.5.3 or one of its dependencies could not 
be resolved: Failed to collect dependencies for 
org.apache.felix:maven-bundle-plugin:jar:2.5.3 (): Failed to read artifact 
descriptor for org.apache.felix:maven-bundle-plugin:jar:2.5.3: Could not 
transfer artifact org.apache.felix:maven-bundle-plugin:pom:2.5.3 from/to 
central (http://repo.maven.apache.org/maven2): Failed to transfer file: 
http://repo.maven.apache.org/maven2/org/apache/felix/maven-bundle-plugin/2.5.3/maven-bundle-plugin-2.5.3.pom.
 Return code is: 501 , ReasonPhrase:HTTPS Required. -> [Help 2]
   > [ERROR] 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] bharathv commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-15 Thread GitBox
bharathv commented on issue #1051: HBASE-23665: Split unit tests from 
TestTableName into a separate test…
URL: https://github.com/apache/hbase/pull/1051#issuecomment-574811232
 
 
   @ndimiduk Here is the back port for branch-1. So many conflicts due to 
client api changes, but mostly trivial.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services