[GitHub] [hbase] busbey commented on a change in pull request #1726: HBASE-24296 install yetus as a part of building the rm docker image.
busbey commented on a change in pull request #1726:
URL: https://github.com/apache/hbase/pull/1726#discussion_r427615327
##
File path: dev-support/create-release/release-util.sh
##
@@ -423,17 +430,14 @@ function get_jira_name {
# Update the CHANGES.md
# DOES NOT DO COMMITS! Caller should do that.
+# requires yetus to have a defined home already.
Review comment:
take a look at the updated changeset please. we prompt now when running
non-docker tag stage.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1726: HBASE-24296 install yetus as a part of building the rm docker image.
busbey commented on a change in pull request #1726: URL: https://github.com/apache/hbase/pull/1726#discussion_r427614954 ## File path: dev-support/create-release/do-release-docker.sh ## @@ -75,6 +75,7 @@ Options: If none specified, runs tag, then publish-dist, and then publish-release. 'publish-snapshot' is also an allowed, less used, option. EOF + exit 0 Review comment: current version exits non-zero. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1726: HBASE-24296 install yetus as a part of building the rm docker image.
busbey commented on a change in pull request #1726: URL: https://github.com/apache/hbase/pull/1726#discussion_r427471792 ## File path: dev-support/create-release/do-release-docker.sh ## @@ -75,6 +75,7 @@ Options: If none specified, runs tag, then publish-dist, and then publish-release. 'publish-snapshot' is also an allowed, less used, option. EOF + exit 0 Review comment: ah I see the other usage we have exists with 1. I'll make that consistent then. ## File path: dev-support/create-release/do-release-docker.sh ## @@ -75,6 +75,7 @@ Options: If none specified, runs tag, then publish-dist, and then publish-release. 'publish-snapshot' is also an allowed, less used, option. EOF + exit 0 Review comment: ah I see the other usage we have exits with 1. I'll make that consistent then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1726: HBASE-24296 install yetus as a part of building the rm docker image.
busbey commented on a change in pull request #1726:
URL: https://github.com/apache/hbase/pull/1726#discussion_r427468389
##
File path: dev-support/create-release/hbase-rm/Dockerfile
##
@@ -43,6 +43,12 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get -qq -y update \
&& update-alternatives --set java
/usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java \
&& pip install \
python-dateutil==2.8.1
+# Install Apache Yetus
+ENV YETUS_VERSION 0.11.1
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN wget -qO-
"https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download=/yetus/${YETUS_VERSION}/apache-yetus-${YETUS_VERSION}-bin.tar.gz;
| \
+tar xvz -C /opt
+ENV YETUS_HOME /opt/apache-yetus-${YETUS_VERSION}
Review comment:
if it is done at docker build time it happens once and is cached. rather
then happening on every single run.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1726: HBASE-24296 install yetus as a part of building the rm docker image.
busbey commented on a change in pull request #1726:
URL: https://github.com/apache/hbase/pull/1726#discussion_r427468904
##
File path: dev-support/create-release/release-util.sh
##
@@ -423,17 +430,14 @@ function get_jira_name {
# Update the CHANGES.md
# DOES NOT DO COMMITS! Caller should do that.
+# requires yetus to have a defined home already.
Review comment:
let me go back and look. I was trying to make this equivalent to the
JAVA_HOME we have already.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1726: HBASE-24296 install yetus as a part of building the rm docker image.
busbey commented on a change in pull request #1726:
URL: https://github.com/apache/hbase/pull/1726#discussion_r427468389
##
File path: dev-support/create-release/hbase-rm/Dockerfile
##
@@ -43,6 +43,12 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get -qq -y update \
&& update-alternatives --set java
/usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java \
&& pip install \
python-dateutil==2.8.1
+# Install Apache Yetus
+ENV YETUS_VERSION 0.11.1
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN wget -qO-
"https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download=/yetus/${YETUS_VERSION}/apache-yetus-${YETUS_VERSION}-bin.tar.gz;
| \
+tar xvz -C /opt
+ENV YETUS_HOME /opt/apache-yetus-${YETUS_VERSION}
Review comment:
if it is done at docker build time it happens once and is cached. rathe
then happening on every single run.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
