[GitHub] [hbase] joshelser edited a comment on issue #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-15 Thread GitBox
joshelser edited a comment on issue #884: HBASE-23347 Allowable custom 
authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#issuecomment-574766441
 
 
   Progress update with what i've pushed since Monday.
   - [x] some Text nits from Andrew
   - [x] Wellington's suggestion for an init(Configuration)
   - [x] UGI to User
   - [ ] removal of SASL from name/structure suggestions from Andrew to (maybe 
now?) implement.
   - [x] finishing up the hbase-example addition


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] joshelser edited a comment on issue #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-15 Thread GitBox
joshelser edited a comment on issue #884: HBASE-23347 Allowable custom 
authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#issuecomment-574766441
 
 
   Progress update with what i've pushed since Monday.
   - [x] some Text nits from Andrew
   - [x] Wellington's suggestion for an init(Configuration)
   - [x] UGI to User
   - [ ] removal of SASL from name/structure suggestions from Andrew to (maybe 
now?) implement.
   - [x] finishing up the hbase-example addition


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] joshelser edited a comment on issue #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-15 Thread GitBox
joshelser edited a comment on issue #884: HBASE-23347 Allowable custom 
authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#issuecomment-574766441
 
 
   Progress update with what i've pushed since Monday.
   - [x] some Text nits from Andrew
   - [x] Wellington's suggestion for an init(Configuration)
   - [ ] UGI to User
   - [ ] removal of SASL from name/structure suggestions from Andrew to (maybe 
now?) implement.
   - [x] finishing up the hbase-example addition


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] joshelser edited a comment on issue #884: HBASE-23347 Allowable custom authentication methods for RPCs

2020-01-14 Thread GitBox
joshelser edited a comment on issue #884: HBASE-23347 Allowable custom 
authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#issuecomment-573965516
 
 
   I have some Text nits from Andrew, Wellington's suggestion for an 
`init(Configuration)`, UGI to User, and some removal of SASL from 
name/structure suggestions from Andrew to (maybe now?) implement. I'll knock 
these out tmrw, along with finishing up the hbase-example addition that I've 
been sitting on since the holidays :)
   
   Thanks Reid for also dropping by! Anyone else who is still in the process of 
reviewing, please shout before I move on without you :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services