[GitHub] [hbase] mmpataki edited a comment on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-23 Thread GitBox 


mmpataki edited a comment on pull request #1814:
URL: https://github.com/apache/hbase/pull/1814#issuecomment-648239137


   > 
   > @busbey @saintstack I am blocked because of this (HADOOP-17081) issue I 
reported today (I will fix it) and for now, trying to implement a hack, any 
suggestions are welcome.
   > 
   
   I solved this by adding a Helper class in to hadoop-metrics2 package (in 
hadoop compat project)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] mmpataki edited a comment on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-30 Thread GitBox 


mmpataki edited a comment on pull request #1814:
URL: https://github.com/apache/hbase/pull/1814#issuecomment-636420308


   @saintstack 
   
   > @mmpataki We have flakey tests.
   
   I am sorry, I ran tests from the IDE and not from mvn, so this build issue 
came up.
   
   > Looks good but we export protmetheus metrics even when they are not of 
use, not being accessed?
   
   thank you for the review, I will add a configuration to enable it (disabled 
by default). 
   // I asked about this in mailing list but didn't get any responses. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org