[GitHub] [hbase] nyl3532016 commented on a change in pull request #1731: HBASE-24387 TableSnapshotInputFormatImpl support row limit on each InputSplit

2020-05-23 Thread GitBox 


nyl3532016 commented on a change in pull request #1731:
URL: https://github.com/apache/hbase/pull/1731#discussion_r429553134



##
File path: 
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java
##
@@ -304,6 +305,56 @@ public void testWithMockedMapReduceWithNoStartRowStopRow() 
throws Exception {
 }
   }
 
+  @Test
+  public void testScanLimit() throws Exception {
+setupCluster();

Review comment:
   Would you like to help merge this PR?  Thanks





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] nyl3532016 commented on a change in pull request #1731: HBASE-24387 TableSnapshotInputFormatImpl support row limit on each InputSplit

2020-05-20 Thread GitBox 


nyl3532016 commented on a change in pull request #1731:
URL: https://github.com/apache/hbase/pull/1731#discussion_r428408671



##
File path: 
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java
##
@@ -304,6 +305,56 @@ public void testWithMockedMapReduceWithNoStartRowStopRow() 
throws Exception {
 }
   }
 
+  @Test
+  public void testScanLimit() throws Exception {
+setupCluster();

Review comment:
   It is better to submit another PR to fix?after this one merged, I will 
amend it





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org