[GitHub] [hbase] openinx commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot

[GitBox]

openinx commented on a change in pull request #486: HBASE-22810 Initialize an 
separate ThreadPoolExecutor for taking/restoring snapshot
URL: https://github.com/apache/hbase/pull/486#discussion_r313780895
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 ##
 @@ -1431,6 +1431,8 @@ private void startServiceThreads() throws IOException{
   conf.getInt("hbase.master.executor.meta.serverops.threads", 5));
this.executorService.startExecutorService(ExecutorType.M_LOG_REPLAY_OPS,
   conf.getInt("hbase.master.executor.logreplayops.threads", 10));
+   
this.executorService.startExecutorService(ExecutorType.MASTER_SNAPSHOT_OPERATIONS,
 
 Review comment:
   Different table can snapshot at the same time , for the given table, only 
one snapshot can be taking (Have a tableLock to ensure that).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] openinx commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot

[GitBox]

openinx commented on a change in pull request #486: HBASE-22810 Initialize an 
separate ThreadPoolExecutor for taking/restoring snapshot
URL: https://github.com/apache/hbase/pull/486#discussion_r313778032
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventType.java
 ##
 @@ -321,11 +321,6 @@ public static EventType get(final int code) {
 throw new IllegalArgumentException("Unknown code " + code);
   }
 
-  public boolean isOnlineSchemaChangeSupported() {
 
 Review comment:
   Yes, can remove now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] openinx commented on a change in pull request #486: HBASE-22810 Initialize an separate ThreadPoolExecutor for taking/restoring snapshot

[GitBox]

openinx commented on a change in pull request #486: HBASE-22810 Initialize an 
separate ThreadPoolExecutor for taking/restoring snapshot
URL: https://github.com/apache/hbase/pull/486#discussion_r313780930
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 ##
 @@ -1431,6 +1431,8 @@ private void startServiceThreads() throws IOException{
   conf.getInt("hbase.master.executor.meta.serverops.threads", 5));
this.executorService.startExecutorService(ExecutorType.M_LOG_REPLAY_OPS,
   conf.getInt("hbase.master.executor.logreplayops.threads", 10));
+   
this.executorService.startExecutorService(ExecutorType.MASTER_SNAPSHOT_OPERATIONS,
+  conf.getInt("hbase.master.executor.snapshot.threads", 3));
 
 Review comment:
   Fine


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services