[GitHub] [hbase] ramkrish86 commented on a change in pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-23 Thread GitBox
ramkrish86 commented on a change in pull request #2582: URL: https://github.com/apache/hbase/pull/2582#discussion_r529255627 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/SizeCachedByteBufferKeyValue.java ## @@ -0,0 +1,90 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
ramkrish86 commented on a change in pull request #2582: URL: https://github.com/apache/hbase/pull/2582#discussion_r519709637 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java ## @@ -554,8 +559,10 @@ protected int blockSeek(Cell

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-05 Thread GitBox
ramkrish86 commented on a change in pull request #2582: URL: https://github.com/apache/hbase/pull/2582#discussion_r518546602 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java ## @@ -790,23 +797,28 @@ public Cell getCell() {

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-05 Thread GitBox
ramkrish86 commented on a change in pull request #2582: URL: https://github.com/apache/hbase/pull/2582#discussion_r518546602 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java ## @@ -790,23 +797,28 @@ public Cell getCell() {

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-05 Thread GitBox
ramkrish86 commented on a change in pull request #2582: URL: https://github.com/apache/hbase/pull/2582#discussion_r518546426 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java ## @@ -790,23 +797,28 @@ public Cell getCell() {

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-05 Thread GitBox
ramkrish86 commented on a change in pull request #2582: URL: https://github.com/apache/hbase/pull/2582#discussion_r518036683 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java ## @@ -790,23 +797,28 @@ public Cell getCell() {

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-05 Thread GitBox
ramkrish86 commented on a change in pull request #2582: URL: https://github.com/apache/hbase/pull/2582#discussion_r517935274 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java ## @@ -554,8 +559,10 @@ protected int blockSeek(Cell

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-05 Thread GitBox
ramkrish86 commented on a change in pull request #2582: URL: https://github.com/apache/hbase/pull/2582#discussion_r517919646 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/SizeCachedKeyValue.java ## @@ -39,12 +39,22 @@ private short rowLen; private int