[jira] [Comment Edited] (HBASE-16664) Timeout logic in AsyncProcess is broken
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574081#comment-15574081 ] Phil Yang edited comment on HBASE-16664 at 10/14/16 3:45 AM: - I added them in HBASE-15645, but it broke compatibility that implements this interface. So they were removed in HBASE-16420 was (Author: yangzhe1991): I added them in HBASE-15645, but it broke compatibility that implements this interface. So they are removed in HBASE-16420 > Timeout logic in AsyncProcess is broken > --- > > Key: HBASE-16664 > URL: https://issues.apache.org/jira/browse/HBASE-16664 > Project: HBase > Issue Type: Bug >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.8 > > Attachments: 1.patch, HBASE-16664-branch-1-v1.patch, > HBASE-16664-branch-1-v1.patch, HBASE-16664-branch-1-v2.patch, > HBASE-16664-branch-1.1-v1.patch, HBASE-16664-branch-1.2-v1.patch, > HBASE-16664-branch-1.3-v1.patch, HBASE-16664-branch-1.3-v2.patch, > HBASE-16664-branch-1.3.v3.patch, HBASE-16664-branch-1.v3.patch, > HBASE-16664-v1.patch, HBASE-16664-v2.patch, HBASE-16664-v3.patch, > HBASE-16664-v4.patch, HBASE-16664-v5.patch, HBASE-16664-v6.patch, > HBASE-16664-v7.patch, testhcm.patch > > > Rpc/operation timeout logic in AsyncProcess is broken. And Table's > set*Timeout does not take effect in its AP or BufferedMutator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-16664) Timeout logic in AsyncProcess is broken
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567420#comment-15567420 ] Heng Chen edited comment on HBASE-16664 at 10/12/16 3:34 AM: - The typical case in our application is something like TestFromClientSide did 1. get HTable object 2. call batch puts 3. call get 4. close HTable It is ok now. 2 and 3 maybe in different threads was (Author: chenheng): The typical case in our application is something like TestFromClientSide did 1. get HTable object 2. call batch puts 3. call get 4. close HTable It is ok now. > Timeout logic in AsyncProcess is broken > --- > > Key: HBASE-16664 > URL: https://issues.apache.org/jira/browse/HBASE-16664 > Project: HBase > Issue Type: Bug >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: 1.patch, HBASE-16664-branch-1-v1.patch, > HBASE-16664-branch-1-v1.patch, HBASE-16664-branch-1.1-v1.patch, > HBASE-16664-branch-1.2-v1.patch, HBASE-16664-branch-1.3-v1.patch, > HBASE-16664-v1.patch, HBASE-16664-v2.patch, HBASE-16664-v3.patch, > HBASE-16664-v4.patch, HBASE-16664-v5.patch, testhcm.patch > > > Have not checked the root cause, but I think timeout of all operations in > AsyncProcess is broken -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-16664) Timeout logic in AsyncProcess is broken
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528946#comment-15528946 ] Heng Chen edited comment on HBASE-16664 at 9/28/16 8:49 AM: So we could modify the operation timeout judgement logic in CancellableRegionServerCallable? Now we use remaining==0 to check whether the timeout is reached, change it to be <= 1? was (Author: chenheng): So we could modify the operation timeout judgement logic in CancellableRegionServerCallable? Now we use remaining==0 to check whether the timeout is reached, change it to be 1? > Timeout logic in AsyncProcess is broken > --- > > Key: HBASE-16664 > URL: https://issues.apache.org/jira/browse/HBASE-16664 > Project: HBase > Issue Type: Bug >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: 1.patch, HBASE-16664-v1.patch, HBASE-16664-v2.patch, > testhcm.patch > > > Have not checked the root cause, but I think timeout of all operations in > AsyncProcess is broken -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-16664) Timeout logic in AsyncProcess is broken
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515594#comment-15515594 ] Phil Yang edited comment on HBASE-16664 at 9/23/16 6:42 AM: And for some operations, like append, we use NoncedRegionServerCallable extends CancellableRegionServerCallable, but we use caller's callWithRetries, both of them have logic of operation timeout, they are conflicting . But the logic in CancellableRegionServerCallable is broken, so it just works... was (Author: yangzhe1991): And for some operations, like append, we use NoncedRegionServerCallable extends CancellableRegionServerCallable, but we use caller's callWithRetries, both of time have logic of operation timeout, they are conflicting . But the logic in CancellableRegionServerCallable is broken, so it just works... > Timeout logic in AsyncProcess is broken > --- > > Key: HBASE-16664 > URL: https://issues.apache.org/jira/browse/HBASE-16664 > Project: HBase > Issue Type: Bug >Reporter: Phil Yang > Attachments: testhcm.patch > > > Have not checked the root cause, but I think timeout of all operations in > AsyncProcess is broken -- This message was sent by Atlassian JIRA (v6.3.4#6332)
