[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541259#comment-16541259 ]
Reid Chan edited comment on HBASE-19572 at 7/12/18 7:40 AM: ------------------------------------------------------------ I just think your patch can do much better if you get to know {{AbstractHBaseTool}} framework better, especially for the usage of {{conf}}, there're redundant codes. was (Author: reidchan): I just think your patch can do much better if you get to know {{AbstractHBaseTool}} framework better, especially for the usage of {{conf}}, there're redundant codes. > RegionMover should use the configured default port number and not the one > from HConstants > ----------------------------------------------------------------------------------------- > > Key: HBASE-19572 > URL: https://issues.apache.org/jira/browse/HBASE-19572 > Project: HBase > Issue Type: Bug > Reporter: Esteban Gutierrez > Assignee: Toshihiro Suzuki > Priority: Major > Attachments: HBASE-19572.master.001.patch, > HBASE-19572.master.001.patch, HBASE-19572.master.003.patch, > HBASE-19572.master.004.patch, HBASE-19572.master.004.patch, > HBASE-19572.master.005.patch > > > The issue I ran into HBASE-19499 was due RegionMover not using the port used > by {{hbase-site.xml}}. The tool should use the value used in the > configuration before falling back to the hardcoded value > {{HConstants.DEFAULT_REGIONSERVER_PORT}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)