[jira] [Comment Edited] (HBASE-19970) Remove unused functions from TableAuthManager

2018-02-12 Thread Appy (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361612#comment-16361612
 ] 

Appy edited comment on HBASE-19970 at 2/13/18 12:34 AM:


No, the failure doesn't seem related. Ran it locally too, passed.
However, it was interesting to see 4.2 GB log from single test.
[~uagashe] It's something around batchMutate and getRowLockInternal. Mind 
taking a look sir since you were around these parts recently (in separate 
jira). At the very least, we should nerf the logging...4.2 gb logs is crazy!  :)

Pushing to master and backporting --all the way back.-- stopped at branch-1. 
Didn't backport to maintenance release since it's not a bug.


was (Author: appy):
No, the failure doesn't seem related. Ran it locally too, passed.
However, it was interesting to see 4.2 GB log from single test.
[~uagashe] It's something around batchMutate and getRowLockInternal. Mind 
taking a look sir since you were around these parts recently (in separate 
jira). At the very least, we should nerf the logging...4.2 gb logs is crazy!  :)

Pushing to master and backporting all the way back.

> Remove unused functions from TableAuthManager
> -
>
> Key: HBASE-19970
> URL: https://issues.apache.org/jira/browse/HBASE-19970
> Project: HBase
>  Issue Type: Task
>Reporter: Appy
>Assignee: Appy
>Priority: Minor
> Fix For: 1.5.0, 2.0.0-beta-2
>
> Attachments: HBASE-19970.master.001.patch
>
>
> Functions deleted in TableAuthManager:
> - setTableUserPermissions
> - setTableGroupPermissions
> - setNamespaceUserPermissions
> - setNamespaceGroupPermissions
> - writeTableToZooKeeper
> - writeNamespaceToZooKeeper
> To make sure it was not a bug, and that relevant functionality moved to some 
> alternate code path, tried to find out why and when these functions went out 
> of use. But just couldn't figure out...until i reached the patch which added 
> them. Looks like they were dead functions to start with :)
> Jira which added them: HBASE-8409. Commit id: 
> ac10b3c13d6b66e12d0c9601204b01dfa525ed19



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (HBASE-19970) Remove unused functions from TableAuthManager

2018-02-09 Thread Appy (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359209#comment-16359209
 ] 

Appy edited comment on HBASE-19970 at 2/10/18 2:37 AM:
---

I was trying to understand read/write paths for ACL meta data, looks like the 
write path is as following (and doesn't involve deleted functions in any way):
grant() rpc --> execute CP service on ACL table's region --> write data to ACL 
region --> postGet hook --> use ZKPermissionsWatcher to write new data to zk


was (Author: appy):
I was trying to understand read/write paths for ACL meta data, looks like the 
write path is:
grant() rpc --> execute CP service on ACL table's region --> write data to ACL 
region --> postGet hook --> use ZKPermissionsWatcher to write new data to zk

> Remove unused functions from TableAuthManager
> -
>
> Key: HBASE-19970
> URL: https://issues.apache.org/jira/browse/HBASE-19970
> Project: HBase
>  Issue Type: Task
>Reporter: Appy
>Assignee: Appy
>Priority: Minor
>
> Functions deleted in TableAuthManager:
> - setTableUserPermissions
> - setTableGroupPermissions
> - setNamespaceUserPermissions
> - setNamespaceGroupPermissions
> - writeTableToZooKeeper
> - writeNamespaceToZooKeeper
> To make sure it was not a bug, and that relevant functionality moved to some 
> alternate code path, tried to find out why and when these functions went out 
> of use. But just couldn't figure out...until i reached the patch which added 
> them. Looks like they were dead functions to start with :)
> Jira which added them: HBASE-8409. Commit id: 
> ac10b3c13d6b66e12d0c9601204b01dfa525ed19



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)