[jira] [Comment Edited] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126359#comment-17126359 ] Sean Busbey edited comment on HBASE-20904 at 6/5/20, 4:01 AM: -- [~mmpataki] I've added you to the contributor group in jira so you should be able to assign this to yourself now. Please place it in "patch available" status since you already have made a PR. was (Author: busbey): @mmpataki I've added you to the contributor group in jira so you should be able to assign this to yourself now. Please place it in "patch available" status since you already have made a PR. > Prometheus /metrics http endpoint for monitoring integration > > > Key: HBASE-20904 > URL: https://issues.apache.org/jira/browse/HBASE-20904 > Project: HBase > Issue Type: New Feature > Components: metrics, monitoring >Reporter: Hari Sekhon >Priority: Major > > Feature Request to add Prometheus /metrics http endpoint for monitoring > integration: > [https://prometheus.io/docs/prometheus/latest/configuration/configuration/#%3Cscrape_config%3E] > Prometheus metrics format for that endpoint: > [https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120316#comment-17120316 ] Madhusoodan edited comment on HBASE-20904 at 5/30/20, 6:05 PM: --- I worked on this today and submitted a PR (1814). *Implementation / Usage details* /metrics is still supported against Hadoop2 so not using /metrics endpoint. Since all the metricsources have not moved to new metrics API, I added two servlets. a. /prom (PrometheusServlet) uses the new metrics API. b. /prom2 (PrometheusHadoop2Servlet) uses the old hadoop2 metrics API PrometheusHadoop2Servlet can be thrown out once all the metricsources start using the new API. Side note # Most of the servlet code for /prom2 code is cloned from HADOOP-16398 was (Author: mmpataki): I have worked on this today and submitted a PR (1814). *Implementation / Usage details* /metrics is still supported against Hadoop2 so not using /metrics endpoint. Since all the metricsources have not moved to new metrics API, I added two servlets. a. /prom (PrometheusServlet) uses the new metrics API. b. /prom2 (PrometheusHadoop2Servlet) uses the old hadoop2 metrics API PrometheusHadoop2Servlet can be thrown out once all the metricsources start using the new API. Side note # Most of the servlet code for /prom2 code is cloned from HADOOP-16398 > Prometheus /metrics http endpoint for monitoring integration > > > Key: HBASE-20904 > URL: https://issues.apache.org/jira/browse/HBASE-20904 > Project: HBase > Issue Type: New Feature > Components: metrics, monitoring >Reporter: Hari Sekhon >Priority: Major > > Feature Request to add Prometheus /metrics http endpoint for monitoring > integration: > [https://prometheus.io/docs/prometheus/latest/configuration/configuration/#%3Cscrape_config%3E] > Prometheus metrics format for that endpoint: > [https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120316#comment-17120316 ] Madhusoodan edited comment on HBASE-20904 at 5/30/20, 5:16 PM: --- I have worked on this today and submitted a PR (1814). *Implementation / Usage details* /metrics is still supported against Hadoop2 so not using /metrics endpoint. Since all the metricsources have not moved to new metrics API, I added two servlets. a. /prom (PrometheusServlet) uses the new metrics API. b. /prom2 (PrometheusHadoop2Servlet) uses the old hadoop2 metrics API PrometheusHadoop2Servlet can be thrown out once all the metricsources start using the new API. Side note # Most of the servlet code for /prom2 code is cloned from HADOOP-16398 was (Author: mmpataki): I have worked on this today and submitted a PR (1814). *Implementation* Since all the metricsources have not moved to new metrics API, I added two servlets. a. /prom (PrometheusServlet) uses the new metrics API. b. /prom2 (PrometheusHadoop2Servlet) uses the old hadoop2 metrics API PrometheusHadoop2Servlet can be thrown out once all the metricsources start using the new API. Side note # Most of the servlet code for /prom2 code is cloned from HADOOP-16398 > Prometheus /metrics http endpoint for monitoring integration > > > Key: HBASE-20904 > URL: https://issues.apache.org/jira/browse/HBASE-20904 > Project: HBase > Issue Type: New Feature > Components: metrics, monitoring >Reporter: Hari Sekhon >Priority: Major > > Feature Request to add Prometheus /metrics http endpoint for monitoring > integration: > [https://prometheus.io/docs/prometheus/latest/configuration/configuration/#%3Cscrape_config%3E] > Prometheus metrics format for that endpoint: > [https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md] > -- This message was sent by Atlassian Jira (v8.3.4#803005)