[ 
https://issues.apache.org/jira/browse/HBASE-23107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949279#comment-16949279
 ] 

Reid Chan edited comment on HBASE-23107 at 10/11/19 8:59 AM:
-------------------------------------------------------------

Ping [~anoop.hbase], would you like to give a review? You have better insights 
over kinds of cache and mem issues.


was (Author: reidchan):
Ping [~anoop.hbase], would you like to give a review? You have better insights 
over this issue.

> Avoid temp byte array creation when doing cacheDataOnWrite
> ----------------------------------------------------------
>
>                 Key: HBASE-23107
>                 URL: https://issues.apache.org/jira/browse/HBASE-23107
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: chenxu
>            Assignee: chenxu
>            Priority: Major
>
> code in HFileBlock.Writer.cloneUncompressedBufferWithHeader
> {code:java}
> ByteBuffer cloneUncompressedBufferWithHeader() {
>   expectState(State.BLOCK_READY);
>   byte[] uncompressedBlockBytesWithHeader = baosInMemory.toByteArray();
>   …
> }
> {code}
> When cacheOnWrite feature enabled, a temp byte array was created in order to 
> copy block’s data, we can avoid this by use of ByteBuffAllocator. This can 
> improve GC performance in write heavy scenarios.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to