[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075032#comment-14075032
]
Hudson commented on HBASE-11388:
FAILURE: Integrated in HBase-0.98 #420 (See
[https://builds.apache.org/job/HBase-0.98/420/])
HBASE-11388 The order parameter is wrong when invoking the constructor of the
(jdcryans: rev abce9ecb4ccc9a797971cf922b316c573d42d92e)
*
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.98.5
Attachments: HBASE_11388.patch, HBASE_11388_trunk_V1.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075168#comment-14075168
]
Hudson commented on HBASE-11388:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #399 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/399/])
HBASE-11388 The order parameter is wrong when invoking the constructor of the
(jdcryans: rev abce9ecb4ccc9a797971cf922b316c573d42d92e)
*
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.98.5
Attachments: HBASE_11388.patch, HBASE_11388_trunk_V1.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073829#comment-14073829
]
Hadoop QA commented on HBASE-11388:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12653824/HBASE_11388_trunk_V1.patch
against trunk revision .
ATTACHMENT ID: 12653824
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10182//console
This message is automatically generated.
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0, 0.98.5
Attachments: HBASE_11388.patch, HBASE_11388_trunk_V1.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073937#comment-14073937
]
Qianxi Zhang commented on HBASE-11388:
--
[~jdcryans] ok, I will do it.
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0, 0.98.5
Attachments: HBASE_11388.patch, HBASE_11388_trunk_V1.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073962#comment-14073962
]
Qianxi Zhang commented on HBASE-11388:
--
[~jdcryans] I think the new trunk has fixed this bug, so we could close this
issue.
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0, 0.98.5
Attachments: HBASE_11388.patch, HBASE_11388_trunk_V1.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051435#comment-14051435
]
Qianxi Zhang commented on HBASE-11388:
--
Thanks [~jdcryans] . I resubmitted the patch.
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0, 0.98.5
Attachments: HBASE_11388.patch, HBASE_11388_trunk_V1.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042089#comment-14042089
]
Qianxi Zhang commented on HBASE-11388:
--
[~jdcryans] I think about your idea, I think we should not delete clusterKey
which is an attribute of the ReplicationPeer. The others could invoke the
getClusterKey method to get it though we can infer it using
ZKUtil#getZooKeeperClusterKey(), but I think this is more reasonable. Pls
correct me if am wrong.
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE_11388.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042287#comment-14042287
]
Jean-Daniel Cryans commented on HBASE-11388:
Ah, sorry, I wasn't clear. I was thinking that we should only remove it from
the constructor, but then populate that field within the constructor using
getZooKeeperClusterKey.
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE_11388.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040977#comment-14040977
]
Jean-Daniel Cryans commented on HBASE-11388:
Wow nice one [~qianxiZhang], I'm surprised that things even work but it looks
like we don't do anything useful with clusterKey in ReplicationPeer, we just
use the configuration. I think a better interface would be to just remove the
passing of the clusterKey in ReplicationPeer's constructor since we can infer
it using ZKUtil#getZooKeeperClusterKey().
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE_11388.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041597#comment-14041597
]
Qianxi Zhang commented on HBASE-11388:
--
thanks [~jdcryans]. That is a good idea, and I will do it.
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE_11388.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039647#comment-14039647
]
Ted Yu commented on HBASE-11388:
[~jdcryans]:
Can you take a look ?
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE_11388.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039651#comment-14039651
]
Qianxi Zhang commented on HBASE-11388:
--
[~tedyu] Sorry, I do not understand what you mean. Is that about this issue?
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE_11388.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039653#comment-14039653
]
Ted Yu commented on HBASE-11388:
J-D is familiar with this code.
That's why I asked him to take a look.
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE_11388.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039656#comment-14039656
]
Qianxi Zhang commented on HBASE-11388:
--
ok thanks [~tedyu]
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE_11388.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
[
https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039681#comment-14039681
]
Hadoop QA commented on HBASE-11388:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651663/HBASE_11388.patch
against trunk revision .
ATTACHMENT ID: 12651663
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9815//console
This message is automatically generated.
The order parameter is wrong when invoking the constructor of the
ReplicationPeer In the method getPeer of the class ReplicationPeersZKImpl
-
Key: HBASE-11388
URL: https://issues.apache.org/jira/browse/HBASE-11388
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.99.0, 0.98.3
Reporter: Qianxi Zhang
Assignee: Qianxi Zhang
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE_11388.patch
The parameters is Configurationi, ClusterKey and id in the constructor
of the class ReplicationPeer. But he order parameter is Configurationi,
id and ClusterKey when invoking the constructor of the ReplicationPeer In
the method getPeer of the class ReplicationPeersZKImpl
ReplicationPeer#76
{code}
public ReplicationPeer(Configuration conf, String key, String id) throws
ReplicationException {
this.conf = conf;
this.clusterKey = key;
this.id = id;
try {
this.reloadZkWatcher();
} catch (IOException e) {
throw new ReplicationException(Error connecting to peer cluster with
peerId= + id, e);
}
}
{code}
ReplicationPeersZKImpl#498
{code}
ReplicationPeer peer =
new ReplicationPeer(peerConf, peerId,
ZKUtil.getZooKeeperClusterKey(peerConf));
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
