[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281980#comment-15281980 ] Sean Busbey commented on HBASE-13706: - I'm still trying to chase down HBASE-15698; I presumed it would be a problem with any phoenix-on-hbase-1.2 work? > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281975#comment-15281975 ] Li Lu commented on HBASE-13706: --- Yes that would be helpful. Thanks! > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281974#comment-15281974 ] Sangjin Lee commented on HBASE-13706: - I suspect that could work. cc [~gtCarrera9] > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281286#comment-15281286 ] James Taylor commented on HBASE-13706: -- When do you need it, [~sjlee0]? We plan to do a 4.8 release before May 24th. If that's not soon enough, we could potentially do a 4.7.1 release that supports HBase 1.2. > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281070#comment-15281070 ] Andrew Purtell commented on HBASE-13706: [~giacomotay...@gmail.com] ? > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281050#comment-15281050 ] Sangjin Lee commented on HBASE-13706: - Yes, that's what I heard too. I guess the question is how soon Phoenix 4.8 will be released as that may become a blocker for us to merge into the hadoop trunk... > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281039#comment-15281039 ] Andrew Purtell commented on HBASE-13706: bq. The YARN timeline service feature also has a dependency on Phoenix, and it appears Phoenix is not yet ready to pick up 1.2.x? There are a couple of minor issues with small API changes between 1.1 and 1.2 but I bet the next release of Phoenix (4.8) will support 1.2. > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281033#comment-15281033 ] Sangjin Lee commented on HBASE-13706: - I thought Nick was not comfortable with backporting HBASE-15686, but I didn't read that he was uncomfortable with backporting this JIRA. The YARN timeline service feature also has a dependency on Phoenix, and it appears Phoenix is not yet ready to pick up 1.2.x? [~enis]? > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281026#comment-15281026 ] Jerry He commented on HBASE-13706: -- Posted concurrently with [~enis] :-) > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281022#comment-15281022 ] Jerry He commented on HBASE-13706: -- Hi, [~sjlee0] [~ndimiduk] is the man for 1.1.x line. But I recall he had expressed his opinion for a backport in a comment on HBASE-15686. > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281016#comment-15281016 ] Enis Soztutar commented on HBASE-13706: --- [~ndimiduk] our friends at YARN needs either this jira or HBASE-15686 to be backported to 1.1, so that they can use HBase-1.1.x lines (phoenix-4.8.0 is not out yet). Which one should we backport? This is for YARN-5070. > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280870#comment-15280870 ] Sangjin Lee commented on HBASE-13706: - I asked in another JIRA, but is there appetite in porting this to the 1.1.x line? Thanks! > CoprocessorClassLoader should not exempt Hive classes > - > > Key: HBASE-13706 > URL: https://issues.apache.org/jira/browse/HBASE-13706 > Project: HBase > Issue Type: Bug > Components: Coprocessors >Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 >Reporter: Jerry He >Assignee: Jerry He >Priority: Minor > Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 > > Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, > HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch > > > CoprocessorClassLoader is used to load classes from the coprocessor jar. > Certain classes are exempt from being loaded by this ClassLoader, which means > they will be ignored in the coprocessor jar, but loaded from parent classpath > instead. > One problem is that we categorically exempt "org.apache.hadoop". > But it happens that Hive packages start with "org.apache.hadoop". > There is no reason to exclude hive classes from theCoprocessorClassLoader. > HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695741#comment-14695741 ] Jerry He commented on HBASE-13706: -- Committed to 0.98 CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696277#comment-14696277 ] Hudson commented on HBASE-13706: FAILURE: Integrated in HBase-0.98 #1082 (See [https://builds.apache.org/job/HBase-0.98/1082/]) HBASE-13706 CoprocessorClassLoader should not exempt Hive classes (jerryjch: rev 9e720ef07727def36d65815180cc9768d4f9c6b7) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/CoprocessorClassLoader.java CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696474#comment-14696474 ] Hudson commented on HBASE-13706: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1035 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1035/]) HBASE-13706 CoprocessorClassLoader should not exempt Hive classes (jerryjch: rev 9e720ef07727def36d65815180cc9768d4f9c6b7) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/CoprocessorClassLoader.java CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.2.0, 1.3.0 Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692819#comment-14692819
]
Hadoop QA commented on HBASE-13706:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749963/HBASE-13706-0.98.patch
against 0.98 branch at commit a78e6e94994aaba2bee7747054ea9a55f1edd421.
ATTACHMENT ID: 12749963
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
22 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn post-site goal
to fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15063//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15063//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15063//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15063//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15063//console
This message is automatically generated.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-13706-0.98.patch, HBASE-13706-branch-1.patch,
HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680837#comment-14680837 ] Andrew Purtell commented on HBASE-13706: Thanks Jerry, that will work CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680811#comment-14680811 ] Andrew Purtell commented on HBASE-13706: +1 for 0.98 CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680830#comment-14680830 ] Jerry He commented on HBASE-13706: -- I will do a quick Phoenix sample test against HBase 1.1 with the fix. I happen to have phoenix-4.4.0-HBase-1.1-server.jar in my hbase lib. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681044#comment-14681044
]
Jerry He commented on HBASE-13706:
--
I tested both the branch-1 version of the patch and the master version of the
patches with Phoenix. Note these two versions are different changes, with the
master version more dramatic.
{noformat}
[biadmin@bdvs1163 bin]$ ./sqlline.py localhost:2181:/hbase-unsecure
../examples/STOCK_SYMBOL.sql
Setting property: [isolation, TRANSACTION_READ_COMMITTED]
Setting property: [run, ../examples/STOCK_SYMBOL.sql]
issuing: !connect jdbc:phoenix:localhost:2181:/hbase-unsecure none none
org.apache.phoenix.jdbc.PhoenixDriver
Connecting to jdbc:phoenix:localhost:2181:/hbase-unsecure
SLF4J: Failed to load class org.slf4j.impl.StaticLoggerBinder.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
15/08/10 16:46:40 WARN util.NativeCodeLoader: Unable to load native-hadoop
library for your platform... using builtin-java classes where applicable
Connected to: Phoenix (version 4.4)
Driver: PhoenixEmbeddedDriver (version 4.4)
Autocommit status: true
Transaction isolation: TRANSACTION_READ_COMMITTED
Building list of tables and columns for tab-completion (set fastconnect to true
to skip)...
94/94 (100%) Done
Done
1/4 CREATE TABLE IF NOT EXISTS STOCK_SYMBOL (SYMBOL VARCHAR NOT NULL
PRIMARY KEY, COMPANY VARCHAR);
No rows affected (0.281 seconds)
2/4 UPSERT INTO STOCK_SYMBOL VALUES ('CRM','SalesForce.com');
1 row affected (0.055 seconds)
3/4 SELECT * FROM STOCK_SYMBOL;
+--+--+
| SYMBOL | COMPANY
|
+--+--+
| CRM | SalesForce.com
|
+--+--+
1 row selected (0.195 seconds)
4/4
Closing: org.apache.phoenix.jdbc.PhoenixConnection
sqlline version 1.1.8
{noformat}
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch,
HBASE-13706-master-v2.patch, HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681054#comment-14681054 ] Jerry He commented on HBASE-13706: -- Also looked at the hbase region server logs. No errors or exceptions there. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681057#comment-14681057 ] Andrew Purtell commented on HBASE-13706: +1 for commit CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663300#comment-14663300 ] Hudson commented on HBASE-13706: FAILURE: Integrated in HBase-1.3 #97 (See [https://builds.apache.org/job/HBase-1.3/97/]) HBASE-13706 CoprocessorClassLoader should not exempt Hive classes (jerryjch: rev d322ebadf5cf8ab16cf3e4489188ced54a38ef0e) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/CoprocessorClassLoader.java CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663305#comment-14663305 ] Hudson commented on HBASE-13706: FAILURE: Integrated in HBase-1.2 #98 (See [https://builds.apache.org/job/HBase-1.2/98/]) HBASE-13706 CoprocessorClassLoader should not exempt Hive classes (jerryjch: rev a4c08f63045b2ccc983a6fb45614d09f7b47c3bc) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/CoprocessorClassLoader.java CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14669879#comment-14669879 ] Hudson commented on HBASE-13706: SUCCESS: Integrated in HBase-1.2-IT #81 (See [https://builds.apache.org/job/HBase-1.2-IT/81/]) HBASE-13706 CoprocessorClassLoader should not exempt Hive classes (jerryjch: rev a4c08f63045b2ccc983a6fb45614d09f7b47c3bc) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/CoprocessorClassLoader.java CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14669882#comment-14669882 ] Hudson commented on HBASE-13706: SUCCESS: Integrated in HBase-1.3-IT #79 (See [https://builds.apache.org/job/HBase-1.3-IT/79/]) HBASE-13706 CoprocessorClassLoader should not exempt Hive classes (jerryjch: rev d322ebadf5cf8ab16cf3e4489188ced54a38ef0e) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/CoprocessorClassLoader.java CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662886#comment-14662886
]
Hadoop QA commented on HBASE-13706:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749405/HBASE-13706-branch-1.patch
against branch-1 branch at commit d4fc7cf2ba0d06b040dad435ab72366c4fd44116.
ATTACHMENT ID: 12749405
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15010//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15010//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15010//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15010//console
This message is automatically generated.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch,
HBASE-13706-master-v2.patch, HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663265#comment-14663265 ] Jerry He commented on HBASE-13706: -- master-v2 patch has been committed to master branch. I also committed branch-1 version of the patch to branch-1 and branch-1.2. I will add a release note. Thanks for the review, [~apurtell]. Do you want it in 0.98? It will be the same as the branch-1 version of the patch. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662710#comment-14662710
]
Hadoop QA commented on HBASE-13706:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749346/HBASE-13706-branch-1.patch
against branch-1 branch at commit f1c1692d511f72ba0bef42e22d27098c25bd10d9.
ATTACHMENT ID: 12749346
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15005//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15005//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15005//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15005//console
This message is automatically generated.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch,
HBASE-13706-master-v2.patch, HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662620#comment-14662620 ] Hudson commented on HBASE-13706: FAILURE: Integrated in HBase-TRUNK #6704 (See [https://builds.apache.org/job/HBase-TRUNK/6704/]) HBASE-13706 CoprocessorClassLoader should not exempt Hive classes (jerryjch: rev f1c1692d511f72ba0bef42e22d27098c25bd10d9) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/CoprocessorClassLoader.java CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-branch-1.patch, HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661931#comment-14661931 ] Sean Busbey commented on HBASE-13706: - actually I take that back, I think this would be fine during hte RC process. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 1.2.0, 1.3.0 Attachments: HBASE-13706-master-v2.patch, HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662158#comment-14662158
]
Hadoop QA commented on HBASE-13706:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749284/HBASE-13706-master-v2.patch
against master branch at commit 741783585306e03eec8074841b342ab742cf37e7.
ATTACHMENT ID: 12749284
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14997//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14997//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14997//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14997//console
This message is automatically generated.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-13706-master-v2.patch,
HBASE-13706-master-v2.patch, HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662287#comment-14662287
]
Jerry He commented on HBASE-13706:
--
TestRegionServerHostname is not related. There is no code impact in that area.
It passed in earlier QA run.
I ran the test locally with the patch a few times. It passed fine.
{noformat}
Running org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.757 sec - in
org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
{noformat}
Will commit the master v2 shortly.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-13706-master-v2.patch,
HBASE-13706-master-v2.patch, HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661347#comment-14661347 ] Jerry He commented on HBASE-13706: -- Thanks, [~apurtell] Let me trigger the UT again. They seem to be fine. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.3 Attachments: HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661127#comment-14661127 ] Andrew Purtell commented on HBASE-13706: I'm glad you've taken this up [~jerryhe]. bq. The current way is ambiguous and un-intended? Coprocessors should share with the host env only via clearly defined interfaces. Agreed. Getting there will be a process. It's been that way from the beginning. bq. What about for the other branches? Explicit listing of the hadoop packages? We can try that for branch-1. Could also try for branch-1.2 since 1.2.0 has not been released yet. Depends what [~busbey] thinks. Would not be an appropriate change for 1.0.x or 1.1.x since it's a compatibility concern with other releases in those lines. We could talk about putting it in 0.98. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.3 Attachments: HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661128#comment-14661128 ] Andrew Purtell commented on HBASE-13706: +1 for the v2 patch for master if it passes unit tests CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.3 Attachments: HBASE-13706-master-v2.patch, HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659345#comment-14659345
]
Hadoop QA commented on HBASE-13706:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12748951/HBASE-13706-master-v2.patch
against master branch at commit 18c9bb8b54a5bb101f793e555272cbc74b8288cb.
ATTACHMENT ID: 12748951
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14986//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14986//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14986//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14986//console
This message is automatically generated.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.3
Attachments: HBASE-13706-master-v2.patch, HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659159#comment-14659159
]
Jerry He commented on HBASE-13706:
--
Attached a master-v2 patch.
Are you ok with this one for master branch, [~apurtell]?
What about for the other branches? Explicit listing of the hadoop packages?
{noformat}
org.apache.hadoop.security
org.apache.hadoop.HadoopIllegalArgumentException
org.apache.hadoop.conf
org.apache.hadoop.fs
org.apache.hadoop.http
org.apache.hadoop.io
org.apache.hadoop.ipc
org.apache.hadoop.metrics
org.apache.hadoop.metrics2
org.apache.hadoop.net
org.apache.hadoop.util
org.apache.hadoop.hdfs
{noformat}
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.3
Attachments: HBASE-13706-master-v2.patch, HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654712#comment-14654712 ] Jerry He commented on HBASE-13706: -- bq. If not going through a facade in org.apache.hadoop.hbase.* whatever objects the coprocessor instantiates and interacts with will not have access to static shared state like UGI, the metrics subsystem registry, the FileSystem instance cache, etc. Working with HDFS, metrics, and security APIs would be interesting Good points. Maybe that is the right way?. The current way is ambiguous and un-intended? Coprocessors should share with the host env only via clearly defined interfaces. Yes, we can make the change on the master branch only. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.3 Attachments: HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654548#comment-14654548 ] Andrew Purtell commented on HBASE-13706: bq. no good reason [to exempt the Hadoop classes] bq. The logic will be that all HBase classes and all their dependencies will be loaded by native/parent loader. All co-processor implementation classes and their dependencies will be loaded by the CoprocessorClassLoader, unless they spill over. We could try only org.apache.hadoop.hbase.*. The subset of the Hadoop APIs relevant and useful for coprocessors is pretty big, there could be unexpected/unintended consequences. If not going through a facade in org.apache.hadoop.hbase.* whatever objects the coprocessor instantiates and interacts with will not have access to static shared state like UGI, the metrics subsystem registry, the FileSystem instance cache, etc. Working with HDFS, metrics, and security APIs would be interesting. We could try it only in master for a while. We could claim such things out of scope for coprocessors, but because we haven't up to now, it's a hairy backwards compatibility problem. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.3 Attachments: HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635804#comment-14635804
]
Jerry He commented on HBASE-13706:
--
Hi, [~apurtell]
Thanks for the comment.
This is a list for hadoop common and hdfs I come up with. hadoop version 2.6.0
and HBase version 1.1.1. These packages appear directly in the HBase 'import'
{noformat}
org.apache.hadoop.security
org.apache.hadoop.HadoopIllegalArgumentException
org.apache.hadoop.conf
org.apache.hadoop.fs
org.apache.hadoop.http
org.apache.hadoop.io
org.apache.hadoop.ipc
org.apache.hadoop.metrics
org.apache.hadoop.metrics2
org.apache.hadoop.net
org.apache.hadoop.util
org.apache.hadoop.hdfs
{noformat}
Still, looking at the code further. I think the custom co-processor class
loader is pretty separated from the native class loading. In other words,
classpath isolation is well provided.
This applies to the dependencies as well as the main co-processor class (of
course this requires that the co-processor implementation jar to be
self-contained).
Maybe I am wrong, but I see a good reason to exempt the hadoop classes.
The logic will be that all HBase classes and all their dependencies will be
loaded by native/parent loader.
All co-processor implementation classes and their dependencies will be loaded
by the CoprocessorClassLoader, unless they spill over.
It looks more like a limitation without fully making use of the classpath
isolation provided by co-processor class loader.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.2
Attachments: HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635806#comment-14635806 ] Jerry He commented on HBASE-13706: -- bq. but I see a good reason to exempt the hadoop classes no good reason CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.2 Attachments: HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634180#comment-14634180 ] Andrew Purtell commented on HBASE-13706: bq. Pardon my ignorance on this. No ignorance here that I can detect. (smile) bq. Thinking it a little more, maybe the above list needs to be re-visited? Yes bq. Is there a real need to exempt Hadoop classes? What is special about hadoop packages as dependencies? What are the subpackages we really need to exempt? I can understand why we want to use the parent classloader to load HBase classes. I think the idea was to load the common and HDFS classes that the HBase classes depend from the same source using the parent classloader. We could refine the whitelist to be more specific to actual dependencies in that case. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.2 Attachments: HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632632#comment-14632632
]
Jerry He commented on HBASE-13706:
--
This is the current 'whitelist' for exemption:
{code}
/**
* If the class being loaded starts with any of these strings, we will skip
* trying to load it from the coprocessor jar and instead delegate
* directly to the parent ClassLoader.
*/
private static final String[] CLASS_PREFIX_EXEMPTIONS = new String[] {
// Java standard library:
com.sun.,
launcher.,
java.,
javax.,
org.ietf,
org.omg,
org.w3c,
org.xml,
sunw.,
// logging
org.apache.commons.logging,
org.apache.log4j,
com.hadoop,
// Hadoop/HBase/ZK:
org.apache.hadoop,
org.apache.zookeeper,
};
{code}
My thinking was that org.apache.hadoop in the above list happens to include
'org.apache.hadoop.hive', which is a mistake.
But if I want to go deeper and expand org.apache.hadoop to whitelist its
relevant subpackages, it gets pretty messy. For example, hadoop-common has
multiple subpackages that are not very uniformly named.
Thinking it a little more, maybe the above list needs to be re-visited?
Is there a real need to exempt Hadoop classes? What is special about hadoop
packages as dependencies? What are the subpackages we really need to exempt?
I can understand why we want to use the parent classloader to load HBase
classes.
Say if a co-processor implementation has to use a different hadoop version,
will it cause trouble on the server side? The co-processor jar bundles the
hadoop jar. The hadoop classes of different version used by the co-processor
would be loaded by CoprocessorClassLoader.
Pardon my ignorance on this.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.2
Attachments: HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631833#comment-14631833 ] Jerry He commented on HBASE-13706: -- Hi, [~apurtell] Does the patch look ok to you? Any comment? CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Assignee: Jerry He Priority: Minor Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.2 Attachments: HBASE-13706.patch CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632144#comment-14632144
]
Andrew Purtell commented on HBASE-13706:
I think the current patch has the wrong approach. That's what I was getting at
when I said
bq. HBase doesn't know anything about Hive, nor should it.
Here we have
{code}
+ private static final String[] CLASS_PREFIX_NO_EXEMPTION = new String[] {
+org.apache.hadoop.hive
+ };
{code}
What makes this package name special? What about the potentially infinite other
variations of org.apache.* that are not the Hadoop and HBase classes we only
want to exempt?
We should whitelist packages for exemption. This whitelist is something we can
maintain. The inverse is such a large space it's inherently unmaintainable.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.2
Attachments: HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[
https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627587#comment-14627587
]
Hadoop QA commented on HBASE-13706:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12745367/HBASE-13706.patch
against master branch at commit 2f327c911056d02813f642503db9a4383e8b4a2f.
ATTACHMENT ID: 12745367
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14775//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14775//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14775//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14775//console
This message is automatically generated.
CoprocessorClassLoader should not exempt Hive classes
-
Key: HBASE-13706
URL: https://issues.apache.org/jira/browse/HBASE-13706
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.1.2
Attachments: HBASE-13706.patch
CoprocessorClassLoader is used to load classes from the coprocessor jar.
Certain classes are exempt from being loaded by this ClassLoader, which means
they will be ignored in the coprocessor jar, but loaded from parent classpath
instead.
One problem is that we categorically exempt org.apache.hadoop.
But it happens that Hive packages start with org.apache.hadoop.
There is no reason to exclude hive classes from theCoprocessorClassLoader.
HBase does not even include Hive jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627314#comment-14627314 ] Andrew Purtell commented on HBASE-13706: Oh, I see, 'org.apache.*'. Of course, sorry. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Priority: Minor CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627276#comment-14627276 ] Jerry He commented on HBASE-13706: -- Hi, [~apurtell] bq. We shouldn't be exempting foreign classes in our classloader. HBase doesn't know anything about Hive, nor should it. Exactly. Here is an example. In my coprocessor implementation jar, I have org.apache.hadoop.hive classes embedded. But the CoprocessorClassLoader will exempt/skip these classes when loading the coprocessor implementation jar, which is not right. I will get a patch ... simple patch. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Priority: Minor CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625107#comment-14625107 ] Andrew Purtell commented on HBASE-13706: bq. We have a case where hive classes are used in the coprocessor jar. coprocessor would fail to load unless we explore other approaches. e.g copy the Hive jars into HBase lib or shade the Hive classes. We shouldn't be exempting foreign classes in our classloader. HBase doesn't know anything about Hive, nor should it. Since you've identified two solutions that do not involve code changes to HBase, I'm going to close this as Not A Problem. Reopen if you disagree. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Priority: Minor CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13706) CoprocessorClassLoader should not exempt Hive classes
[ https://issues.apache.org/jira/browse/HBASE-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14548353#comment-14548353 ] Jerry He commented on HBASE-13706: -- We have a case where hive classes are used in the coprocessor jar. coprocessor would fail to load unless we explore other approaches. e.g copy the Hive jars into HBase lib or shade the Hive classes. CoprocessorClassLoader should not exempt Hive classes - Key: HBASE-13706 URL: https://issues.apache.org/jira/browse/HBASE-13706 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12 Reporter: Jerry He Priority: Minor CoprocessorClassLoader is used to load classes from the coprocessor jar. Certain classes are exempt from being loaded by this ClassLoader, which means they will be ignored in the coprocessor jar, but loaded from parent classpath instead. One problem is that we categorically exempt org.apache.hadoop. But it happens that Hive packages start with org.apache.hadoop. There is no reason to exclude hive classes from theCoprocessorClassLoader. HBase does not even include Hive jars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
