[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721734#comment-15721734 ] Hudson commented on HBASE-14882: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2076 (See

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721667#comment-15721667 ] Xiang Li commented on HBASE-14882: -- Anoop, many thanks for your guide and patience! Really appreciate

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721480#comment-15721480 ] Anoop Sam John commented on HBASE-14882: bq.When calculating heapOverhead(), I think I can not

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721156#comment-15721156 ] Hadoop QA commented on HBASE-14882: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721141#comment-15721141 ] Xiang Li commented on HBASE-14882: -- [~anoop.hbase] I uploaded the patch 005 for master branch, to

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715402#comment-15715402 ] Anoop Sam John commented on HBASE-14882: 1. Pls see ValueAndTagRewriteCell and how this write is

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715001#comment-15715001 ] Xiang Li commented on HBASE-14882: -- Hi [~anoop.hbase], thanks for the your time and comments! May I ask

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712007#comment-15712007 ] Anoop Sam John commented on HBASE-14882: Thanks for the continuous effort here. This took much

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711216#comment-15711216 ] Hadoop QA commented on HBASE-14882: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711187#comment-15711187 ] Xiang Li commented on HBASE-14882: -- Hi [~anoop.hbase] I uploaded patch 004 for master and triggered

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695461#comment-15695461 ] Anoop Sam John commented on HBASE-14882: #1 - Oh ya the state var name might have changed over

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695409#comment-15695409 ] Xiang Li commented on HBASE-14882: -- Hi [~anoop.hbase], thanks for the explanation! 2 more questions...

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692623#comment-15692623 ] Anoop Sam John commented on HBASE-14882: U can use KeyValueUtil#appendToByteArray > Provide a

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686240#comment-15686240 ] Xiang Li commented on HBASE-14882: -- Hi [~anoop.hbase] When implementing ExtendedCell interface for

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666234#comment-15666234 ] Anoop Sam John commented on HBASE-14882: checkParameters() - Ya u can make it non private. May

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665951#comment-15665951 ] Xiang Li commented on HBASE-14882: -- [~anoop.hbase] In keyValue, may I propose to set the following 2

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658804#comment-15658804 ] Xiang Li commented on HBASE-14882: -- Hi Anoop, I see, got your idea. Thanks! I will update the patch to

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656453#comment-15656453 ] Anoop Sam John commented on HBASE-14882: So now we clearly know, why this API is not client end

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656231#comment-15656231 ] Anoop Sam John commented on HBASE-14882: Sorry missed this some how. Will look at the latest

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655802#comment-15655802 ] Xiang Li commented on HBASE-14882: -- [~anoop.hbase] Would you please help to review patch 003 when you

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650466#comment-15650466 ] Hadoop QA commented on HBASE-14882: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647093#comment-15647093 ] Xiang Li commented on HBASE-14882: -- Hi [~anoop.hbase] After testing almost all code paths (sorry it

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516752#comment-15516752 ] Xiang Li commented on HBASE-14882: -- The following 2 Put#addImmutable() are updated by the patch {code}

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509533#comment-15509533 ] Anoop Sam John commented on HBASE-14882: I mean within HBase code base, where all

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509299#comment-15509299 ] Xiang Li commented on HBASE-14882: -- Hi [~anoop.hbase], I uploaded patch 002 for master. Please review.

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503978#comment-15503978 ] Hadoop QA commented on HBASE-14882: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503868#comment-15503868 ] Xiang Li commented on HBASE-14882: -- Hi Anoop, I re-uploaded patch 002. It failed when I tried to

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503855#comment-15503855 ] Anoop Sam John commented on HBASE-14882: bq.I uploaded patch version 002 for master, You forgot

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503808#comment-15503808 ] Xiang Li commented on HBASE-14882: -- [~anoop.hbase], thanks very much for the explanations! I uploaded

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483085#comment-15483085 ] Anoop Sam John commented on HBASE-14882: Thanks for the tests.. 1. Ya ideally those interfaces

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476403#comment-15476403 ] Xiang Li commented on HBASE-14882: -- Hi [~anoop.hbase], I have some questions, could you please take a

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470985#comment-15470985 ] Jerry He commented on HBASE-14882: -- +1 on IndividualBytesFieldCell Yes, Better to change the Type field

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470913#comment-15470913 ] Anoop Sam John commented on HBASE-14882: This is not a KeyValue kind of structure.. So no ame

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470423#comment-15470423 ] Xiang Li commented on HBASE-14882: -- Hi Jerry, Anoop, what about "SeparateKeyFieldKeyValue" ? > Provide

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469330#comment-15469330 ] Xiang Li commented on HBASE-14882: -- [~anoop.hbase], what about "ImmutableKeyFieldCell" or

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463870#comment-15463870 ] Anoop Sam John commented on HBASE-14882: [~tedyu], [~enis] Any suggestion for the new class

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463868#comment-15463868 ] Anoop Sam John commented on HBASE-14882: InputsImmutableCell -> I dont think this reflect the

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15461258#comment-15461258 ] Xiang Li commented on HBASE-14882: -- [~enis], thanks for the comments! [~anoop.hbase] and [~enis]: The

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439189#comment-15439189 ] Hudson commented on HBASE-14882: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1485 (See

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438876#comment-15438876 ] Anoop Sam John commented on HBASE-14882: Sorry did not see ur comment.. I will revert and reopen

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438870#comment-15438870 ] Enis Soztutar commented on HBASE-14882: --- Can we please extract the Cell implementation out of the

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438861#comment-15438861 ] Anoop Sam John commented on HBASE-14882: Thanks for the study and confirm. :-) Ya I was thinking

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438826#comment-15438826 ] Xiang Li commented on HBASE-14882: -- [~anoop.hbase] bq. Any implication on class loading of the anonymous

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432991#comment-15432991 ] Xiang Li commented on HBASE-14882: -- Patch 001 for master branch is uploaded to address the comment 2 and

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432910#comment-15432910 ] Xiang Li commented on HBASE-14882: -- [~anoop.hbase], thanks for the comments! 1. Regarding bq. Why not

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430104#comment-15430104 ] Anoop Sam John commented on HBASE-14882: Why not handling this API ? addImmutable(byte [] family,

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429564#comment-15429564 ] Xiang Li commented on HBASE-14882: -- [~anoop.hbase] Would you please do me a favor to review the patch?

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418890#comment-15418890 ] Hadoop QA commented on HBASE-14882: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418821#comment-15418821 ] Xiang Li commented on HBASE-14882: -- Hi [~anoop.hbase], I uploaded patch 000 for master branch and the

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417487#comment-15417487 ] Xiang Li commented on HBASE-14882: -- Got that, anonymous Cell is a good idea! Thanks stack! > Provide a

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408891#comment-15408891 ] Anoop Sam John commented on HBASE-14882: Ya.. we can make the API such that all passed to be

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408861#comment-15408861 ] Xiang Li commented on HBASE-14882: -- [~enis], thanks for the comment! I was not able to find HBASE-15945

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405566#comment-15405566 ] Xiang Li commented on HBASE-14882: -- [~anoop.hbase], I am drafting the very first patch, something need

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403138#comment-15403138 ] Xiang Li commented on HBASE-14882: -- HI Stack, thanks for the comment! Do you mean to use an anonymous

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383129#comment-15383129 ] Enis Soztutar commented on HBASE-14882: --- Replicate what we have done for our C++ client in

[jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying

[ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383095#comment-15383095 ] stack commented on HBASE-14882: --- Does it need to have a name? Can we not just make an anonymous Cell? >