[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[ https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518517#comment-16518517 ] Sean Busbey commented on HBASE-15887: - (for context, Mac OS X users are stuck with Bash v3) > Report Log Additions and Removals in Builds > --- > > Key: HBASE-15887 > URL: https://issues.apache.org/jira/browse/HBASE-15887 > Project: HBase > Issue Type: New Feature > Components: build >Reporter: Clay B. >Assignee: Clay B. >Priority: Trivial > Attachments: HBASE-15887-v1.txt > > > It would be very nice for the Apache Yetus verifications of HBase patches to > report log item addition and deletions. > This is not my idea but [~mbm] asked if we could modify the personality for > reporting log additions and removals yesterday at an [HBase meetup at Splice > machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw] > presented Apache Yetus for building HBase. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[
https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518513#comment-16518513
]
Sean Busbey commented on HBASE-15887:
-
{code}
363 # create a data structure akin to:
364 # entries='( [error]="0" [error_remove]="0" [error_add]="0"
365 #[debug]="3" [debug_remove]="1" [debug_add]="2" )'
366 entries+=( [${level}_${action% *}]=$(${GREP} -e "^${action#*
}.*LOG.${level}" "${patchfile}" | wc -l)
367 [${level}]+=${entries[${level}_${action% *}]} )
{code}
Use of associative arrays means we'll need Bash 4. IIRC everything we have to
date works with Bash 3. Can we do this without associative arrays? we'll need
to figure out a way to only include it when bash is v4 if not.
> Report Log Additions and Removals in Builds
> ---
>
> Key: HBASE-15887
> URL: https://issues.apache.org/jira/browse/HBASE-15887
> Project: HBase
> Issue Type: New Feature
> Components: build
>Reporter: Clay B.
>Assignee: Clay B.
>Priority: Trivial
> Attachments: HBASE-15887-v1.txt
>
>
> It would be very nice for the Apache Yetus verifications of HBase patches to
> report log item addition and deletions.
> This is not my idea but [~mbm] asked if we could modify the personality for
> reporting log additions and removals yesterday at an [HBase meetup at Splice
> machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw]
> presented Apache Yetus for building HBase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[
https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518510#comment-16518510
]
Sean Busbey commented on HBASE-15887:
-
oh no it doesn't. I've got it backwards. The check here is "do we need to run
this test?" so "0" means "yes" and "1" means "no". The contents of the if block
is "we don't need the test, exit early."
so that block should be
{code}
if ! verify_needed_test hbaselogs; then
return 0
fi
{code}
> Report Log Additions and Removals in Builds
> ---
>
> Key: HBASE-15887
> URL: https://issues.apache.org/jira/browse/HBASE-15887
> Project: HBase
> Issue Type: New Feature
> Components: build
>Reporter: Clay B.
>Assignee: Clay B.
>Priority: Trivial
> Attachments: HBASE-15887-v1.txt
>
>
> It would be very nice for the Apache Yetus verifications of HBase patches to
> report log item addition and deletions.
> This is not my idea but [~mbm] asked if we could modify the personality for
> reporting log additions and removals yesterday at an [HBase meetup at Splice
> machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw]
> presented Apache Yetus for building HBase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[
https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518507#comment-16518507
]
Sean Busbey commented on HBASE-15887:
-
sorry, missed this bit:
{quote}
I needed to change line 353:
{code}
verify_needed_test hbaselogs
if [[ $? == 0 ]]; then
{code}
To:
{code}
if [[ $? == 1 ]]; then
{code}
In order for the hbaselogs check to run. I suspect I am missing how to tell
Yetus to run things properly but this inequality seemingly set to not run a
test if it is verified needed is how the other tests are implemented.
{quote}
The [docs for
verify_needed_test|http://yetus.apache.org/documentation/0.7.0/precommit-apidocs/core/#verify_needed_test]
definitely says 0 should be correct. lemme dig in a bit.
> Report Log Additions and Removals in Builds
> ---
>
> Key: HBASE-15887
> URL: https://issues.apache.org/jira/browse/HBASE-15887
> Project: HBase
> Issue Type: New Feature
> Components: build
>Reporter: Clay B.
>Assignee: Clay B.
>Priority: Trivial
> Attachments: HBASE-15887-v1.txt
>
>
> It would be very nice for the Apache Yetus verifications of HBase patches to
> report log item addition and deletions.
> This is not my idea but [~mbm] asked if we could modify the personality for
> reporting log additions and removals yesterday at an [HBase meetup at Splice
> machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw]
> presented Apache Yetus for building HBase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[
https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518506#comment-16518506
]
Sean Busbey commented on HBASE-15887:
-
{quote}
Lastly, I do not print out the log lines as I am doing a rather crude grep for
LOG. entries right now which look pretty gnarly. However, I would like
to see this go to Yetus and use something like Eclipse's AST support to
properly find log entry parameters and calls.
{quote}
We could also switch to pre/post checking of the files that are marked as
changing in the patch. then the grep would result in getting file names and
lines. I don't think that's needed for this to be incrementally useful though.
Maybe though? I feel like every time we add a test we get to "this should log a
file" and then "that file should be in the qabot footer" in short order. How
much time are you up for putting into this up front vs later down the line as
follow-ons?
> Report Log Additions and Removals in Builds
> ---
>
> Key: HBASE-15887
> URL: https://issues.apache.org/jira/browse/HBASE-15887
> Project: HBase
> Issue Type: New Feature
> Components: build
>Reporter: Clay B.
>Assignee: Clay B.
>Priority: Trivial
> Attachments: HBASE-15887-v1.txt
>
>
> It would be very nice for the Apache Yetus verifications of HBase patches to
> report log item addition and deletions.
> This is not my idea but [~mbm] asked if we could modify the personality for
> reporting log additions and removals yesterday at an [HBase meetup at Splice
> machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw]
> presented Apache Yetus for building HBase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[
https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518504#comment-16518504
]
Sean Busbey commented on HBASE-15887:
-
{code}
352 verify_needed_test hbaselogs
353 if [[ $? == 0 ]]; then
354 return 0
355 fi
{code}
this should just check the function directly, i.e.
{code}
if verify_needed_test hbaselogs; then
{code}
> Report Log Additions and Removals in Builds
> ---
>
> Key: HBASE-15887
> URL: https://issues.apache.org/jira/browse/HBASE-15887
> Project: HBase
> Issue Type: New Feature
> Components: build
>Reporter: Clay B.
>Assignee: Clay B.
>Priority: Trivial
> Attachments: HBASE-15887-v1.txt
>
>
> It would be very nice for the Apache Yetus verifications of HBase patches to
> report log item addition and deletions.
> This is not my idea but [~mbm] asked if we could modify the personality for
> reporting log additions and removals yesterday at an [HBase meetup at Splice
> machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw]
> presented Apache Yetus for building HBase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[ https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518498#comment-16518498 ] Sean Busbey commented on HBASE-15887: - Generally I like starting stuff here in HBase and then moving it to Yetus once we get to kick the tires a bit. Let me make sure I understand the test rationale. The test will essentially be indifferent to "logs didn't appear to change" and will approve of "logs changed" wether they were additions or removals? > Report Log Additions and Removals in Builds > --- > > Key: HBASE-15887 > URL: https://issues.apache.org/jira/browse/HBASE-15887 > Project: HBase > Issue Type: New Feature > Components: build >Reporter: Clay B. >Priority: Trivial > Attachments: HBASE-15887-v1.txt > > > It would be very nice for the Apache Yetus verifications of HBase patches to > report log item addition and deletions. > This is not my idea but [~mbm] asked if we could modify the personality for > reporting log additions and removals yesterday at an [HBase meetup at Splice > machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw] > presented Apache Yetus for building HBase. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[
https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516455#comment-16516455
]
Hadoop QA commented on HBASE-15887:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.7.0/precommit-patchnames for
instructions. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s{color}
| {color:red} HBASE-15887 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-15887 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806010/HBASE-15887-v1.txt |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13306/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Report Log Additions and Removals in Builds
> ---
>
> Key: HBASE-15887
> URL: https://issues.apache.org/jira/browse/HBASE-15887
> Project: HBase
> Issue Type: New Feature
> Components: build
>Reporter: Clay B.
>Priority: Trivial
> Attachments: HBASE-15887-v1.txt
>
>
> It would be very nice for the Apache Yetus verifications of HBase patches to
> report log item addition and deletions.
> This is not my idea but [~mbm] asked if we could modify the personality for
> reporting log additions and removals yesterday at an [HBase meetup at Splice
> machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw]
> presented Apache Yetus for building HBase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[ https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516454#comment-16516454 ] Hadoop QA commented on HBASE-15887: --- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HBASE-Build/13306/console in case of problems. > Report Log Additions and Removals in Builds > --- > > Key: HBASE-15887 > URL: https://issues.apache.org/jira/browse/HBASE-15887 > Project: HBase > Issue Type: New Feature > Components: build >Reporter: Clay B. >Priority: Trivial > Attachments: HBASE-15887-v1.txt > > > It would be very nice for the Apache Yetus verifications of HBase patches to > report log item addition and deletions. > This is not my idea but [~mbm] asked if we could modify the personality for > reporting log additions and removals yesterday at an [HBase meetup at Splice > machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw] > presented Apache Yetus for building HBase. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[ https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516451#comment-16516451 ] Clay B. commented on HBASE-15887: - [~busbey] ping again; too hacky or better for Yetus > Report Log Additions and Removals in Builds > --- > > Key: HBASE-15887 > URL: https://issues.apache.org/jira/browse/HBASE-15887 > Project: HBase > Issue Type: New Feature > Components: build >Reporter: Clay B. >Priority: Trivial > Attachments: HBASE-15887-v1.txt > > > It would be very nice for the Apache Yetus verifications of HBase patches to > report log item addition and deletions. > This is not my idea but [~mbm] asked if we could modify the personality for > reporting log additions and removals yesterday at an [HBase meetup at Splice > machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw] > presented Apache Yetus for building HBase. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[
https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311226#comment-15311226
]
Hadoop QA commented on HBASE-15887:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 5s
{color} | {color:blue} Precommit patch detected. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for
instructions. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 3s
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 6s
{color} | {color:red} The applied patch generated 1 new + 416 unchanged - 0
fixed = 417 total (was 416) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 29s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 35m 6s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12806010/HBASE-15887-v1.txt |
| JIRA Issue | HBASE-15887 |
| Optional Tests | asflicense shellcheck shelldocs |
| uname | Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / cbb95cd |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider
upgrading.) |
| shellcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/2084/artifact/patchprocess/diff-patch-shellcheck.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/2084/console |
| Powered by | Apache Yetus 0.2.1 http://yetus.apache.org |
This message was automatically generated.
> Report Log Additions and Removals in Builds
> ---
>
> Key: HBASE-15887
> URL: https://issues.apache.org/jira/browse/HBASE-15887
> Project: HBase
> Issue Type: New Feature
> Components: build
>Affects Versions: master
>Reporter: Clay B.
>Priority: Trivial
> Fix For: master
>
> Attachments: HBASE-15887-v1.txt
>
>
> It would be very nice for the Apache Yetus verifications of HBase patches to
> report log item addition and deletions.
> This is not my idea but [~mbm] asked if we could modify the personality for
> reporting log additions and removals yesterday at an [HBase meetup at Splice
> machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw]
> presented Apache Yetus for building HBase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[ https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311151#comment-15311151 ] Hadoop QA commented on HBASE-15887: --- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HBASE-Build/2084/console in case of problems. > Report Log Additions and Removals in Builds > --- > > Key: HBASE-15887 > URL: https://issues.apache.org/jira/browse/HBASE-15887 > Project: HBase > Issue Type: New Feature > Components: build >Affects Versions: master >Reporter: Clay B. >Priority: Trivial > Fix For: master > > Attachments: HBASE-15887-v1.txt > > > It would be very nice for the Apache Yetus verifications of HBase patches to > report log item addition and deletions. > This is not my idea but [~mbm] asked if we could modify the personality for > reporting log additions and removals yesterday at an [HBase meetup at Splice > machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw] > presented Apache Yetus for building HBase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[ https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311140#comment-15311140 ] Enis Soztutar commented on HBASE-15887: --- [~busbey] want to take a look? > Report Log Additions and Removals in Builds > --- > > Key: HBASE-15887 > URL: https://issues.apache.org/jira/browse/HBASE-15887 > Project: HBase > Issue Type: New Feature > Components: build >Reporter: Clay B. >Priority: Trivial > Attachments: HBASE-15887-v1.txt > > > It would be very nice for the Apache Yetus verifications of HBase patches to > report log item addition and deletions. > This is not my idea but [~mbm] asked if we could modify the personality for > reporting log additions and removals yesterday at an [HBase meetup at Splice > machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw] > presented Apache Yetus for building HBase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15887) Report Log Additions and Removals in Builds
[ https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304981#comment-15304981 ] Matthew Byng-Maddick commented on HBASE-15887: -- So cool!!! :-) > Report Log Additions and Removals in Builds > --- > > Key: HBASE-15887 > URL: https://issues.apache.org/jira/browse/HBASE-15887 > Project: HBase > Issue Type: New Feature > Components: build >Reporter: Clay B. >Priority: Trivial > Attachments: HBASE-15887-v1.txt > > > It would be very nice for the Apache Yetus verifications of HBase patches to > report log item addition and deletions. > This is not my idea but [~mbm] asked if we could modify the personality for > reporting log additions and removals yesterday at an [HBase meetup at Splice > machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as [~aw] > presented Apache Yetus for building HBase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
