[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374906#comment-15374906 ] Hudson commented on HBASE-16093: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1241 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1241/]) HBASE-16093 Fix splits failed before creating daughter regions leave (apurtell: rev 3a6698e878fba7340f506b536d74aa0a13ebe0a2) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0, 1.2.2, 1.1.6, 0.98.21 > > Attachments: HBASE-16093-0.98.patch, HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367049#comment-15367049 ] Nick Dimiduk commented on HBASE-16093: -- [~enis] disabled by default is orthogonal to my concern re: tests. > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0, 1.2.2, 1.1.6 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363383#comment-15363383 ] Enis Soztutar commented on HBASE-16093: --- [~ndimiduk] I think this ONLY affects zk-less assignment. So it should be fine for branch-1.1 backport, since zk-less is not default there. > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0, 1.2.2, 1.1.6 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362813#comment-15362813 ] Andrew Purtell commented on HBASE-16093: I concur. I can look at backporting the change in this patch. > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0, 1.2.2, 1.1.6 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359313#comment-15359313 ] Nick Dimiduk commented on HBASE-16093: -- I'm nervous to commit AM changes to maintenance release lines without a test. [~eclark] you folks have a unit or IT that can repro this reliably? > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0, 1.2.2, 1.1.6 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356252#comment-15356252 ] Hudson commented on HBASE-16093: SUCCESS: Integrated in HBase-1.1-JDK7 #1737 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1737/]) HBASE-16093 Fix splits failed before creating daughter regions leave (busbey: rev 45a6d8403cdaed06133dba6fa74e6f80603d2ba5) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0, 1.2.2, 1.1.6 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356234#comment-15356234 ] Sean Busbey commented on HBASE-16093: - pushed to branch-1.2 and branch-1.1. [~apurtell] it looks like [the same blind "enable parent, disable children" happens in 0.98|https://github.com/apache/hbase/blob/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java#L3796], but I don't have a good enough idea anymore about how things work in 0.98 to know if it matters there. > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0, 1.2.2, 1.1.6 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356083#comment-15356083 ] Hudson commented on HBASE-16093: SUCCESS: Integrated in HBase-1.1-JDK8 #1824 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1824/]) HBASE-16093 Fix splits failed before creating daughter regions leave (busbey: rev 45a6d8403cdaed06133dba6fa74e6f80603d2ba5) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0, 1.2.2, 1.1.6 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351592#comment-15351592 ] Gary Helmling commented on HBASE-16093: --- bq. are we sure this doesn't show up in branch-1.1? There's been some AssignmentManager refactoring between branch-1.1 and branch-1.2, but it looks like branch-1.1 has the same bug. bq. and what's the work around for current users of 1.2.x that run into this? just run hbck? I think "hbase -fixEmptyMetaCells" should fix this. > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348487#comment-15348487 ] Sean Busbey commented on HBASE-16093: - and what's the work around for current users of 1.2.x that run into this? just run hbck? > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347872#comment-15347872 ] Hudson commented on HBASE-16093: SUCCESS: Integrated in HBase-1.3-IT #733 (See [https://builds.apache.org/job/HBase-1.3-IT/733/]) HBASE-16093 Fix splits failed before creating daughter regions leave (eclark: rev 25485d621c220e92b0248f3d57a3b3c529a86e47) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347350#comment-15347350 ] Hudson commented on HBASE-16093: SUCCESS: Integrated in HBase-1.3 #757 (See [https://builds.apache.org/job/HBase-1.3/757/]) HBASE-16093 Fix splits failed before creating daughter regions leave (eclark: rev 25485d621c220e92b0248f3d57a3b3c529a86e47) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347346#comment-15347346 ] Hudson commented on HBASE-16093: SUCCESS: Integrated in HBase-1.4 #241 (See [https://builds.apache.org/job/HBase-1.4/241/]) HBASE-16093 Fix splits failed before creating daughter regions leave (eclark: rev 93d82112f00d44c3ded623354f16d3c062cf51e7) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0, 1.4.0 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[
https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347120#comment-15347120
]
Hadoop QA commented on HBASE-16093:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
7s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
59s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 54s
{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 36s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 6s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 70m 37s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 100m 25s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12812893/HBASE-16093.branch-1.patch
|
| JIRA Issue | HBASE-16093 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-1 / b6e2bc5 |
| Default Java | 1.7.0_80 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346995#comment-15346995 ] Mikhail Antonov commented on HBASE-16093: - +1 for 1.3 > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346974#comment-15346974 ] Elliott Clark commented on HBASE-16093: --- [~mantonov] For 1.3 review > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 1.3.0 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16093) Splits failed before creating daughter regions leave meta inconsistent
[ https://issues.apache.org/jira/browse/HBASE-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346953#comment-15346953 ] Gary Helmling commented on HBASE-16093: --- +1 > Splits failed before creating daughter regions leave meta inconsistent > -- > > Key: HBASE-16093 > URL: https://issues.apache.org/jira/browse/HBASE-16093 > Project: HBase > Issue Type: Bug > Components: master, Region Assignment >Affects Versions: 1.3.0, 1.2.1 >Reporter: Elliott Clark >Priority: Critical > Fix For: 1.3.0 > > Attachments: HBASE-16093.branch-1.patch > > > This is on branch-1 based code only. > Here's the sequence of events. > # A regionserver opens a new region. That regions looks like it should split. > # So the regionserver starts a split transaction. > # Split transaction starts execute > # Split transaction encounters an error in stepsBeforePONR > # Split transaction starts rollback > # Split transaction notifies master that it's rolling back using > HMasterRpcServices#reportRegionStateTransition > # AssignmentManager#onRegionTransition is called with SPLIT_REVERTED > # AssignmentManager#onRegionSplitReverted is called. > # That onlines the parent region and offlines the daughter regions. > However the daughter regions were never created in meta so all that gets done > is that state for those rows gets OFFLINE. Now all clients trying to get the > parent instead get the offline daughter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
