[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576914#comment-15576914 ] Hudson commented on HBASE-16729: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1787 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1787/]) HBASE-16729 Define the behavior of (default) empty FilterList(ChiaPing (ramkrishna: rev 635ea05b9a975c13916148081754fa842adfb54a) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Affects Versions: 2.0.0 >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch, > HBASE-16729.v2.patch, HBASE-16729.v3.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575917#comment-15575917 ] Hadoop QA commented on HBASE-16729: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 56s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 21s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 38s {color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 0s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 50s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 22s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 25s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 39s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 54s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 79m 8s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 122m 13s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.constraint.TestConstraint | | | org.apache.hadoop.hbase.TestNamespace | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12833394/HBASE-16729.v3.patch | | JIRA Issue | HBASE-16729 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 48d7d83022e2 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 3fe7508 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/4017/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | unit |
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575431#comment-15575431 ] ChiaPing Tsai commented on HBASE-16729: --- [~ram_krish] bq. Why is that it is not checked for <=? i will fix it. bq. Should these be public? No, these methods can be private. Thanks for your reviews. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Affects Versions: 2.0.0 >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch, > HBASE-16729.v2.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575194#comment-15575194 ] ramkrishna.s.vasudevan commented on HBASE-16729: Before commit {code public int size() public boolean isEmpty() {code} Should these be public? > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Affects Versions: 2.0.0 >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch, > HBASE-16729.v2.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575190#comment-15575190 ] ramkrishna.s.vasudevan commented on HBASE-16729: QA looks green. Findbugs is not related to the patch. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Affects Versions: 2.0.0 >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch, > HBASE-16729.v2.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575179#comment-15575179 ] Hadoop QA commented on HBASE-16729: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 30s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 22s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 43s {color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 1s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 21s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 28m 42s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 21s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 46s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 56s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 74m 31s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 26s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 121m 28s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1289/HBASE-16729.v2.patch | | JIRA Issue | HBASE-16729 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2076897a9389 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 9a94dc9 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/4011/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | unit |
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575158#comment-15575158 ] ramkrishna.s.vasudevan commented on HBASE-16729: Will commit after QA results. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Affects Versions: 2.0.0 >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch, > HBASE-16729.v2.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575157#comment-15575157 ] ramkrishna.s.vasudevan commented on HBASE-16729: +1 on patch. Will commit this to 2.0 branch. {code} for (int i = 0; i != count; ++i) { {code} Why is that it is not checked for <=?. LGTM. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Affects Versions: 2.0.0 >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch, > HBASE-16729.v2.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574226#comment-15574226 ] stack commented on HBASE-16729: --- bq. Off by default? How we do this? Dunno. I didn't look. Apply the fix to branch-2 only? > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Affects Versions: 2.0.0 >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574222#comment-15574222 ] Hadoop QA commented on HBASE-16729: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 14s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 21s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 37s {color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 0s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 22s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 28m 51s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 37s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 54s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 79m 40s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 26s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 125m 45s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.regionserver.TestReversibleScanners | | Timed out junit tests | org.apache.hadoop.hbase.security.access.TestAccessController2 | | | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions | | | org.apache.hadoop.hbase.security.access.TestAccessController | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12833286/HBASE-16729.v1.patch | | JIRA Issue | HBASE-16729 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux bce896346ce2 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 91a7bbd | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | findbugs |
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574206#comment-15574206 ] ramkrishna.s.vasudevan commented on HBASE-16729: Thanks Stack. bq. if in branch-1, should be off by default. Off by default? How we do this? {code} public static Filter createFilterFromArguments(ArrayList filterArguments) { throw new IllegalArgumentException("This method has not been implemented"); } {code} Where is this being used in the code base? Other than this you find any other problem in extending FilterBase. Other than +1. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Affects Versions: 2.0.0 >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572474#comment-15572474 ] stack commented on HBASE-16729: --- I agree with changing the behavior so it is right is better than any doc. +1 on this patch but for 2.0 only or if in branch-1, should be off by default. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Attachments: HBASE-16729.v0.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572437#comment-15572437 ] ramkrishna.s.vasudevan commented on HBASE-16729: Ping [~saint@gmail.com] and [~lhofhansl]. What do you think with respect to this comment? bq.Instead of any change, we can just add enough comments to explain the empty FilterList. It seems to me that the issue of empty FilterList is the inconsistent result(see HBASE-16731). Do you reckon marking this as incompatible change as done in this patch or just a doc is enough? Seems [~chia7712] has run into issues because of empty filter list. So I felt changing the behaviour and having the write behaviour is better than just doc update. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Attachments: HBASE-16729.v0.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571315#comment-15571315 ] Hadoop QA commented on HBASE-16729: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 26s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 26s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 36s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 2s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 4s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 30m 20s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 40s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 56s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 13m 2s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 61m 42s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.io.encoding.TestSeekToBlockWithEncoders | | | hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan | | | hadoop.hbase.io.hfile.TestSeekTo | | | hadoop.hbase.regionserver.TestBlocksScanned | | | hadoop.hbase.regionserver.TestStoreFileScannerWithTagCompression | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12833060/HBASE-16729.v0.patch | | JIRA Issue | HBASE-16729 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux b31bde1e2a4d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / f11aa45 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit |
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571260#comment-15571260 ] ChiaPing Tsai commented on HBASE-16729: --- {noformat} Why this change now? And why is the generic removed now ? {noformat} Make the inner list unchangeable for preventing the unsafe modification. For example, user can add a filter to the list without checking the "Reversed". {noformat} Pls mark this as an incompatible change. I think with isFamilyEssential etc. we may have compatibility issue if suppose some one is creating an empty list. But anyway am not sure if that is a right way to use filters. {noformat} Instead of any change, we can just add enough comments to explain the empty FilterList. It seems to me that the issue of empty FilterList is the inconsistent result(see [HBASE-16731|https://issues.apache.org/jira/browse/HBASE-16731]). Thanks. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Reporter: ChiaPing Tsai >Assignee: ChiaPing Tsai >Priority: Trivial > Attachments: HBASE-16729.v0.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567682#comment-15567682 ] ramkrishna.s.vasudevan commented on HBASE-16729: Better to revisit other APIs also. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Reporter: ChiaPing Tsai >Priority: Trivial > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567678#comment-15567678 ] ramkrishna.s.vasudevan commented on HBASE-16729: I think it is better we use the size of the filter list to ensure what to be done. If there are no elements then isFamilyEssential should return true IMO. It is equivalent to no filters. > Define the behavior of (default) empty FilterList > - > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish >Reporter: ChiaPing Tsai >Priority: Trivial > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)