[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572360#comment-15572360 ] stack commented on HBASE-16803: --- That makes sense [~anoop.hbase]. Undoes this issue. Worth test to be sure. And ACL needs to be integrated as a fundamental too so it doesn't have to be an outsider CPEP. It is one of the features listed in HBASE-16757 "Integrate functionality currently done up as Coprocessor Endpoints into core" > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571547#comment-15571547 ] Anoop Sam John commented on HBASE-16803: One thing to notice is that the visibility related admin APIs (ie. adding labels, assigning labels with users etc) do write to labels table by directly writing to labels table single region. These APIs implemented as CPEP and so they will come directly to region. Other than that there is no specific reason to make it non splittable. But thinking more, even if we make it splittable, there should not be an issue no? The CPEP execution is such that, the client will find the region applicable for the rk passed and so we will hit the correct region. (Even if say labels table is having 2 regions).. Said that same applicable for ACL table also? Also the other jira impl as getting table ref from RegionEnv. Can we use region writes/reads directly there also? > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568427#comment-15568427 ] Ted Yu commented on HBASE-16803: [~anoop.hbase]: Can you remind me what's unique about hbase:labels table that the table cannot be split ? Thanks > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566989#comment-15566989 ] Hudson commented on HBASE-16803: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1769 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1769/]) HBASE-16803 Make hbase:acl table unsplittable (tedyu: rev bbc274626748b0b567116a3c7426b194c8a1ad97) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java HBASE-16803 Make hbase:acl table unsplittable - revert pending review (tedyu: rev fef3c908d33e6bc100a988e7ab9eeb6d4d2d61ea) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566767#comment-15566767 ] Hudson commented on HBASE-16803: SUCCESS: Integrated in Jenkins build HBase-1.4 #460 (See [https://builds.apache.org/job/HBase-1.4/460/]) HBASE-16803 Make hbase:acl table unsplittable (tedyu: rev 408a9eb8a303e9f0db5eecaa77c30f28ff521d07) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java HBASE-16803 Make hbase:acl table unsplittable - revert pending review (tedyu: rev b47ded3b4226e290953cf433829fdc1ee25c08fd) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566534#comment-15566534 ] Ted Yu commented on HBASE-16803: >From your comment, we should still leave hbase:acl table splittable. Though in reality, it is rare to grow beyond one region. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566526#comment-15566526 ] stack commented on HBASE-16803: --- You resolve w/o comment [~ted_yu]. What does that mean? Where does that leave this issue and HBASE-16773? > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566474#comment-15566474 ] stack commented on HBASE-16803: --- HBASE-11165 is the scaling issue w/ attached issues and discussion. "[DISCUSS] No regions on Master node in 2.0" is one thread that talks about this topic with attached docs that discuss pros and cons. Y! production is running a hacked hbase that splits hbase:meta. They are trying to get the facility back upstream ([~toffer] FYI). The new AM is doing its best to support splittable hbase:meta. More work to do. A patch that makes an argument that hbase:acl should not split because hbase:meta does not split is specious and going in the wrong direction. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566394#comment-15566394 ] stack commented on HBASE-16803: --- bq. However, the fix relies on the fact that there is single region in hbase:acl table so that the access can be local. Then the 'fix' is broke. bq. As discussed at the end of HBASE-16773, we should disable split of hbase:acl table as well. No. All tables should be able to grow naturally bq. hbase:meta is normally much larger than hbase:acl table and it has only one region. ... which we need to fix. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566374#comment-15566374 ] Ted Yu commented on HBASE-16803: Test failures were not related to my patch. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566373#comment-15566373 ] Ted Yu commented on HBASE-16803: Here is excerpt from: https://builds.apache.org/job/PreCommit-HBASE-Build/3943/console | Vote | Subsystem | Runtime | Comment | 0 | reexec | 0m 17s| Docker mode activated. | 0 | patch | 0m 2s | The patch file was not named according | | || to hbase's naming conventions. Please | | || see | | || https://yetus.apache.org/documentation/0. | | || 3.0/precommit-patchnames for | | || instructions. | +1 |@author | 0m 0s | The patch does not contain any @author | | || tags. | -1 | test4tests | 0m 0s | The patch doesn't appear to include any | | || new or modified tests. Please justify | | || why no new tests are needed for this | | || patch. Also please list what manual | | || steps were performed to verify this | | || patch. | +1 | mvninstall | 4m 14s| master passed | +1 |compile | 0m 40s| master passed | +1 | checkstyle | 0m 51s| master passed | +1 | mvneclipse | 0m 16s| master passed | +1 | findbugs | 2m 0s | master passed | +1 |javadoc | 0m 29s| master passed | +1 | mvninstall | 0m 55s| the patch passed | +1 |compile | 0m 43s| the patch passed | +1 | javac | 0m 43s| the patch passed | +1 | checkstyle | 0m 52s| the patch passed | +1 | mvneclipse | 0m 15s| the patch passed | +1 | whitespace | 0m 0s | The patch has no whitespace issues. | +1 |hadoopcheck | 27m 48s | Patch does not cause any errors with | | || Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 | | || 2.6.1 2.6.2 2.6.3 2.7.1. | +1 |hbaseprotoc | 0m 11s| the patch passed | +1 | findbugs | 1m 52s| the patch passed | +1 |javadoc | 0m 26s| the patch passed | -1 | unit | 76m 51s | hbase-server in the patch failed. | +1 | asflicense | 0m 14s| The patch does not generate ASF License | | || warnings. | | | 119m 14s | Reason | Tests Timed out junit tests | org.apache.hadoop.hbase.client.TestFromClientSide | org.apache.hadoop.hbase.client.TestScannerTimeout | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12832687/16803.v2.txt | | JIRA Issue | HBASE-16803 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 63aeab47c691 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / 9d304d3 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | /testptch/patchprocess/patch-unit-hbase-server.txt | | unit test logs | /testptch/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/3943/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/3943/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566174#comment-15566174 ] Enis Soztutar commented on HBASE-16803: --- +1. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565893#comment-15565893 ] Ted Yu commented on HBASE-16803: Is that a +1 ? > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565881#comment-15565881 ] Anoop Sam John commented on HBASE-16803: Yes. Thanks. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565865#comment-15565865 ] Ted Yu commented on HBASE-16803: See if patch v2 addresses your review comment. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt, 16803.v2.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565837#comment-15565837 ] Anoop Sam John commented on HBASE-16803: I forgot the jira. But that is about having millions of regions. I believe it originated from Y guys. The current patch need addition of isAclTable() to HRegionInfo which is why I prefer having the policy set. And see in case of vis labels, we do same. See in VisibilityController. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565475#comment-15565475 ] Ted Yu commented on HBASE-16803: Yes, it is Okay to make this change. Both Enis and Andrew sided with the proposal. Can you point me to the discussion for splitting hbase:meta ? I think when we have figured out how to solve all the intricacies of splitting meta, we should be able to split acl table as well. I thought of using DisabledRegionSplitPolicy. But the current change keeps decision of not splitting in one place which I prefer. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[ https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564870#comment-15564870 ] Anoop Sam John commented on HBASE-16803: On the patch, we can set DisabledRegionSplitPolicy as policy on the ACL table HTD when it is created? There is some discussion at tail of HBASE-16773. So is it ok to add this? There were some discussion to allow even META to be split. > Make hbase:acl table unsplittable > - > > Key: HBASE-16803 > URL: https://issues.apache.org/jira/browse/HBASE-16803 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 16803.v1.txt > > > HBASE-16773 fixed a case where PriorityRpcServer handler threads are all > occupied accessing hbase:acl table. > However, the fix relies on the fact that there is single region in hbase:acl > table so that the access can be local. > As discussed at the end of HBASE-16773, we should disable split of hbase:acl > table as well. > hbase:meta is normally much larger than hbase:acl table and it has only one > region. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16803) Make hbase:acl table unsplittable
[
https://issues.apache.org/jira/browse/HBASE-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564061#comment-15564061
]
Hadoop QA commented on HBASE-16803:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
57s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 8s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 58s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
52s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 6s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 76m 36s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 125m 34s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12832557/16803.v1.txt |
| JIRA Issue | HBASE-16803 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 97d6652ad6bd 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12
17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
