[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925662#comment-15925662
]
ramkrishna.s.vasudevan commented on HBASE-16859:
Sorry can you tell more here.
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925331#comment-15925331
]
Anoop Sam John commented on HBASE-16859:
{code}
**
34 * Writes len bytes from the
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885693#comment-15885693
]
ramkrishna.s.vasudevan commented on HBASE-16859:
[~anoop.hbase]
Stack has already
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882410#comment-15882410
]
ramkrishna.s.vasudevan commented on HBASE-16859:
This failure is in
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882383#comment-15882383
]
Hadoop QA commented on HBASE-16859:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858984#comment-15858984
]
ramkrishna.s.vasudevan commented on HBASE-16859:
I will rebase this patch and go for
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15769229#comment-15769229
]
stack commented on HBASE-16859:
---
Go for it [~ram_krish] (I have no numbers on native vs non-native clients)
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764054#comment-15764054
]
ramkrishna.s.vasudevan commented on HBASE-16859:
We have clean run now. Any final +1
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764038#comment-15764038
]
Hadoop QA commented on HBASE-16859:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760259#comment-15760259
]
ramkrishna.s.vasudevan commented on HBASE-16859:
Thanks for the comment Stack. Let me
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756000#comment-15756000
]
stack commented on HBASE-16859:
---
Are the failures related at all?
Otherwise, patch LGTM. Lets try it.
>
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755097#comment-15755097
]
stack commented on HBASE-16859:
---
Any downside [~ram_krish]?
> Use Bytebuffer pool for non java clients
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753989#comment-15753989
]
ramkrishna.s.vasudevan commented on HBASE-16859:
Ping!!. LAtest patch after review
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721978#comment-15721978
]
Hadoop QA commented on HBASE-16859:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714317#comment-15714317
]
ramkrishna.s.vasudevan commented on HBASE-16859:
I did not find any significant perf
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712065#comment-15712065
]
Hadoop QA commented on HBASE-16859:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711522#comment-15711522
]
ramkrishna.s.vasudevan commented on HBASE-16859:
bq.Then also once can make an IS around
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1576#comment-1576
]
ramkrishna.s.vasudevan commented on HBASE-16859:
But when I say two level copies - I
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711097#comment-15711097
]
Anoop Sam John commented on HBASE-16859:
I saw it now. So the ByteOuput is treated the same was
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711093#comment-15711093
]
ramkrishna.s.vasudevan commented on HBASE-16859:
TestHRegion seems to pass locally.
>
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711079#comment-15711079
]
ramkrishna.s.vasudevan commented on HBASE-16859:
bq.hat should be a miss! Raise a new
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709612#comment-15709612
]
Hadoop QA commented on HBASE-16859:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709156#comment-15709156
]
Anoop Sam John commented on HBASE-16859:
bq.static CodedOutputStream newInstance(ByteOutput
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709140#comment-15709140
]
ramkrishna.s.vasudevan commented on HBASE-16859:
{code}
/** Create a new
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709133#comment-15709133
]
Hadoop QA commented on HBASE-16859:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705360#comment-15705360
]
Hadoop QA commented on HBASE-16859:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701759#comment-15701759
]
ramkrishna.s.vasudevan commented on HBASE-16859:
Though we can create a newInstance of
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584628#comment-15584628
]
ramkrishna.s.vasudevan commented on HBASE-16859:
YEs got it. Saw the new API that accepts
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584545#comment-15584545
]
Anoop Sam John commented on HBASE-16859:
We dont need to add any extension to CIS or COS. COS
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584536#comment-15584536
]
ramkrishna.s.vasudevan commented on HBASE-16859:
One more thing to note here is that - if
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581959#comment-15581959
]
ramkrishna.s.vasudevan commented on HBASE-16859:
Previously in our internal branch we had
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581948#comment-15581948
]
ramkrishna.s.vasudevan commented on HBASE-16859:
Ya will see PB code as to how it
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581942#comment-15581942
]
Anoop Sam John commented on HBASE-16859:
Yep.. Read reqs into N buffers (from pool) rather than
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581936#comment-15581936
]
ramkrishna.s.vasudevan commented on HBASE-16859:
I have not seen the current PB code. So
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581932#comment-15581932
]
ramkrishna.s.vasudevan commented on HBASE-16859:
bq.We need to impl a ByteOutput which
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581895#comment-15581895
]
Anoop Sam John commented on HBASE-16859:
bq.We can add a flag in context to mark them for read.
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581890#comment-15581890
]
Anoop Sam John commented on HBASE-16859:
Say more. Am not fully getting.. We can use COS based
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581864#comment-15581864
]
ramkrishna.s.vasudevan commented on HBASE-16859:
Ideally we could directly return a
[
https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581858#comment-15581858
]
ramkrishna.s.vasudevan commented on HBASE-16859:
We can add a flag in context to mark
39 matches
Mail list logo