[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2017-03-15 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925662#comment-15925662 ] ramkrishna.s.vasudevan commented on HBASE-16859: Sorry can you tell more here.

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2017-03-14 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925331#comment-15925331 ] Anoop Sam John commented on HBASE-16859: {code} ** 34 * Writes len bytes from the

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2017-02-27 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885693#comment-15885693 ] ramkrishna.s.vasudevan commented on HBASE-16859: [~anoop.hbase] Stack has already

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2017-02-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882410#comment-15882410 ] ramkrishna.s.vasudevan commented on HBASE-16859: This failure is in

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2017-02-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882383#comment-15882383 ] Hadoop QA commented on HBASE-16859: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2017-02-08 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858984#comment-15858984 ] ramkrishna.s.vasudevan commented on HBASE-16859: I will rebase this patch and go for

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15769229#comment-15769229 ] stack commented on HBASE-16859: --- Go for it [~ram_krish] (I have no numbers on native vs non-native clients)

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-20 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764054#comment-15764054 ] ramkrishna.s.vasudevan commented on HBASE-16859: We have clean run now. Any final +1

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764038#comment-15764038 ] Hadoop QA commented on HBASE-16859: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-18 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760259#comment-15760259 ] ramkrishna.s.vasudevan commented on HBASE-16859: Thanks for the comment Stack. Let me

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-16 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756000#comment-15756000 ] stack commented on HBASE-16859: --- Are the failures related at all? Otherwise, patch LGTM. Lets try it. >

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-16 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755097#comment-15755097 ] stack commented on HBASE-16859: --- Any downside [~ram_krish]? > Use Bytebuffer pool for non java clients

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-16 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753989#comment-15753989 ] ramkrishna.s.vasudevan commented on HBASE-16859: Ping!!. LAtest patch after review

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721978#comment-15721978 ] Hadoop QA commented on HBASE-16859: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-01 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714317#comment-15714317 ] ramkrishna.s.vasudevan commented on HBASE-16859: I did not find any significant perf

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712065#comment-15712065 ] Hadoop QA commented on HBASE-16859: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-12-01 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711522#comment-15711522 ] ramkrishna.s.vasudevan commented on HBASE-16859: bq.Then also once can make an IS around

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-30 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1576#comment-1576 ] ramkrishna.s.vasudevan commented on HBASE-16859: But when I say two level copies - I

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-30 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711097#comment-15711097 ] Anoop Sam John commented on HBASE-16859: I saw it now. So the ByteOuput is treated the same was

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-30 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711093#comment-15711093 ] ramkrishna.s.vasudevan commented on HBASE-16859: TestHRegion seems to pass locally. >

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-30 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711079#comment-15711079 ] ramkrishna.s.vasudevan commented on HBASE-16859: bq.hat should be a miss! Raise a new

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709612#comment-15709612 ] Hadoop QA commented on HBASE-16859: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-30 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709156#comment-15709156 ] Anoop Sam John commented on HBASE-16859: bq.static CodedOutputStream newInstance(ByteOutput

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-30 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709140#comment-15709140 ] ramkrishna.s.vasudevan commented on HBASE-16859: {code} /** Create a new

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709133#comment-15709133 ] Hadoop QA commented on HBASE-16859: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705360#comment-15705360 ] Hadoop QA commented on HBASE-16859: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-11-28 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701759#comment-15701759 ] ramkrishna.s.vasudevan commented on HBASE-16859: Though we can create a newInstance of

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-18 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584628#comment-15584628 ] ramkrishna.s.vasudevan commented on HBASE-16859: YEs got it. Saw the new API that accepts

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584545#comment-15584545 ] Anoop Sam John commented on HBASE-16859: We dont need to add any extension to CIS or COS. COS

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584536#comment-15584536 ] ramkrishna.s.vasudevan commented on HBASE-16859: One more thing to note here is that - if

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581959#comment-15581959 ] ramkrishna.s.vasudevan commented on HBASE-16859: Previously in our internal branch we had

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581948#comment-15581948 ] ramkrishna.s.vasudevan commented on HBASE-16859: Ya will see PB code as to how it

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581942#comment-15581942 ] Anoop Sam John commented on HBASE-16859: Yep.. Read reqs into N buffers (from pool) rather than

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581936#comment-15581936 ] ramkrishna.s.vasudevan commented on HBASE-16859: I have not seen the current PB code. So

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581932#comment-15581932 ] ramkrishna.s.vasudevan commented on HBASE-16859: bq.We need to impl a ByteOutput which

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581895#comment-15581895 ] Anoop Sam John commented on HBASE-16859: bq.We can add a flag in context to mark them for read.

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581890#comment-15581890 ] Anoop Sam John commented on HBASE-16859: Say more. Am not fully getting.. We can use COS based

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581864#comment-15581864 ] ramkrishna.s.vasudevan commented on HBASE-16859: Ideally we could directly return a

[jira] [Commented] (HBASE-16859) Use Bytebuffer pool for non java clients specifically for scans/gets

2016-10-17 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581858#comment-15581858 ] ramkrishna.s.vasudevan commented on HBASE-16859: We can add a flag in context to mark