[jira] [Commented] (HBASE-17317) [branch-1] The updatePeerConfig method in ReplicationPeersZKImpl didn't update the table-cfs map
[ https://issues.apache.org/jira/browse/HBASE-17317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764295#comment-15764295 ] Hudson commented on HBASE-17317: SUCCESS: Integrated in Jenkins build HBase-1.4 #571 (See [https://builds.apache.org/job/HBase-1.4/571/]) HBASE-17317 [branch-1] The updatePeerConfig method in (zghao: rev 97d1ba401503d5ec504087b6cd3e93995fa21b7b) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdmin.java > [branch-1] The updatePeerConfig method in ReplicationPeersZKImpl didn't > update the table-cfs map > > > Key: HBASE-17317 > URL: https://issues.apache.org/jira/browse/HBASE-17317 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-17317-branch-1.patch > > > The updatePeerConfig method in ReplicationPeersZKImpl.java > {code} > @Override > public void updatePeerConfig(String id, ReplicationPeerConfig newConfig) > throws ReplicationException { > ReplicationPeer peer = getPeer(id); > if (peer == null){ > throw new ReplicationException("Could not find peer Id " + id); > } > ReplicationPeerConfig existingConfig = peer.getPeerConfig(); > if (newConfig.getClusterKey() != null && > !newConfig.getClusterKey().isEmpty() && > !newConfig.getClusterKey().equals(existingConfig.getClusterKey())){ > throw new ReplicationException("Changing the cluster key on an existing > peer is not allowed." > + " Existing key '" + existingConfig.getClusterKey() + "' does not > match new key '" > + newConfig.getClusterKey() + > "'"); > } > String existingEndpointImpl = existingConfig.getReplicationEndpointImpl(); > if (newConfig.getReplicationEndpointImpl() != null && > !newConfig.getReplicationEndpointImpl().isEmpty() && > !newConfig.getReplicationEndpointImpl().equals(existingEndpointImpl)){ > throw new ReplicationException("Changing the replication endpoint > implementation class " + > "on an existing peer is not allowed. Existing class '" > + existingConfig.getReplicationEndpointImpl() > + "' does not match new class '" + > newConfig.getReplicationEndpointImpl() + "'"); > } > //Update existingConfig's peer config and peer data with the new values, > but don't touch config > // or data that weren't explicitly changed > existingConfig.getConfiguration().putAll(newConfig.getConfiguration()); > existingConfig.getPeerData().putAll(newConfig.getPeerData()); >// Bug. We should update table-cfs map, too. > try { > ZKUtil.setData(this.zookeeper, getPeerNode(id), > ReplicationSerDeHelper.toByteArray(existingConfig)); > } > catch(KeeperException ke){ > throw new ReplicationException("There was a problem trying to save > changes to the " + > "replication peer " + id, ke); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17317) [branch-1] The updatePeerConfig method in ReplicationPeersZKImpl didn't update the table-cfs map
[ https://issues.apache.org/jira/browse/HBASE-17317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763933#comment-15763933 ] Guanghao Zhang commented on HBASE-17317: Pushed to branch-1. Thanks [~tedyu] for reviewing. > [branch-1] The updatePeerConfig method in ReplicationPeersZKImpl didn't > update the table-cfs map > > > Key: HBASE-17317 > URL: https://issues.apache.org/jira/browse/HBASE-17317 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-17317-branch-1.patch > > > The updatePeerConfig method in ReplicationPeersZKImpl.java > {code} > @Override > public void updatePeerConfig(String id, ReplicationPeerConfig newConfig) > throws ReplicationException { > ReplicationPeer peer = getPeer(id); > if (peer == null){ > throw new ReplicationException("Could not find peer Id " + id); > } > ReplicationPeerConfig existingConfig = peer.getPeerConfig(); > if (newConfig.getClusterKey() != null && > !newConfig.getClusterKey().isEmpty() && > !newConfig.getClusterKey().equals(existingConfig.getClusterKey())){ > throw new ReplicationException("Changing the cluster key on an existing > peer is not allowed." > + " Existing key '" + existingConfig.getClusterKey() + "' does not > match new key '" > + newConfig.getClusterKey() + > "'"); > } > String existingEndpointImpl = existingConfig.getReplicationEndpointImpl(); > if (newConfig.getReplicationEndpointImpl() != null && > !newConfig.getReplicationEndpointImpl().isEmpty() && > !newConfig.getReplicationEndpointImpl().equals(existingEndpointImpl)){ > throw new ReplicationException("Changing the replication endpoint > implementation class " + > "on an existing peer is not allowed. Existing class '" > + existingConfig.getReplicationEndpointImpl() > + "' does not match new class '" + > newConfig.getReplicationEndpointImpl() + "'"); > } > //Update existingConfig's peer config and peer data with the new values, > but don't touch config > // or data that weren't explicitly changed > existingConfig.getConfiguration().putAll(newConfig.getConfiguration()); > existingConfig.getPeerData().putAll(newConfig.getPeerData()); >// Bug. We should update table-cfs map, too. > try { > ZKUtil.setData(this.zookeeper, getPeerNode(id), > ReplicationSerDeHelper.toByteArray(existingConfig)); > } > catch(KeeperException ke){ > throw new ReplicationException("There was a problem trying to save > changes to the " + > "replication peer " + id, ke); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17317) [branch-1] The updatePeerConfig method in ReplicationPeersZKImpl didn't update the table-cfs map
[ https://issues.apache.org/jira/browse/HBASE-17317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752592#comment-15752592 ] Ted Yu commented on HBASE-17317: +1 > [branch-1] The updatePeerConfig method in ReplicationPeersZKImpl didn't > update the table-cfs map > > > Key: HBASE-17317 > URL: https://issues.apache.org/jira/browse/HBASE-17317 > Project: HBase > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Attachments: HBASE-17317-branch-1.patch > > > The updatePeerConfig method in ReplicationPeersZKImpl.java > {code} > @Override > public void updatePeerConfig(String id, ReplicationPeerConfig newConfig) > throws ReplicationException { > ReplicationPeer peer = getPeer(id); > if (peer == null){ > throw new ReplicationException("Could not find peer Id " + id); > } > ReplicationPeerConfig existingConfig = peer.getPeerConfig(); > if (newConfig.getClusterKey() != null && > !newConfig.getClusterKey().isEmpty() && > !newConfig.getClusterKey().equals(existingConfig.getClusterKey())){ > throw new ReplicationException("Changing the cluster key on an existing > peer is not allowed." > + " Existing key '" + existingConfig.getClusterKey() + "' does not > match new key '" > + newConfig.getClusterKey() + > "'"); > } > String existingEndpointImpl = existingConfig.getReplicationEndpointImpl(); > if (newConfig.getReplicationEndpointImpl() != null && > !newConfig.getReplicationEndpointImpl().isEmpty() && > !newConfig.getReplicationEndpointImpl().equals(existingEndpointImpl)){ > throw new ReplicationException("Changing the replication endpoint > implementation class " + > "on an existing peer is not allowed. Existing class '" > + existingConfig.getReplicationEndpointImpl() > + "' does not match new class '" + > newConfig.getReplicationEndpointImpl() + "'"); > } > //Update existingConfig's peer config and peer data with the new values, > but don't touch config > // or data that weren't explicitly changed > existingConfig.getConfiguration().putAll(newConfig.getConfiguration()); > existingConfig.getPeerData().putAll(newConfig.getPeerData()); >// Bug. We should update table-cfs map, too. > try { > ZKUtil.setData(this.zookeeper, getPeerNode(id), > ReplicationSerDeHelper.toByteArray(existingConfig)); > } > catch(KeeperException ke){ > throw new ReplicationException("There was a problem trying to save > changes to the " + > "replication peer " + id, ke); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17317) [branch-1] The updatePeerConfig method in ReplicationPeersZKImpl didn't update the table-cfs map
[ https://issues.apache.org/jira/browse/HBASE-17317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751342#comment-15751342 ] Hadoop QA commented on HBASE-17317: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 52s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s {color} | {color:green} branch-1 passed with JDK v1.8.0_111 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s {color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 53s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 29s {color} | {color:green} branch-1 passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 3s {color} | {color:red} hbase-server in branch-1 has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s {color} | {color:green} branch-1 passed with JDK v1.8.0_111 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s {color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 3s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s {color} | {color:green} the patch passed with JDK v1.8.0_111 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s {color} | {color:green} the patch passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 54s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 53s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 30s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 15m 47s {color} | {color:green} The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 26s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 32s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s {color} | {color:green} the patch passed with JDK v1.8.0_111 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s {color} | {color:green} the patch passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 54s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 96m 53s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 32s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 136m 12s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.replication.TestSerialReplication | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:e01ee2f | | JIRA Patch URL |