[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-09-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158245#comment-16158245 ] Duo Zhang commented on HBASE-17584: --- Added 1.4.0 to fix versions, we do not branch-1.4 at that time I

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-09-08 Thread Lars George (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158238#comment-16158238 ] Lars George commented on HBASE-17584: - [~Apache9] If this is pushed to branch-1, could you please

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933012#comment-15933012 ] Hudson commented on HBASE-17584: FAILURE: Integrated in Jenkins build HBase-1.4 #677 (See

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932303#comment-15932303 ] Duo Zhang commented on HBASE-17584: --- The failed UT is unrelated. Will check it later. Let me commit

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932276#comment-15932276 ] Hadoop QA commented on HBASE-17584: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932137#comment-15932137 ] stack commented on HBASE-17584: --- Ok. +1 for backport to branch-1 Sir. > Expose ScanMetrics with

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932134#comment-15932134 ] Duo Zhang commented on HBASE-17584: --- No. There is a AbstractClientScanner but it is marked as

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932132#comment-15932132 ] stack commented on HBASE-17584: --- is there a default implementation in this case? [~Apache9] > Expose

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927524#comment-15927524 ] Duo Zhang commented on HBASE-17584: --- Done. [~stack] [~enis]. > Expose ScanMetrics with ResultScanner

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927513#comment-15927513 ] Duo Zhang commented on HBASE-17584: --- OK, let me start a thread on mailing list. > Expose ScanMetrics

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927506#comment-15927506 ] stack commented on HBASE-17584: --- [~enis] [~Apache9] Duo (or I), lets start a thread on mailing list w/

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-15 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926965#comment-15926965 ] Enis Soztutar commented on HBASE-17584: --- bq. Let's open a thread in the mailing list for this? I

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926960#comment-15926960 ] stack commented on HBASE-17584: --- +1 on commit. On thread on dev list on compatibility, you or I to open

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926426#comment-15926426 ] Hudson commented on HBASE-17584: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2677 (See

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925595#comment-15925595 ] Duo Zhang commented on HBASE-17584: --- Will commit later today if no other objections. Thanks. > Expose

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925594#comment-15925594 ] Duo Zhang commented on HBASE-17584: --- Anyway, let's commit this to 2.0 first. If later we decide to also

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925581#comment-15925581 ] Duo Zhang commented on HBASE-17584: --- [~enis] If you mean {{AsyncTableResultScanner}}, it is

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-14 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924769#comment-15924769 ] Enis Soztutar commented on HBASE-17584: --- Javadoc says that we are returning null, but if the

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924368#comment-15924368 ] stack commented on HBASE-17584: --- Patch looks great. +1 On compatibility, adding a new method to our base

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900811#comment-15900811 ] Hadoop QA commented on HBASE-17584: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900677#comment-15900677 ] Duo Zhang commented on HBASE-17584: --- OK, I found this in our documentation. {noformat} New APIs

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-03-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898921#comment-15898921 ] Duo Zhang commented on HBASE-17584: --- Ping [~stack]. > Expose ScanMetrics with ResultScanner rather

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-28 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889589#comment-15889589 ] Duo Zhang commented on HBASE-17584: --- Ping [~stack]. At least we can commit this patch to master? >

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-27 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887195#comment-15887195 ] Duo Zhang commented on HBASE-17584: --- What do you think sir [~stack]? Thanks. > Expose ScanMetrics with

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-26 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884746#comment-15884746 ] Duo Zhang commented on HBASE-17584: --- Adding methods to an interface will cause compilation error for

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884233#comment-15884233 ] stack commented on HBASE-17584: --- Adding methods should be ok on a minor version, 1.4? > Expose ScanMetrics

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884210#comment-15884210 ] Duo Zhang commented on HBASE-17584: --- I hope this could be applied to branch-1 but there is a

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882345#comment-15882345 ] Hadoop QA commented on HBASE-17584: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881871#comment-15881871 ] Duo Zhang commented on HBASE-17584: --- No idea yet. Let me have a try first... > Expose ScanMetrics with

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881850#comment-15881850 ] stack commented on HBASE-17584: --- That'd be good yeah, but the reset of scan metrics is broke? > Expose

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881844#comment-15881844 ] Duo Zhang commented on HBASE-17584: --- I think at least we should have a release that exposes it in two

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881838#comment-15881838 ] stack commented on HBASE-17584: --- Do we have to? In 2.0 change the behavior? > Expose ScanMetrics with

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880393#comment-15880393 ] Duo Zhang commented on HBASE-17584: --- We will reset the counters in ScanMetrics when calling

[jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan

2017-02-02 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849915#comment-15849915 ] Duo Zhang commented on HBASE-17584: --- [~stack] FYI. When reading the code, I found that an important