[jira] [Commented] (HBASE-17658) Bookkeeping issue in BaseLoadBalancer for Table Skew
[ https://issues.apache.org/jira/browse/HBASE-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106890#comment-16106890 ] Chia-Ping Tsai commented on HBASE-17658: HBASE-18480 is based on this issue. I will push this to branch-1.3 and branch-1.2 tomorrow if no objections. FYI [~yuzhih...@gmail.com] > Bookkeeping issue in BaseLoadBalancer for Table Skew > > > Key: HBASE-17658 > URL: https://issues.apache.org/jira/browse/HBASE-17658 > Project: HBase > Issue Type: Bug > Components: Balancer >Reporter: Tim Brown >Assignee: Tim Brown > Fix For: 2.0.0, 1.4.0 > > Attachments: JIRA-17658.master.001.patch > > > Currently when numMaxRegionsPerTable of a given table increases above the > current maximum, the value is not properly updated. This means that the cost > for Table Skew cannot get worse for a given region move during the balancer > process leading to an imbalanced cluster with respect to Table Skew. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17658) Bookkeeping issue in BaseLoadBalancer for Table Skew
[ https://issues.apache.org/jira/browse/HBASE-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106519#comment-16106519 ] Chia-Ping Tsai commented on HBASE-17658: [~yuzhih...@gmail.com] Why not push this to the other active 1.y branches? > Bookkeeping issue in BaseLoadBalancer for Table Skew > > > Key: HBASE-17658 > URL: https://issues.apache.org/jira/browse/HBASE-17658 > Project: HBase > Issue Type: Bug > Components: Balancer >Reporter: Tim Brown >Assignee: Tim Brown > Fix For: 2.0.0, 1.4.0 > > Attachments: JIRA-17658.master.001.patch > > > Currently when numMaxRegionsPerTable of a given table increases above the > current maximum, the value is not properly updated. This means that the cost > for Table Skew cannot get worse for a given region move during the balancer > process leading to an imbalanced cluster with respect to Table Skew. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17658) Bookkeeping issue in BaseLoadBalancer for Table Skew
[ https://issues.apache.org/jira/browse/HBASE-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872422#comment-15872422 ] Hudson commented on HBASE-17658: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2522 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2522/]) HBASE-17658 Fix bookkeeping error with max regions for a table (tedyu: rev 938aef772d82f7a52228436b141e62af66e11e76) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestBaseLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java > Bookkeeping issue in BaseLoadBalancer for Table Skew > > > Key: HBASE-17658 > URL: https://issues.apache.org/jira/browse/HBASE-17658 > Project: HBase > Issue Type: Bug > Components: Balancer >Reporter: Tim Brown >Assignee: Tim Brown > Fix For: 2.0.0, 1.4.0 > > Attachments: JIRA-17658.master.001.patch > > > Currently when numMaxRegionsPerTable of a given table increases above the > current maximum, the value is not properly updated. This means that the cost > for Table Skew cannot get worse for a given region move during the balancer > process leading to an imbalanced cluster with respect to Table Skew. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17658) Bookkeeping issue in BaseLoadBalancer for Table Skew
[ https://issues.apache.org/jira/browse/HBASE-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872274#comment-15872274 ] Hudson commented on HBASE-17658: FAILURE: Integrated in Jenkins build HBase-1.4 #634 (See [https://builds.apache.org/job/HBase-1.4/634/]) HBASE-17658 Fix bookkeeping error with max regions for a table (tedyu: rev 6b96b0ce853b83cf445018292217f736fbff906d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestBaseLoadBalancer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java > Bookkeeping issue in BaseLoadBalancer for Table Skew > > > Key: HBASE-17658 > URL: https://issues.apache.org/jira/browse/HBASE-17658 > Project: HBase > Issue Type: Bug > Components: Balancer >Reporter: Tim Brown >Assignee: Tim Brown > Fix For: 2.0.0, 1.4.0 > > Attachments: JIRA-17658.master.001.patch > > > Currently when numMaxRegionsPerTable of a given table increases above the > current maximum, the value is not properly updated. This means that the cost > for Table Skew cannot get worse for a given region move during the balancer > process leading to an imbalanced cluster with respect to Table Skew. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17658) Bookkeeping issue in BaseLoadBalancer for Table Skew
[ https://issues.apache.org/jira/browse/HBASE-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871998#comment-15871998 ] Ted Yu commented on HBASE-17658: There was typo in the subject of the patch. JIRA number was missing. Here is the modified subject: HBASE-17658 Fix bookkeeping error with max regions for a table > Bookkeeping issue in BaseLoadBalancer for Table Skew > > > Key: HBASE-17658 > URL: https://issues.apache.org/jira/browse/HBASE-17658 > Project: HBase > Issue Type: Bug > Components: Balancer >Reporter: Tim Brown >Assignee: Tim Brown > Attachments: JIRA-17658.master.001.patch > > > Currently when numMaxRegionsPerTable of a given table increases above the > current maximum, the value is not properly updated. This means that the cost > for Table Skew cannot get worse for a given region move during the balancer > process leading to an imbalanced cluster with respect to Table Skew. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17658) Bookkeeping issue in BaseLoadBalancer for Table Skew
[
https://issues.apache.org/jira/browse/HBASE-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871993#comment-15871993
]
Ted Yu commented on HBASE-17658:
{code}
testMobGetAtomicity[1](org.apache.hadoop.hbase.TestAcidGuarantees) Time
elapsed: 21.968 sec <<< ERROR!
java.lang.RuntimeException: Deferred
at
org.apache.hadoop.hbase.MultithreadedTestUtil$TestContext.checkException(MultithreadedTestUtil.java:79)
at
org.apache.hadoop.hbase.MultithreadedTestUtil$TestContext.waitFor(MultithreadedTestUtil.java:72)
at
org.apache.hadoop.hbase.TestAcidGuarantees.runTestAtomicity(TestAcidGuarantees.java:388)
at
org.apache.hadoop.hbase.TestAcidGuarantees.testMobGetAtomicity(TestAcidGuarantees.java:435)
{code}
Not related to patch.
> Bookkeeping issue in BaseLoadBalancer for Table Skew
>
>
> Key: HBASE-17658
> URL: https://issues.apache.org/jira/browse/HBASE-17658
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Reporter: Tim Brown
>Assignee: Tim Brown
> Attachments: JIRA-17658.master.001.patch
>
>
> Currently when numMaxRegionsPerTable of a given table increases above the
> current maximum, the value is not properly updated. This means that the cost
> for Table Skew cannot get worse for a given region move during the balancer
> process leading to an imbalanced cluster with respect to Table Skew.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17658) Bookkeeping issue in BaseLoadBalancer for Table Skew
[
https://issues.apache.org/jira/browse/HBASE-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871130#comment-15871130
]
Hadoop QA commented on HBASE-17658:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 37s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
17s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 33s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 124m 53s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 173m 23s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.6 Server=1.12.6 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12853175/JIRA-17658.master.001.patch
|
| JIRA Issue | HBASE-17658 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux dfb980fb663c 3.13.0-100-generic #147-Ubuntu SMP Tue Oct 18
16:48:51 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / ae840c0 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/5743/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/5743/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/5743/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Bookkeeping issue in BaseLoadBalancer for Table Skew
>
>
> Key: HBASE-17658
> URL: https://issues.apache.org/jira/browse/HBASE-17658
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Reporter: Tim Brown
>Assignee: Tim
[jira] [Commented] (HBASE-17658) Bookkeeping issue in BaseLoadBalancer for Table Skew
[ https://issues.apache.org/jira/browse/HBASE-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870974#comment-15870974 ] Ted Yu commented on HBASE-17658: +1, pending QA. > Bookkeeping issue in BaseLoadBalancer for Table Skew > > > Key: HBASE-17658 > URL: https://issues.apache.org/jira/browse/HBASE-17658 > Project: HBase > Issue Type: Bug > Components: Balancer >Reporter: Tim Brown >Assignee: Tim Brown > Attachments: JIRA-17658.master.001.patch > > > Currently when numMaxRegionsPerTable of a given table increases above the > current maximum, the value is not properly updated. This means that the cost > for Table Skew cannot get worse for a given region move during the balancer > process leading to an imbalanced cluster with respect to Table Skew. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
