[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880069#comment-15880069
]
Hudson commented on HBASE-17672:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2555 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/2555/])
HBASE-17672: "Grant should set access rights appropriately" test fails (tedyu:
rev 335cde34150539c31e01b9f4ddfc89f63d147d5f)
* (edit) hbase-shell/src/test/ruby/hbase/security_admin_test.rb
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch, HBASE-17672.v1.patch,
> HBASE-17672.v2.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879716#comment-15879716
]
Ted Yu commented on HBASE-17672:
+1 on v2.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch, HBASE-17672.v1.patch,
> HBASE-17672.v2.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879713#comment-15879713
]
Hadoop QA commented on HBASE-17672:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 5s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 5s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 59s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 50s
{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 15s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12854110/HBASE-17672.v2.patch |
| JIRA Issue | HBASE-17672 |
| Optional Tests | asflicense unit rubocop ruby_lint |
| uname | Linux c9ed95ef7526 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 0285cb8 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/5807/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/5807/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch, HBASE-17672.v1.patch,
> HBASE-17672.v2.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879672#comment-15879672
]
Zheng Hu commented on HBASE-17672:
--
Any concerns ? [~tedyu] , Thanks.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch, HBASE-17672.v1.patch,
> HBASE-17672.v2.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879667#comment-15879667
]
Zheng Hu commented on HBASE-17672:
--
> Other than spelling, v2 seems to be same as v1 ?
Yes.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch, HBASE-17672.v1.patch,
> HBASE-17672.v2.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879665#comment-15879665
]
Zheng Hu commented on HBASE-17672:
--
Upload patch v2 , [~ted_yu]
The original purpose of the UT:
1. grant permission like W action.
2. assert action exists;
3. grant other permissions like RXCA.
4. assert that whether RXCA will override previous actions. (after
HBASE-17472, assert merge behavior)
The original test use table owner for testing, so we can skip step.1 because
RWXCA are granted for owner, but now we use a new created user
(test_grant_revoke_user), so we must grant some actions (we choose WRITE) first
for step.1 .
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch, HBASE-17672.v1.patch,
> HBASE-17672.v2.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879662#comment-15879662
]
Ted Yu commented on HBASE-17672:
Other than spelling, v2 seems to be same as v1 ?
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch, HBASE-17672.v1.patch,
> HBASE-17672.v2.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879002#comment-15879002
]
Ted Yu commented on HBASE-17672:
{code}
+ assert(found_permission, "Permission for user test_grant_revoke does not
found.")
{code}
"does not found." -> "was not found."
{code}
+ security_admin.grant(test_grant_revoke_user,"W", @test_name)
{code}
The original test didn't include write permission. Is there reason for granting
test_grant_revoke_user write permission ?
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch, HBASE-17672.v1.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878459#comment-15878459
]
Hadoop QA commented on HBASE-17672:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 5s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 5s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
40s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 49s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 39s
{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 38s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12853966/HBASE-17672.v1.patch |
| JIRA Issue | HBASE-17672 |
| Optional Tests | asflicense unit rubocop ruby_lint |
| uname | Linux 032063d6a0ed 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f037f23 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/5801/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/5801/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch, HBASE-17672.v1.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878295#comment-15878295
]
Zheng Hu commented on HBASE-17672:
--
Yeah, It's better to use a new created use for the UT. Will upload a new
patch.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878241#comment-15878241
]
Ted Yu commented on HBASE-17672:
Can you modify the test so that the second user does the grant ?
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878191#comment-15878191
]
Zheng Hu commented on HBASE-17672:
--
In my mind, Both "the second user" and "the table owner" are the same,
because , we use the user org.apache.hadoop.hbase.security.User.getCurrent()
to grant , not other created user.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878169#comment-15878169
]
Ted Yu commented on HBASE-17672:
Why would the second user inherit write permission from table owner ?
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878119#comment-15878119
]
Zheng Hu commented on HBASE-17672:
--
[~ted_yu] , Thanks for your reply. After re-check the code, I found that
permission RWXCA will be granted to new created table for the table owner. The
logic is in AccessController.postCompletedCreateTableAction() .
In HBASE-17472, We redefine grant semantic : later granted permissions will
merge with previous granted permissions. (see release notes for more details).
For failed ruby UT, user has RWXCA permissions when the user created a new
table, and if we grant RXCA to user for the specific table, user will has
permission (RWXCA + RXCA =) RWXCA, so the user have write permission
finally. ( + means merge behavior) .
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876240#comment-15876240
]
Ted Yu commented on HBASE-17672:
{code}
+ assert_match(eval("/WRITE/"), permission.to_s)
{code}
Write permission was not explicitly granted. Why does the user have write
permission now ?
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875532#comment-15875532
]
Hadoop QA commented on HBASE-17672:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 6s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 6s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 10s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 56s
{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 34s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12853670/HBASE-17672.patch |
| JIRA Issue | HBASE-17672 |
| Optional Tests | asflicense unit rubocop ruby_lint |
| uname | Linux 5ba46d5e1ee0 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / d7ffa00 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/5780/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/5780/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.0.0
>Reporter: Ted Yu
>Assignee: Zheng Hu
> Fix For: 2.0.0
>
> Attachments: HBASE-17672.patch
>
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875452#comment-15875452
]
Zheng Hu commented on HBASE-17672:
--
Sorry about the failed ut, I've uploaded a patch to fix failed case. All ruby
tests are passed in my localhost.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17672) "Grant should set access rights appropriately" test fails
[
https://issues.apache.org/jira/browse/HBASE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875416#comment-15875416
]
Zheng Hu commented on HBASE-17672:
--
[~tedyu], Thanks for reminding , Let me fix it.
> "Grant should set access rights appropriately" test fails
> -
>
> Key: HBASE-17672
> URL: https://issues.apache.org/jira/browse/HBASE-17672
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>
> The following test failure is reproducible after HBASE-17472 went in:
> {code}
> 1) Failure:
> test_Grant_should_set_access_rights_appropriately(Hbase::SecureAdminMethodsTest)
> [./src/test/ruby/hbase/security_admin_test.rb:66:in
> `test_Grant_should_set_access_rights_appropriately'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:154:in
> `user_permission'
>
> file:/Users/tyu/.m2/repository/org/jruby/jruby-complete/1.6.8/jruby-complete-1.6.8.jar!/builtin/java/java.util.rb:7:in
> `each'
> /Users/tyu/trunk/hbase-shell/src/main/ruby/hbase/security.rb:136:in
> `user_permission'
> ./src/test/ruby/hbase/security_admin_test.rb:65:in
> `test_Grant_should_set_access_rights_appropriately'
> org/jruby/RubyProc.java:270:in `call'
> org/jruby/RubyKernel.java:2105:in `send'
> org/jruby/RubyArray.java:1620:in `each'
> org/jruby/RubyArray.java:1620:in `each']:
> {code}
> [~openinx]:
> Can you take a look ?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
