[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360819#comment-17360819
]
Viraj Jasani commented on HBASE-18298:
--
After removal ofÂ
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265027#comment-16265027
]
stack commented on HBASE-18298:
---
[~an...@apache.org] I filed HBASE-19341 to ensure you can still abort by
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264132#comment-16264132
]
Ankit Singhal commented on HBASE-18298:
---
Thank you [~anoop.hbase] and @Stack for taking a look and
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259524#comment-16259524
]
Anoop Sam John commented on HBASE-18298:
As Stack said. There is a config to decide what should
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259473#comment-16259473
]
stack commented on HBASE-18298:
---
bq. Anoop Sam John, Phoenix wants to abort the regionserver if the attempt
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259164#comment-16259164
]
Ankit Singhal commented on HBASE-18298:
---
[~anoop.hbase], Phoenix wants to abort the regionserver if
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195094#comment-16195094
]
Hudson commented on HBASE-18298:
Results for branch HBASE-18467, done in 4 hr 24 min and counting
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182710#comment-16182710
]
Hudson commented on HBASE-18298:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3787 (See
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182061#comment-16182061
]
Anoop Sam John commented on HBASE-18298:
Thanks Stack.. Ya I was writing the notes when u were
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182015#comment-16182015
]
stack commented on HBASE-18298:
---
This is excellent!
Needs a nice release note. Include any suggestions
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181996#comment-16181996
]
Hadoop QA commented on HBASE-18298:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181605#comment-16181605
]
Hadoop QA commented on HBASE-18298:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181240#comment-16181240
]
Anoop Sam John commented on HBASE-18298:
Thanks... Once QA is fine, will commit..
>
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181221#comment-16181221
]
stack commented on HBASE-18298:
---
I made HBASE-18881 for an example/study/suggestion on how to keep up a
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180696#comment-16180696
]
Duo Zhang commented on HBASE-18298:
---
Left some comments on RB. Mainly about using HRegion instead of
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180488#comment-16180488
]
Hadoop QA commented on HBASE-18298:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180293#comment-16180293
]
Anoop Sam John commented on HBASE-18298:
Latest patch with rebase and fixing last set of comments
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180254#comment-16180254
]
ramkrishna.s.vasudevan commented on HBASE-18298:
Had a quick glance at the patch. LGTM.
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180189#comment-16180189
]
Anoop Sam John commented on HBASE-18298:
hmm... Agree Stack.
In the ZK eg: which is changed in
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180183#comment-16180183
]
stack commented on HBASE-18298:
---
I saw an interesting case today where a CP was being used to keep up a
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180150#comment-16180150
]
Anoop Sam John commented on HBASE-18298:
Sorry [~Apache9].. The RB is not having latest patch.
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179597#comment-16179597
]
stack commented on HBASE-18298:
---
What do I look at? RB is different to v5 here? I'm going w/ v5 because it
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179478#comment-16179478
]
stack commented on HBASE-18298:
---
bq. RpcServerInterface (and now the abstract extension of this RpcServer)
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179091#comment-16179091
]
Duo Zhang commented on HBASE-18298:
---
Left some comments on RB. Thanks.
> RegionServerServices
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178600#comment-16178600
]
Anoop Sam John commented on HBASE-18298:
[~stack] all comments fixed. Can u pls have a look at
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176482#comment-16176482
]
Hadoop QA commented on HBASE-18298:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176274#comment-16176274
]
Anoop Sam John commented on HBASE-18298:
bq.How comes getRpcServer? Some CPs need this? I'd think
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176231#comment-16176231
]
Anoop Sam John commented on HBASE-18298:
bq.Yeah, name CoprocessorRSServices as
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175741#comment-16175741
]
stack commented on HBASE-18298:
---
Yeah, name CoprocessorRSServices as CompressorRegionServerServices and
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175708#comment-16175708
]
stack commented on HBASE-18298:
---
Pardon. I've been away from this important issue. Let me get back to it by
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159821#comment-16159821
]
Chia-Ping Tsai commented on HBASE-18298:
bq. Mentioned abt this in above comment. U ok?
I prefer
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159803#comment-16159803
]
Anoop Sam John commented on HBASE-18298:
bq.This is not right? public CoprocessorRSServices
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159702#comment-16159702
]
stack commented on HBASE-18298:
---
So what did you did [~anoop.hbase]?
Just call CoprocessorRSServices
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159098#comment-16159098
]
Chia-Ping Tsai commented on HBASE-18298:
{code}
- RegionServerServices
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159089#comment-16159089
]
Hadoop QA commented on HBASE-18298:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156589#comment-16156589
]
stack commented on HBASE-18298:
---
[~anoop.hbase] I put a comment up on rb. A thought...
>
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156448#comment-16156448
]
Anoop Sam John commented on HBASE-18298:
Got some time to check Stack? Any suggestions? Once
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131606#comment-16131606
]
stack commented on HBASE-18298:
---
[~anoop.hbase] Let me look again. I don't like the RSSInternal thing. Let
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131586#comment-16131586
]
Anoop Sam John commented on HBASE-18298:
[~stack] You ok with this extended Interface ( for
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116068#comment-16116068
]
Anoop Sam John commented on HBASE-18298:
After our F2F discussion, I hope its clear for u now.
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112031#comment-16112031
]
stack commented on HBASE-18298:
---
I did some review up in CP. Whats this issue about though Anoop? I'm not
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074192#comment-16074192
]
Anoop Sam John commented on HBASE-18298:
https://reviews.apache.org/r/60643/
>
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074188#comment-16074188
]
Duo Zhang commented on HBASE-18298:
---
{quote}
we still stick to interface based usage and which helps a
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074189#comment-16074189
]
Anoop Sam John commented on HBASE-18298:
Sure. Let me see whether I need a rebase.
>
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073699#comment-16073699
]
Anoop Sam John commented on HBASE-18298:
May be not really. But this is better IMO. we still
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073576#comment-16073576
]
Duo Zhang commented on HBASE-18298:
---
Is it better than just use HRegionServer directly in our own code?
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073571#comment-16073571
]
Anoop Sam John commented on HBASE-18298:
Ping [~Apache9], Stack
As a solution am adding new
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073537#comment-16073537
]
Hadoop QA commented on HBASE-18298:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073311#comment-16073311
]
Hadoop QA commented on HBASE-18298:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072318#comment-16072318
]
Hadoop QA commented on HBASE-18298:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071960#comment-16071960
]
Anoop Sam John commented on HBASE-18298:
Doing this now.. Seems it will be a big patch with
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069625#comment-16069625
]
Anoop Sam John commented on HBASE-18298:
Super interface OnlineRegions has some APIs to be
[
https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069617#comment-16069617
]
Anoop Sam John commented on HBASE-18298:
To be removed APIs
WAL getWAL(HRegionInfo regionInfo)
53 matches
Mail list logo
