[jira] [Commented] (HBASE-18518) Remove jersey1* dependencies form project and jersey1* jars from lib dir
[ https://issues.apache.org/jira/browse/HBASE-18518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115512#comment-16115512 ] Samir Ahmic commented on HBASE-18518: - [~mdrob] bq. Also, do we need to make changes in the hbase-rest/pom.xml to specify the correct version of jersey? This is already specified in parent pom.xml in root dir. bq. Where do we need the transitive hadoop jersey available? We need it every module when we run tests which requires starting hadoop mini cluster. Without it staring hadoop mini cluster will fail and consequently our tests will fail. Do you have any suggestions how may improve current dependency management ? > Remove jersey1* dependencies form project and jersey1* jars from lib dir > > > Key: HBASE-18518 > URL: https://issues.apache.org/jira/browse/HBASE-18518 > Project: HBase > Issue Type: Task > Components: dependencies, pom, REST >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Samir Ahmic >Assignee: Samir Ahmic > Labels: cleanup > Fix For: 3.0.0 > > Attachments: HBASE-18518-master-01.patch > > > Recently i have opened https://issues.apache.org/jira/browse/HBASE-18506 and > it is clear that is caused by mixing jersey1 and jersey2 jars in classpath. > With https://issues.apache.org/jira/browse/HBASE-12894 we have introduced > jersey2 to project, and we also have bunch of transitive dependencies > (mainly from hadoop) on jersey1 which is not happiest situation since jersey1 > and jersey2 under same classpath can case runtime issues as it was case with > rest. > This task will have following steps > * Clean code and replace jersey1 constructs with jersey2 versions(there > should not be much of this) > * Add exclusions for transitive jersey1 dependencies in pom.xml > * Add exclusions in hadoop-two-compat.xml to prevent jersey1 jars in lib dir -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18518) Remove jersey1* dependencies form project and jersey1* jars from lib dir
[ https://issues.apache.org/jira/browse/HBASE-18518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115504#comment-16115504 ] Mike Drob commented on HBASE-18518: --- Also, do we need to make changes in the hbase-rest/pom.xml to specify the correct version of jersey? Where do we need the transitive hadoop jersey available? > Remove jersey1* dependencies form project and jersey1* jars from lib dir > > > Key: HBASE-18518 > URL: https://issues.apache.org/jira/browse/HBASE-18518 > Project: HBase > Issue Type: Task > Components: dependencies, pom, REST >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Samir Ahmic >Assignee: Samir Ahmic > Labels: cleanup > Fix For: 3.0.0 > > Attachments: HBASE-18518-master-01.patch > > > Recently i have opened https://issues.apache.org/jira/browse/HBASE-18506 and > it is clear that is caused by mixing jersey1 and jersey2 jars in classpath. > With https://issues.apache.org/jira/browse/HBASE-12894 we have introduced > jersey2 to project, and we also have bunch of transitive dependencies > (mainly from hadoop) on jersey1 which is not happiest situation since jersey1 > and jersey2 under same classpath can case runtime issues as it was case with > rest. > This task will have following steps > * Clean code and replace jersey1 constructs with jersey2 versions(there > should not be much of this) > * Add exclusions for transitive jersey1 dependencies in pom.xml > * Add exclusions in hadoop-two-compat.xml to prevent jersey1 jars in lib dir -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18518) Remove jersey1* dependencies form project and jersey1* jars from lib dir
[ https://issues.apache.org/jira/browse/HBASE-18518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115496#comment-16115496 ] Samir Ahmic commented on HBASE-18518: - Sure thing [~mdrob]. I will revisit tests to check how change impact them. > Remove jersey1* dependencies form project and jersey1* jars from lib dir > > > Key: HBASE-18518 > URL: https://issues.apache.org/jira/browse/HBASE-18518 > Project: HBase > Issue Type: Task > Components: dependencies, pom, REST >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Samir Ahmic >Assignee: Samir Ahmic > Labels: cleanup > Fix For: 3.0.0 > > Attachments: HBASE-18518-master-01.patch > > > Recently i have opened https://issues.apache.org/jira/browse/HBASE-18506 and > it is clear that is caused by mixing jersey1 and jersey2 jars in classpath. > With https://issues.apache.org/jira/browse/HBASE-12894 we have introduced > jersey2 to project, and we also have bunch of transitive dependencies > (mainly from hadoop) on jersey1 which is not happiest situation since jersey1 > and jersey2 under same classpath can case runtime issues as it was case with > rest. > This task will have following steps > * Clean code and replace jersey1 constructs with jersey2 versions(there > should not be much of this) > * Add exclusions for transitive jersey1 dependencies in pom.xml > * Add exclusions in hadoop-two-compat.xml to prevent jersey1 jars in lib dir -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18518) Remove jersey1* dependencies form project and jersey1* jars from lib dir
[ https://issues.apache.org/jira/browse/HBASE-18518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115494#comment-16115494 ] Mike Drob commented on HBASE-18518: --- The NPE in the tests looks like it is probably related. Can you take a look [~asamir]? > Remove jersey1* dependencies form project and jersey1* jars from lib dir > > > Key: HBASE-18518 > URL: https://issues.apache.org/jira/browse/HBASE-18518 > Project: HBase > Issue Type: Task > Components: dependencies, pom, REST >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Samir Ahmic >Assignee: Samir Ahmic > Labels: cleanup > Fix For: 3.0.0 > > Attachments: HBASE-18518-master-01.patch > > > Recently i have opened https://issues.apache.org/jira/browse/HBASE-18506 and > it is clear that is caused by mixing jersey1 and jersey2 jars in classpath. > With https://issues.apache.org/jira/browse/HBASE-12894 we have introduced > jersey2 to project, and we also have bunch of transitive dependencies > (mainly from hadoop) on jersey1 which is not happiest situation since jersey1 > and jersey2 under same classpath can case runtime issues as it was case with > rest. > This task will have following steps > * Clean code and replace jersey1 constructs with jersey2 versions(there > should not be much of this) > * Add exclusions for transitive jersey1 dependencies in pom.xml > * Add exclusions in hadoop-two-compat.xml to prevent jersey1 jars in lib dir -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18518) Remove jersey1* dependencies form project and jersey1* jars from lib dir
[
https://issues.apache.org/jira/browse/HBASE-18518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115478#comment-16115478
]
Hadoop QA commented on HBASE-18518:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
42s{color} | {color:red} hbase-rest in master has 3 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 4s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
18s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 20s{color}
| {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
17s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 53m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rest.TestVersionResource |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18518 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12880531/HBASE-18518-master-01.patch
|
| Optional Tests | asflicense javac javadoc unit xml findbugs
hadoopcheck hbaseanti
[jira] [Commented] (HBASE-18518) Remove jersey1* dependencies form project and jersey1* jars from lib dir
[ https://issues.apache.org/jira/browse/HBASE-18518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115419#comment-16115419 ] Samir Ahmic commented on HBASE-18518: - Here is patch fixing issue with mixed jersey1 and jersey2 classes on REST project. After some digging i have find that we were using jersey1 classes only on few places in hbase code, main source of jersey1 dependency is hadoop and can not be removed completely since we are using it during testing in HBaseTestingUtility#startMiniDFSCluster() and similar functions which requires starting hadoop processes. This patch also resolves https://issues.apache.org/jira/browse/HBASE-18506. And i will resolve it once we finish work here > Remove jersey1* dependencies form project and jersey1* jars from lib dir > > > Key: HBASE-18518 > URL: https://issues.apache.org/jira/browse/HBASE-18518 > Project: HBase > Issue Type: Task > Components: dependencies, pom, REST >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Samir Ahmic >Assignee: Samir Ahmic > Labels: cleanup > Attachments: HBASE-18518-master-01.patch > > > Recently i have opened https://issues.apache.org/jira/browse/HBASE-18506 and > it is clear that is caused by mixing jersey1 and jersey2 jars in classpath. > With https://issues.apache.org/jira/browse/HBASE-12894 we have introduced > jersey2 to project, and we also have bunch of transitive dependencies > (mainly from hadoop) on jersey1 which is not happiest situation since jersey1 > and jersey2 under same classpath can case runtime issues as it was case with > rest. > This task will have following steps > * Clean code and replace jersey1 constructs with jersey2 versions(there > should not be much of this) > * Add exclusions for transitive jersey1 dependencies in pom.xml > * Add exclusions in hadoop-two-compat.xml to prevent jersey1 jars in lib dir -- This message was sent by Atlassian JIRA (v6.4.14#64029)
