[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131152#comment-16131152
 ] 

Hudson commented on HBASE-18587:


FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See 
[https://builds.apache.org/job/HBASE-14070.HLC/233/])
HBASE-18587 Fix flaky TestFileIOEngine (stack: rev 
5280c100ff93f65cd568ce830e088cc12a2f5585)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestFileIOEngine.java


> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0, 1.4.0, 1.3.2
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129690#comment-16129690
 ] 

Hudson commented on HBASE-18587:


FAILURE: Integrated in Jenkins build HBase-1.5 #11 (See 
[https://builds.apache.org/job/HBase-1.5/11/])
HBASE-18587 Fix flaky TestFileIOEngine (stack: rev 
1f1ab8c873b193675766969df83db91213137d72)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestFileIOEngine.java


> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0, 1.4.0, 1.3.2
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129671#comment-16129671
 ] 

Hudson commented on HBASE-18587:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #249 (See 
[https://builds.apache.org/job/HBase-1.3-JDK8/249/])
HBASE-18587 Fix flaky TestFileIOEngine (stack: rev 
2fd2b3f9b86509c37a7ed22eb93bf1c493711739)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestFileIOEngine.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java


> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0, 1.4.0, 1.3.2
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129670#comment-16129670
 ] 

Hudson commented on HBASE-18587:


FAILURE: Integrated in Jenkins build HBase-1.4 #864 (See 
[https://builds.apache.org/job/HBase-1.4/864/])
HBASE-18587 Fix flaky TestFileIOEngine (stack: rev 
255319a0e680ce15c8179c54743e9ad4d343cadb)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestFileIOEngine.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java


> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0, 1.4.0, 1.3.2
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129516#comment-16129516
 ] 

Hudson commented on HBASE-18587:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #170 (See 
[https://builds.apache.org/job/HBase-1.3-IT/170/])
HBASE-18587 Fix flaky TestFileIOEngine (stack: rev 
2fd2b3f9b86509c37a7ed22eb93bf1c493711739)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestFileIOEngine.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java


> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0, 1.4.0, 1.3.2
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129510#comment-16129510
 ] 

Hudson commented on HBASE-18587:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #236 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/236/])
HBASE-18587 Fix flaky TestFileIOEngine (stack: rev 
2fd2b3f9b86509c37a7ed22eb93bf1c493711739)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestFileIOEngine.java


> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0, 1.4.0, 1.3.2
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-15 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128330#comment-16128330
 ] 

ramkrishna.s.vasudevan commented on HBASE-18587:


Belated  +1.

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128304#comment-16128304
 ] 

Hudson commented on HBASE-18587:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3540 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3540/])
HBASE-18587 Fix flaky TestFileIOEngine (stack: rev 
5280c100ff93f65cd568ce830e088cc12a2f5585)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestFileIOEngine.java


> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128276#comment-16128276
 ] 

Hudson commented on HBASE-18587:


FAILURE: Integrated in Jenkins build HBase-2.0 #337 (See 
[https://builds.apache.org/job/HBase-2.0/337/])
HBASE-18587 Fix flaky TestFileIOEngine (stack: rev 
49ca224fc37ba763229eae44e4df3f0e0bceb9b8)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestFileIOEngine.java


> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-15 Thread Zach York (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127945#comment-16127945
 ] 

Zach York commented on HBASE-18587:
---

[~stack] I have a patch on this JIRA for branch-1.

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-15 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127941#comment-16127941
 ] 

stack commented on HBASE-18587:
---

[~zyork] Thanks sir. I pushed to master and branch-2. The backport to branch-1 
is ugly. If you put up a patch I'll apply it there too. Thanks.

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Fix For: 2.0.0
>
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-15 Thread Zach York (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127874#comment-16127874
 ] 

Zach York commented on HBASE-18587:
---

Stack, since this is a test fix, I'd assume we'd want it on all applicable 
branches

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch, 
> HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127873#comment-16127873
 ] 

Hadoop QA commented on HBASE-18587:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
37m 55s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}148m 
14s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}206m 49s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18587 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881974/HBASE-18587.master.002.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 0d500fad838f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / effd109 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8094/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8094/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> 

[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-14 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126464#comment-16126464
 ] 

Hadoop QA commented on HBASE-18587:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
10s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 3s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
20s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
19s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
32s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
18m  2s{color} | {color:green} The patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}108m 25s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}143m 25s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestClientScannerRPCTimeout |
|   | hadoop.hbase.TestZooKeeper |
|   | hadoop.hbase.regionserver.TestCompactionInDeadRegionServer |
|   | hadoop.hbase.master.TestMasterFailover |
| Timed out junit tests | org.apache.hadoop.hbase.security.access.TestCellACLs |
|   | org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:6f1cc2c |
| JIRA Issue | HBASE-18587 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881809/HBASE-18587.branch-1.002.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  

[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-14 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126379#comment-16126379
 ] 

Chia-Ping Tsai commented on HBASE-18587:


+1

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-14 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126344#comment-16126344
 ] 

Ted Yu commented on HBASE-18587:


Good by me.

See if Chia-ping has other comments.

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-14 Thread Zach York (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126260#comment-16126260
 ] 

Zach York commented on HBASE-18587:
---

[~tedyu] I have updated the patch to remove the constant naming for 
boundaryStartPositions and boundaryStopPositions.

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.branch-1.002.patch, HBASE-18587.master.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.002.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-14 Thread Zach York (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125966#comment-16125966
 ] 

Zach York commented on HBASE-18587:
---

bq. The ut "testFileIOEngineHandlesZeroLengthInput" is good, but why do we need 
the other changes of TestFileIOEngine?

The changes are needed to TestFileIOEngine because the test will randomly fail 
in certain conditions:
len = 0 and offset 0; it will fail for 
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
 will pass in -1 for offset which is invalid.
len = 0 and i = 13; it will try to specify an offset of the totalCapacity which 
is not allowed.

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.001.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125070#comment-16125070
 ] 

Hadoop QA commented on HBASE-18587:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
33m  0s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}112m 
40s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}161m 26s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18587 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881663/HBASE-18587.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux f0c505ed718c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / c6ac04a |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8065/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8065/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.master.001.patch, HBASE-18587.master.001.patch
>
>
> As a part of 

[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-13 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124996#comment-16124996
 ] 

Chia-Ping Tsai commented on HBASE-18587:


The ut "testFileIOEngineHandlesZeroLengthInput" is good, but why do we need the 
other changes of TestFileIOEngine?

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.master.001.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-13 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124917#comment-16124917
 ] 

Ted Yu commented on HBASE-18587:


{code}
+  BOUNDARY_START_POSITIONS.add(SIZE_PER_FILE * i - 1);
{code}
Since BOUNDARY_START_POSITIONS is modified, please restore the original 
spelling.

> Fix Flaky TestFileIOEngine
> --
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache, test
>Reporter: Zach York
>Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch, 
> HBASE-18587.master.001.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine 
> failed. I investigated and noticed that there are two cases where this test 
> is flaky:
> len = 0 and offset 0; it will fail for 
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
>  will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity 
> which is not allowed.
>  
> This patch fixes this test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18587) Fix Flaky TestFileIOEngine

2017-08-12 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124774#comment-16124774
 ] 

Hadoop QA commented on HBASE-18587:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
37m 50s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 67m 31s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
32s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}124m 58s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
|   | org.apache.hadoop.hbase.client.TestScanWithoutFetchingData |
|   | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay |
|   | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
|   | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
|   | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
|   | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
|   | org.apache.hadoop.hbase.regionserver.TestRowTooBig |
|   | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker |
|   | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay |
|   | org.apache.hadoop.hbase.mapreduce.TestWALPlayer |
|   | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
|   | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy 
|
|   | org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner |
|   | org.apache.hadoop.hbase.mapreduce.TestTableInputFormat |
|   | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
|   | org.apache.hadoop.hbase.client.TestFromClientSide |
|   | org.apache.hadoop.hbase.client.TestMultipleTimestamps |
|   | org.apache.hadoop.hbase.client.TestAsyncTableScanAll |
|   | org.apache.hadoop.hbase.client.TestAsyncReplicationAdminApi |
|   | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
|   | org.apache.hadoop.hbase.trace.TestHTraceHooks |
|   |