[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414974#comment-16414974
]
stack commented on HBASE-19035:
---
Late to the game, but confirming that the changes where we moved the scan
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275752#comment-16275752
]
Hudson commented on HBASE-19035:
FAILURE: Integrated in Jenkins build HBase-1.4 #1045 (See
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268426#comment-16268426
]
Hadoop QA commented on HBASE-19035:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268137#comment-16268137
]
stack commented on HBASE-19035:
---
Here is a patch for branch-1.2 after the HBASE-19354 commit, which
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263689#comment-16263689
]
Guanghao Zhang commented on HBASE-19035:
The branch-1 HADOOP QA build timeout See
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255613#comment-16255613
]
stack commented on HBASE-19035:
---
[~zghaobac] I missed that. Thanks for setting me right.
> Miss metrics
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254914#comment-16254914
]
Hadoop QA commented on HBASE-19035:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254909#comment-16254909
]
Guanghao Zhang commented on HBASE-19035:
[~stack] I already pushed this to master and branch-2.
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249286#comment-16249286
]
Hadoop QA commented on HBASE-19035:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248834#comment-16248834
]
Hudson commented on HBASE-19035:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4041 (See
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248819#comment-16248819
]
Hudson commented on HBASE-19035:
FAILURE: Integrated in Jenkins build HBase-2.0 #841 (See
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248805#comment-16248805
]
Guanghao Zhang commented on HBASE-19035:
Pushed to master and branch-2. Thanks all for reviewing.
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248802#comment-16248802
]
Guanghao Zhang commented on HBASE-19035:
TestHTraceHooks is not related. And it failed on master
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248794#comment-16248794
]
Hadoop QA commented on HBASE-19035:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246646#comment-16246646
]
stack commented on HBASE-19035:
---
Carrying my +1 over from rb. Needs release note. Nice work [~zghaobac]
>
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240235#comment-16240235
]
Guanghao Zhang commented on HBASE-19035:
Upload to review board:
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239818#comment-16239818
]
Anoop Sam John commented on HBASE-19035:
I see. So those were already in place. COuld not see in
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239486#comment-16239486
]
Guanghao Zhang commented on HBASE-19035:
bq. What updation of writeRequestsCount when
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239468#comment-16239468
]
Anoop Sam John commented on HBASE-19035:
What updation of writeRequestsCount when
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238974#comment-16238974
]
Duo Zhang commented on HBASE-19035:
---
I'm +1 with this approach. [~stack] what's your plan sir? Thanks.
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238700#comment-16238700
]
Guanghao Zhang commented on HBASE-19035:
Ping [~stack] [~anoop.hbase] [~Apache9] for reviewing.
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225980#comment-16225980
]
stack commented on HBASE-19035:
---
[~zghaobac] We still need this it looks like. The philosophy is not to
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224739#comment-16224739
]
Hadoop QA commented on HBASE-19035:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221801#comment-16221801
]
Anoop Sam John commented on HBASE-19035:
+1. Lets unify it where the metrics are updated. For
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221784#comment-16221784
]
Duo Zhang commented on HBASE-19035:
---
+1 on moving the metrics update for scan into RegionScanner
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221775#comment-16221775
]
stack commented on HBASE-19035:
---
[~zghaobac] We are trying to make it so CPs can not update Metrics. Thats
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221763#comment-16221763
]
Guanghao Zhang commented on HBASE-19035:
bq. That might be double update issue.
Yes. This is a
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210616#comment-16210616
]
Anoop Sam John commented on HBASE-19035:
Ya I was abt to ask this Q on other issue comments..
[
https://issues.apache.org/jira/browse/HBASE-19035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209110#comment-16209110
]
Duo Zhang commented on HBASE-19035:
---
[~stack] [~apurtell] I think this is related to whether we should
29 matches
Mail list logo