[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385930#comment-16385930
]
Csaba Skrabak commented on HBASE-19114:
---
[~appy], thanks for committing.
> Split out
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385118#comment-16385118
]
Hudson commented on HBASE-19114:
Results for branch master, done in 4 hr 28 min and counting
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384854#comment-16384854
]
Hudson commented on HBASE-19114:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4684 (See
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384681#comment-16384681
]
Appy commented on HBASE-19114:
--
Sorry on my part for missing out those ones.
Thanks for the followup
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257656#comment-16257656
]
Hudson commented on HBASE-19114:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4070 (See
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257588#comment-16257588
]
Appy commented on HBASE-19114:
--
+1 unit. Committing.
Like mentioned earlier, checkstyle errors are getting
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257577#comment-16257577
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257448#comment-16257448
]
Appy commented on HBASE-19114:
--
Pretty sure all the failures are flukes - different tests failing, and
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256371#comment-16256371
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256132#comment-16256132
]
Appy commented on HBASE-19114:
--
Thanks [~stack].
Looking at test failures. Second last QA gave +1unit and
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254892#comment-16254892
]
stack commented on HBASE-19114:
---
Go for it I'd say [~appy] commit after doing check of the root test
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254764#comment-16254764
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254581#comment-16254581
]
Appy commented on HBASE-19114:
--
Tests passed.
checkstyles are mostly because of moving classes from one
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254537#comment-16254537
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253935#comment-16253935
]
Appy commented on HBASE-19114:
--
[~psomogyi], you're right, should have one. Added a TODO in placeholder,
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253054#comment-16253054
]
Duo Zhang commented on HBASE-19114:
---
My only concern before is we should not add more dependencies for
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253044#comment-16253044
]
Peter Somogyi commented on HBASE-19114:
---
Is release note needed for this change?
> Split out
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252822#comment-16252822
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252702#comment-16252702
]
Appy commented on HBASE-19114:
--
Coming back here after our discussion on HBASE-19200.
hbase-client doesn't
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245223#comment-16245223
]
stack commented on HBASE-19114:
---
H. I like this patch (Not sure about hbase-common depending on
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233562#comment-16233562
]
Duo Zhang commented on HBASE-19114:
---
{quote}
It has all zk stuff, from both client and server. So even
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233546#comment-16233546
]
Appy commented on HBASE-19114:
--
But i'd still like to understand what was I missing!
bq. ...future
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233530#comment-16233530
]
Appy commented on HBASE-19114:
--
I don't completely understand it, but your last comment suggests that this
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16232593#comment-16232593
]
Duo Zhang commented on HBASE-19114:
---
Then if someone depends netty-all while others depend the
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227804#comment-16227804
]
Appy commented on HBASE-19114:
--
bq. I do not think people will like multi modules, for example, we always
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227748#comment-16227748
]
Duo Zhang commented on HBASE-19114:
---
I do not think people will like multi modules, for example, we
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227693#comment-16227693
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227403#comment-16227403
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227032#comment-16227032
]
stack commented on HBASE-19114:
---
I'd be +1 for this change (+1'd it up on rb) because it moves code out of
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227010#comment-16227010
]
stack commented on HBASE-19114:
---
[~appy] Would breaking out the module help with undoing our zk dependency
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227003#comment-16227003
]
Appy commented on HBASE-19114:
--
Please ignore checkstyle issues in dependency refactoring patches since
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226978#comment-16226978
]
Appy commented on HBASE-19114:
--
One of the golden goals would be, no hbase-server module, but separate
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226965#comment-16226965
]
Appy commented on HBASE-19114:
--
bq. ... most zk related code will be in hbase-server...
That's what we are
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226312#comment-16226312
]
Duo Zhang commented on HBASE-19114:
---
Do we really need to do this?
We are trying hard to reduce the
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226243#comment-16226243
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223842#comment-16223842
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223127#comment-16223127
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
37 matches
Mail list logo
