[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236119#comment-16236119
]
Hudson commented on HBASE-19118:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1000 (See
[https://builds.apache.org/job/HBase-1.2-IT/1000/])
HBASE-19118 Use SaslUtil to set Sasl.QOP in 'Thrift' (elserj: rev
5c3db2b41202df28f4562fb57697e475b0420d62)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.3.3
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236118#comment-16236118
]
Hudson commented on HBASE-19118:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #329 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/329/])
HBASE-19118 Use SaslUtil to set Sasl.QOP in 'Thrift' (elserj: rev
b0f16d96f92bf8aa6d8030b47a372b7a35f17a09)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.3.3
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236114#comment-16236114
]
Hudson commented on HBASE-19118:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #266 (See
[https://builds.apache.org/job/HBase-1.3-IT/266/])
HBASE-19118 Use SaslUtil to set Sasl.QOP in 'Thrift' (elserj: rev
b0f16d96f92bf8aa6d8030b47a372b7a35f17a09)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.3.3
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236085#comment-16236085
]
Hudson commented on HBASE-19118:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #346 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/346/])
HBASE-19118 Use SaslUtil to set Sasl.QOP in 'Thrift' (elserj: rev
b0f16d96f92bf8aa6d8030b47a372b7a35f17a09)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.3.3
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236078#comment-16236078
]
Hudson commented on HBASE-19118:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #262 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/262/])
HBASE-19118 Use SaslUtil to set Sasl.QOP in 'Thrift' (elserj: rev
5c3db2b41202df28f4562fb57697e475b0420d62)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.3.3
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236077#comment-16236077
]
Hudson commented on HBASE-19118:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #258 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/258/])
HBASE-19118 Use SaslUtil to set Sasl.QOP in 'Thrift' (elserj: rev
5c3db2b41202df28f4562fb57697e475b0420d62)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.3.3
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236044#comment-16236044
]
Hadoop QA commented on HBASE-19118:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
23s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
9s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
25s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} hbase-thrift: The patch generated 0 new + 34
unchanged - 1 fixed = 34 total (was 35) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
37s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}524m 11s{color}
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}569m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:f0e31ea |
| JIRA Issue | HBASE-19118 |
| JIRA Patch URL |
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235984#comment-16235984
]
Reid Chan commented on HBASE-19118:
---
It's fine XD, thanks for your reviews [~elserj]! ping me if it needs a patch
for branch-1.2.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235976#comment-16235976
]
Josh Elser commented on HBASE-19118:
bq. qop accepts two kinds of stringQop as well. I'm not sure if here breaks
backwards compatibility, or else where i overlook.
Sorry, right you are again. I was fooled this time around
{{QualityOfProtection#matches(..)}} method not being there.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235973#comment-16235973
]
Reid Chan commented on HBASE-19118:
---
In branch-1.3 and branch-1.2
{code}
QualityOfProtection qop = null;
if
(QualityOfProtection.AUTHENTICATION.name().toLowerCase().equals(stringQop)
|| QualityOfProtection.AUTHENTICATION.saslQop.equals(stringQop)) {
qop = QualityOfProtection.AUTHENTICATION;
} else if
(QualityOfProtection.INTEGRITY.name().toLowerCase().equals(stringQop)
|| QualityOfProtection.INTEGRITY.saslQop.equals(stringQop)) {
qop = QualityOfProtection.INTEGRITY;
} else if
(QualityOfProtection.PRIVACY.name().toLowerCase().equals(stringQop)
|| QualityOfProtection.PRIVACY.saslQop.equals(stringQop)) {
qop = QualityOfProtection.PRIVACY;
}
{code}
qop accepts two kinds of stringQop as well. I'm not sure if here breaks
backwards compatibility, or else where i overlook.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235901#comment-16235901
]
Reid Chan commented on HBASE-19118:
---
bq. but I think your branch-1.3 breaks backwards compatibility.
Would you mind pointing out? still in {{SaslUtil}}?
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235891#comment-16235891
]
Josh Elser commented on HBASE-19118:
bq. There're few different places in SaslUtil class, so i change codes
carefully in afraid of digging other holes.
Thanks for the path, [~reidchan], but I think your branch-1.3 breaks backwards
compatibility.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235412#comment-16235412
]
Hudson commented on HBASE-19118:
SUCCESS: Integrated in Jenkins build HBase-2.0 #784 (See
[https://builds.apache.org/job/HBase-2.0/784/])
HBASE-19118 Use SaslUtil to set Sasl.QOP in 'Thrift' (elserj: rev
e61606231f6d1da39c1d5d0fd078e6fb8c9ac626)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235355#comment-16235355
]
Hudson commented on HBASE-19118:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3984 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3984/])
HBASE-19118 Use SaslUtil to set Sasl.QOP in 'Thrift' (elserj: rev
49abc2e1c281665a23ee3b1bf8b6040eeebe47b0)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235307#comment-16235307
]
Hudson commented on HBASE-19118:
FAILURE: Integrated in Jenkins build HBase-1.5 #129 (See
[https://builds.apache.org/job/HBase-1.5/129/])
HBASE-19118 Use SaslUtil to set Sasl.QOP in 'Thrift' (elserj: rev
01cb1d99b722bb8dc017726a77e532bfc9a1a6e9)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235290#comment-16235290
]
Reid Chan commented on HBASE-19118:
---
bq. my hunch is that one patch will do it
Yes, i think so.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235271#comment-16235271
]
Reid Chan commented on HBASE-19118:
---
Btw, remove some unused packages
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.branch-1.3.001.patch,
> HBASE-19118.master.001.patch, HBASE-19118.master.002.patch,
> HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235172#comment-16235172
]
Josh Elser commented on HBASE-19118:
[~reidchan], can you take a look at branch-1.2 and branch-1.3 and put a patch
together for those branches, please? (my hunch is that one patch will do it).
I've already pushed to the branches that correspond to the fixVersions I just
set.
Thanks for your work!
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235147#comment-16235147
]
Josh Elser commented on HBASE-19118:
Nope, fine by me. Running through cherry-picking this to all the branches.
Slight conflicts, but easy to fix.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16232725#comment-16232725
]
Reid Chan commented on HBASE-19118:
---
any suggestions? [~elserj]
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226251#comment-16226251
]
Ted Yu commented on HBASE-19118:
lgtm
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226228#comment-16226228
]
Reid Chan commented on HBASE-19118:
---
Yes, successfully.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226221#comment-16226221
]
Reid Chan commented on HBASE-19118:
---
Without this patch, only one of these values: auth/auth-int/auth-conf would
bring up thrift server successfully. Otherwise:
{code}
Exception in thread "main" java.io.IOException: Invalid
hbase.thrift.security.qop: authentication, it must be 'auth', 'auth-int', or
'auth-conf'
at
org.apache.hadoop.hbase.thrift.ThriftServerRunner.(ThriftServerRunner.java:333)
at
org.apache.hadoop.hbase.thrift.ThriftServer.doMain(ThriftServer.java:95)
at
org.apache.hadoop.hbase.thrift.ThriftServer.main(ThriftServer.java:240)
{code}
With this patch, "auth/auth-int/auth-conf" or
"authentication/integrity/privacy" works the same.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226211#comment-16226211
]
Josh Elser commented on HBASE-19118:
Ahh, sorry about that. I see that on second glance. I was mislead by the
following :)
{noformat}
+ if (qop != QualityOfProtection.AUTHENTICATION &&
+ qop != QualityOfProtection.INTEGRITY &&
+ qop != QualityOfProtection.PRIVACY) {
{noformat}
bq. I'm not sure there's a unit test for kerberized thrift server, but i'm
sure there's an example DemoClient in hbase-example which i'm using as a test.
A shame if we don't have one :(. You've tested by hand with the old and new
properties successfully?
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226206#comment-16226206
]
Reid Chan commented on HBASE-19118:
---
Thanks for reply! [~elserj]
In {{SaslUtil}}
{code}
public boolean matches(String stringQop) {
if (saslQop.equals(stringQop)) {
LOG.warn("Use authentication/integrity/privacy as value for rpc
protection "
+ "configurations instead of auth/auth-int/auth-conf.");
return true;
}
return name().equalsIgnoreCase(stringQop);
}
{code}
So, it will not break up BC.
I'm not sure there's a unit test for kerberized thrift server, but i'm sure
there's an example {{DemoClient}} in hbase-example which i'm using as a test.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226200#comment-16226200
]
Josh Elser commented on HBASE-19118:
[~reidchan], while I agree with your choice in making the Thrift QoP properties
the same as the RPC server's QoP properties, could you fix this in a backwards
compatible way? It would be a shame to break someone with an functioning
configuration for the sake of a bug-fix.
We don't have any tests that set up a Thrift server with security?
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226121#comment-16226121
]
Reid Chan commented on HBASE-19118:
---
ping [~tedyu] [~chia7712], would you have time to give a review?
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224655#comment-16224655
]
Reid Chan commented on HBASE-19118:
---
Can anyone give a review? Thanks in advance.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch, HBASE-19118.master.003.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224648#comment-16224648
]
Hadoop QA commented on HBASE-19118:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
8s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
46m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
43s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 65m 19s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19118 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894710/HBASE-19118.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 8e68664f7c26 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e0a530e714 |
| Default Java | 1.8.0_141 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9510/testReport/ |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9510/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL:
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224536#comment-16224536
]
Hadoop QA commented on HBASE-19118:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
28s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
18s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
26s{color} | {color:red} hbase-thrift: The patch generated 2 new + 37 unchanged
- 0 fixed = 39 total (was 37) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
44s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
54m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
31s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 74m 43s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19118 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894694/HBASE-19118.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 300922b7fdfe 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / e0a530e714 |
| Default Java | 1.8.0_141 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9505/artifact/patchprocess/diff-checkstyle-hbase-thrift.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9505/testReport/ |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9505/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224476#comment-16224476
]
Reid Chan commented on HBASE-19118:
---
No unit tests.
> Use SaslUtil to set Sasl.QOP in 'Thrift'
>
>
> Key: HBASE-19118
> URL: https://issues.apache.org/jira/browse/HBASE-19118
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 1.2.6
>Reporter: Reid Chan
>Assignee: Reid Chan
> Attachments: HBASE-19118.master.001.patch,
> HBASE-19118.master.002.patch
>
>
> In [Configure the Thrift
> Gateway|http://hbase.apache.org/book.html#security.client.thrift], it says
> "set the property {{hbase.thrift.security.qop}} to one of the following three
> values: {{privacy}}, {{integrity}}, {{authentication}}", which would lead to
> failure of starting up a thrift server.
> In fact, the value of {{hbase.thrift.security.qop}} should be {{auth}},
> {{auth-int}}, {{auth-conf}}, according to the documentation of {{Sasl.QOP}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'
[
https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1622#comment-1622
]
Hadoop QA commented on HBASE-19118:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
31s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 4m
50s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
18s{color} | {color:red} hbase-thrift in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 18s{color}
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
24s{color} | {color:red} hbase-thrift: The patch generated 1 new + 0 unchanged
- 37 fixed = 1 total (was 37) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
2s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
16s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m
26s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m
36s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 13m
47s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 15m
58s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 18m
7s{color} | {color:red} The patch causes 16 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 20m
20s{color} | {color:red} The patch causes 16 errors with Hadoop v2.7.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 22m
32s{color} | {color:red} The patch causes 16 errors with Hadoop v2.7.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 24m
47s{color} | {color:red} The patch causes 16 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
13s{color} | {color:red} hbase-thrift in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 18s{color}
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
|
