[jira] [Commented] (HBASE-19827) Addendum for Flakey TestAssignmentManager
[ https://issues.apache.org/jira/browse/HBASE-19827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333010#comment-16333010 ] Hudson commented on HBASE-19827: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4432 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4432/]) HBASE-19827 Addendum for Flakey TestAssignmentManager Don't clear old (stack: rev fa66c7e28e886857204dc2ce10f65b5fe264564b) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java Revert "HBASE-19827 Addendum for Flakey TestAssignmentManager" Premature (stack: rev c66b42fd9d1e4336352edf6851e4caa2ce0295d1) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java > Addendum for Flakey TestAssignmentManager > - > > Key: HBASE-19827 > URL: https://issues.apache.org/jira/browse/HBASE-19827 > Project: HBase > Issue Type: Sub-task > Components: flakey, test >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19827.master.001.patch, > HBASE-19827.master.002.patch > > > Addendum for parent. Rather than reopen parent for third time, doing subtask. > So, in parent, we committed two fixes for failures seen in the random > assignment test portion of TestAssignmentManager. The second fix almost works > but in operation, a vital piece of info has been cleared because of the order > in which stuff runs. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19827) Addendum for Flakey TestAssignmentManager
[
https://issues.apache.org/jira/browse/HBASE-19827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332908#comment-16332908
]
Hadoop QA commented on HBASE-19827:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
9s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s{color} | {color:green} hbase-server: The patch generated 0 new + 57
unchanged - 1 fixed = 57 total (was 58) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
11s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 38s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 92m
32s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}130m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19827 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12906872/HBASE-19827.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 23611b841b6c 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 9ba961a5ef |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11132/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11132/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Addendum for Flakey
[jira] [Commented] (HBASE-19827) Addendum for Flakey TestAssignmentManager
[ https://issues.apache.org/jira/browse/HBASE-19827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332777#comment-16332777 ] stack commented on HBASE-19827: --- Its hard to write a test for this. Have to have an ongoing, hanging RPC and then concurrently run the servercrashprocedure. There are timing and correct context issues hard to conjure. This TestAM#testAssignWithRandExec makes it happen every third run. > Addendum for Flakey TestAssignmentManager > - > > Key: HBASE-19827 > URL: https://issues.apache.org/jira/browse/HBASE-19827 > Project: HBase > Issue Type: Sub-task > Components: flakey, test >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19827.master.001.patch, > HBASE-19827.master.002.patch > > > Addendum for parent. Rather than reopen parent for third time, doing subtask. > So, in parent, we committed two fixes for failures seen in the random > assignment test portion of TestAssignmentManager. The second fix almost works > but in operation, a vital piece of info has been cleared because of the order > in which stuff runs. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19827) Addendum for Flakey TestAssignmentManager
[ https://issues.apache.org/jira/browse/HBASE-19827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332767#comment-16332767 ] stack commented on HBASE-19827: --- In a recent flakey report [1], there is the tell-tale line: 2018-01-19 17:12:51,915 WARN [ProcExecWrkr-15] procedure.RecoverMetaProcedure(174): RIT with ServerName null! pid=5, ppid=4, state=RUNNABLE:REGION_TRANSITION_DISPATCH; AssignProcedure table=hbase:meta, region=1588230740 This says that the new handleRIT code for meta added by parent issue has been triggered but we fail at the last stage because the vital ServerName is missing; it was actually cleared just before we started up the RecoverMetaProcedure by the ServerCrashProcedure. This patch removes that single line. 1. https://builds.apache.org/job/HBASE-Flaky-Tests-branch2.0/417/testReport/junit/org.apache.hadoop.hbase.master.assignment/TestAssignmentManager/testAssignWithRandExec/ > Addendum for Flakey TestAssignmentManager > - > > Key: HBASE-19827 > URL: https://issues.apache.org/jira/browse/HBASE-19827 > Project: HBase > Issue Type: Sub-task > Components: flakey, test >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19827.master.001.patch, > HBASE-19827.master.002.patch > > > Addendum for parent. Rather than reopen parent for third time, doing subtask. > So, in parent, we committed two fixes for failures seen in the random > assignment test portion of TestAssignmentManager. The second fix almost works > but in operation, a vital piece of info has been cleared because of the order > in which stuff runs. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
