[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354479#comment-16354479
]
Mike Drob commented on HBASE-19841:
---
bq. Agree. Revert suggestion was made before analysis on what was
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354339#comment-16354339
]
stack commented on HBASE-19841:
---
bq. I'd rather not revert this, as I think there is some gymnastics we can
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354315#comment-16354315
]
Mike Drob commented on HBASE-19841:
---
I'd rather not revert this, as I think there is some gymnastics we
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354151#comment-16354151
]
Mike Drob commented on HBASE-19841:
---
Ok, I understand what you're describing.
Integration tests can
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353436#comment-16353436
]
stack commented on HBASE-19841:
---
(Took a while to track down...). The job that fails is the launch of ITBLL
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353206#comment-16353206
]
Mike Drob commented on HBASE-19841:
---
Thanks for reporting, [~stack]. I'm confused as to how this
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349986#comment-16349986
]
Hudson commented on HBASE-19841:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4512 (See
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349591#comment-16349591
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349361#comment-16349361
]
stack commented on HBASE-19841:
---
bq. I found them based on which tests were failing!
Excellent.
+1 on
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349319#comment-16349319
]
Mike Drob commented on HBASE-19841:
---
I found them based on which tests were failing!
> Tests against
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349302#comment-16349302
]
stack commented on HBASE-19841:
---
Retry. At least one of the test failures should be fixed now and log
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348984#comment-16348984
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347287#comment-16347287
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347052#comment-16347052
]
Mike Drob commented on HBASE-19841:
---
I think that v9 run was one that started before my v10 run, we
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346221#comment-16346221
]
stack commented on HBASE-19841:
---
Starts out with "java.lang.OutOfMemoryError: unable to create new native
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346202#comment-16346202
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346187#comment-16346187
]
Mike Drob commented on HBASE-19841:
---
v11: fixed checkstyle issues. failing tests passed locally for me,
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346005#comment-16346005
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345922#comment-16345922
]
Mike Drob commented on HBASE-19841:
---
v10: fix the Trace stuff that I pulled out earlier
> Tests
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345894#comment-16345894
]
Mike Drob commented on HBASE-19841:
---
v9: fix an NPE that I missed earlier
> Tests against hadoop3 fail
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345817#comment-16345817
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345780#comment-16345780
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345740#comment-16345740
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345669#comment-16345669
]
stack commented on HBASE-19841:
---
[~mdrob] ok boss. Will go play elsewhere sir.
> Tests against hadoop3
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345665#comment-16345665
]
stack commented on HBASE-19841:
---
Retry. Added count of open fds, uptime, and ulimit -l to test output...
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345652#comment-16345652
]
Mike Drob commented on HBASE-19841:
---
I'm still getting some errors locally, will need to iterate a bit
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345644#comment-16345644
]
stack commented on HBASE-19841:
---
Retry. Patch failed run on H0 with OOME, can't create threads. Looking at
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345594#comment-16345594
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345281#comment-16345281
]
Mike Drob commented on HBASE-19841:
---
v8: Getting a few more unit tests.
> Tests against hadoop3 fail
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344156#comment-16344156
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344009#comment-16344009
]
stack commented on HBASE-19841:
---
+1 on patch.
I like the clean exposition on diff between local and
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343971#comment-16343971
]
Mike Drob commented on HBASE-19841:
---
new patch, much slimmer.
Let's let HTU act like a local cluster
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341916#comment-16341916
]
Hudson commented on HBASE-19841:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4474 (See
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341788#comment-16341788
]
Hudson commented on HBASE-19841:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4473 (See
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341688#comment-16341688
]
Mike Drob commented on HBASE-19841:
---
There's a lot of failure on branch-2, I'm going to revert this
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341269#comment-16341269
]
Mike Drob commented on HBASE-19841:
---
v7 is what I pushed to master. It's just like v6 but removes
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340247#comment-16340247
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339714#comment-16339714
]
Josh Elser commented on HBASE-19841:
Ahhh, of course. Thanks for that explanation.
+1 on Precommit
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339637#comment-16339637
]
Mike Drob commented on HBASE-19841:
---
There's a file system cache, so when you call get FileSystem, you
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339476#comment-16339476
]
Josh Elser commented on HBASE-19841:
{code}
diff --git
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339363#comment-16339363
]
Mike Drob commented on HBASE-19841:
---
summoning mighty [~elserj] for review
> Tests against hadoop3
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338449#comment-16338449
]
Ted Yu commented on HBASE-19841:
Josh is in better position to provide review of the attached patches.
>
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338382#comment-16338382
]
Mike Drob commented on HBASE-19841:
---
[~tedyu] - my proposed approach is very different from your
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338377#comment-16338377
]
Mike Drob commented on HBASE-19841:
---
Also, taking out of patch available until we get a fixed Yetus so
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338375#comment-16338375
]
Mike Drob commented on HBASE-19841:
---
v5: Fixing an NPE and one more test that I missed.
> Tests
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338165#comment-16338165
]
Hadoop QA commented on HBASE-19841:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337976#comment-16337976
]
Mike Drob commented on HBASE-19841:
---
v4 passed all tests against an older master, I'm rebased and
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337173#comment-16337173
]
Hadoop QA commented on HBASE-19841:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337078#comment-16337078
]
Hadoop QA commented on HBASE-19841:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337017#comment-16337017
]
Mike Drob commented on HBASE-19841:
---
Attached a new v3 that demonstrates the direction that I think we
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336932#comment-16336932
]
Ted Yu commented on HBASE-19841:
Refreshed v1 to cover TestDefaultMemStore
> Tests against hadoop3 fail
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336911#comment-16336911
]
Mike Drob commented on HBASE-19841:
---
Actually, just had an idea... Maybe it's better to go with
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336901#comment-16336901
]
Mike Drob commented on HBASE-19841:
---
What is interesting about TestDefaultMemStore is that some methods
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336872#comment-16336872
]
Ted Yu commented on HBASE-19841:
Thanks for the reminder about other tests.
For patch v2, the
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336843#comment-16336843
]
Mike Drob commented on HBASE-19841:
---
bq. Then it seems the current v1 patch is better - no need to
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336777#comment-16336777
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336751#comment-16336751
]
Hadoop QA commented on HBASE-19841:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336580#comment-16336580
]
Ted Yu commented on HBASE-19841:
bq. we have to propagate it back everywhere
Then it seems the current
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336576#comment-16336576
]
Ted Yu commented on HBASE-19841:
For patch v0, we can also create HBaseConfiguration at the beginning of
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336573#comment-16336573
]
Mike Drob commented on HBASE-19841:
---
bq. Why only create HBaseConfiguration for WAL, instead of the
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336562#comment-16336562
]
Ted Yu commented on HBASE-19841:
Patch v0 was the original v1.
> Tests against hadoop3 fail with
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336561#comment-16336561
]
Ted Yu commented on HBASE-19841:
Why only create HBaseConfiguration for WAL, instead of the
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336548#comment-16336548
]
Mike Drob commented on HBASE-19841:
---
Hopefully, it will fix other failures related to WALs as well,
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336546#comment-16336546
]
Mike Drob commented on HBASE-19841:
---
[~tedyu] [~stack] - The first patch was removed so I don't know
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336334#comment-16336334
]
Hadoop QA commented on HBASE-19841:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336271#comment-16336271
]
stack commented on HBASE-19841:
---
Sounds like you do not understand the full implications of your patch
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336226#comment-16336226
]
Ted Yu commented on HBASE-19841:
Mike was the author of the final patch. Josh gave +1 to it.
They would
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336206#comment-16336206
]
stack commented on HBASE-19841:
---
That does not answer my question. My question is why is this config not
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336177#comment-16336177
]
Ted Yu commented on HBASE-19841:
Have you seen
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336165#comment-16336165
]
stack commented on HBASE-19841:
---
{quote}See HBASE-19289 for the introduction of
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336155#comment-16336155
]
Ted Yu commented on HBASE-19841:
Refreshed patch which creates HBaseConfiguration in the setup method.
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336124#comment-16336124
]
stack commented on HBASE-19841:
---
HTU is the HBase testing utility. If it requires hbase-site.xml test
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335992#comment-16335992
]
Ted Yu commented on HBASE-19841:
Looking at similar test failures, e.g.
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335363#comment-16335363
]
stack commented on HBASE-19841:
---
?
Just this one test?
Fix the test?
> Tests against hadoop3 fail
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335272#comment-16335272
]
Ted Yu commented on HBASE-19841:
TestCompactingMemStore#compactingSetUp calls
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335254#comment-16335254
]
Hadoop QA commented on HBASE-19841:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335238#comment-16335238
]
stack commented on HBASE-19841:
---
You are inside in HBaseTestingUtility – THE HBase Testing tool... Under
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335174#comment-16335174
]
Ted Yu commented on HBASE-19841:
The test does this in setup:
{code}
Configuration conf = new
[
https://issues.apache.org/jira/browse/HBASE-19841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335159#comment-16335159
]
stack commented on HBASE-19841:
---
{quote}This was due to "hbase.unsafe.stream.capability.enforce" config
79 matches
Mail list logo
