[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354911#comment-16354911 ] Hudson commented on HBASE-19886: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4540 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4540/]) HBASE-19886 Display maintenance mode in shell, web UI (appy: rev 380083e7d3d9864cacd41a4297914d6789618d78) * (edit) hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon * (edit) hbase-shell/src/main/ruby/shell.rb * (add) hbase-shell/src/main/ruby/shell/commands/is_in_maintenance_mode.rb * (edit) hbase-shell/src/main/ruby/hbase/admin.rb > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0-beta-2, 1.4.2 > > Attachments: HBASE-19886.master.001.patch, > HBASE-19886.master.002.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354682#comment-16354682 ] Appy commented on HBASE-19886: -- Thanks for the fix [~balazs.meszaros] > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0-beta-2, 1.4.2 > > Attachments: HBASE-19886.master.001.patch, > HBASE-19886.master.002.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354678#comment-16354678 ] Appy commented on HBASE-19886: -- Changed method name from is_in_maintenance_mode? to in_maintenance_mode? - as suggested by rubocop. Sadly, can't do anything about other lint errors, it's complaining about our 'norm' - either we should change the norm for better, or mute those errors. For now, i'll ignore it. > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch, > HBASE-19886.master.002.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354666#comment-16354666 ] Appy commented on HBASE-19886: -- Looks good, but what a mouthful command. :) Pushing it to master and branch-2. > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch, > HBASE-19886.master.002.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI
[
https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350166#comment-16350166
]
Hadoop QA commented on HBASE-19886:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
8s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
27s{color} | {color:red} The patch generated 6 new + 407 unchanged - 1 fixed =
413 total (was 408) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
5s{color} | {color:red} The patch generated 3 new + 730 unchanged - 0 fixed =
733 total (was 730) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}105m 34s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
31s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
42s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}127m 15s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.TestFullLogReconstruction |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19886 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12908947/HBASE-19886.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux 6879c1a3bd89 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / fc6d140adf |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| rubocop | v0.52.1 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/11357/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/11357/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/11357/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11357/testReport/ |
| Max. process+thread count | 4970 (vs. ulimit of 1) |
| modules | C: hbase-server hbase-shell U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11357/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Display maintenance mode in shell, web UI
> -
>
> Key: HBASE-19886
> URL: https://issues.apache.org/jira/browse/HBASE-19886
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 2.0.0, 3.0.0, 1.4.2
>
[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349991#comment-16349991 ] Balazs Meszaros commented on HBASE-19886: - Ok, I removed it from metrics. > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch, > HBASE-19886.master.002.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI, JMX
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349790#comment-16349790 ] stack commented on HBASE-19886: --- Is it appropriate having this flag as a metric [~balazs.meszaros]? Thanks. > Display maintenance mode in shell, web UI, JMX > -- > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI, JMX. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI, JMX
[
https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348771#comment-16348771
]
Hadoop QA commented on HBASE-19886:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
13s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
26s{color} | {color:red} The patch generated 7 new + 407 unchanged - 1 fixed =
414 total (was 408) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
4s{color} | {color:red} The patch generated 3 new + 730 unchanged - 0 fixed =
733 total (was 730) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 11s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
25s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
33s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}108m
27s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
46s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}161m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue |
[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI, JMX
[
https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344714#comment-16344714
]
Hadoop QA commented on HBASE-19886:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
52s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
19s{color} | {color:red} hbase-shell in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 19s{color}
| {color:red} hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} The patch hbase-hadoop-compat passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} hbase-hadoop2-compat: The patch generated 0 new + 0
unchanged - 3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} hbase-server: The patch generated 0 new + 0
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} The patch hbase-shell passed checkstyle {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
24s{color} | {color:red} The patch generated 7 new + 407 unchanged - 1 fixed =
414 total (was 408) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
5s{color} | {color:red} The patch generated 3 new + 730 unchanged - 0 fixed =
733 total (was 730) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 0m
19s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
1m 16s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5
2.7.4 or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
19s{color} | {color:red} hbase-hadoop-compat in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
19s{color} | {color:red} hbase-hadoop2-compat in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
19s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
19s{color} | {color:red} hbase-shell in the patch failed.
