[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352035#comment-16352035 ] Hudson commented on HBASE-19917: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4528 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4528/]) HBASE-19917 Improve RSGroupBasedLoadBalancer#filterServers() to be more (tedyu: rev 7f7f2b2de53d11dc8ddde6954a4af3599a9e0fa5) * (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Fix For: 2.0.0-beta-2, 1.4.2 > > Attachments: HBASE-19917.branch-1.000.patch, > HBASE-19917.master.000.patch, HBASE-19917.master.001.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352021#comment-16352021 ] Xiang Li commented on HBASE-19917: -- Hi [~yuzhih...@gmail.com], I uploaded patch 000 for branch-1. Please review it at your most convenience. > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19917.branch-1.000.patch, > HBASE-19917.master.000.patch, HBASE-19917.master.001.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351995#comment-16351995 ] Xiang Li commented on HBASE-19917: -- working on the patch for branch-1. A moment > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19917.master.000.patch, > HBASE-19917.master.001.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351987#comment-16351987 ] Ted Yu commented on HBASE-19917: Can you attach patch for branch-1 ? Thanks > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19917.master.000.patch, > HBASE-19917.master.001.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351962#comment-16351962 ] Hadoop QA commented on HBASE-19917: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 8s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 52s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} hbase-rsgroup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 38s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 18m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 16s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 37m 55s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19917 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12909167/HBASE-19917.master.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b854d93410f1 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / ab5a26ad5e | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/11383/artifact/patchprocess/diff-checkstyle-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11383/testReport/ | | Max. process+thread count | 1533 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output |
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351944#comment-16351944 ] Ted Yu commented on HBASE-19917: lgtm, pending QA > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-19917.master.000.patch, > HBASE-19917.master.001.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351933#comment-16351933 ] Xiang Li commented on HBASE-19917: -- Thanks Ted. I uploaded patch 001 to implement #1 (keep using TreeSet and its contains()) > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-19917.master.000.patch, > HBASE-19917.master.001.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351806#comment-16351806 ] Ted Yu commented on HBASE-19917: I also think #1 Is good enough performance wise. You can keep the TreeSet Thanks > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-19917.master.000.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351784#comment-16351784 ] Xiang Li commented on HBASE-19917: -- Thanks for your comment [~yuzhih...@gmail.com]! {{filterServers()}} is only called in {{RSGroupBasedLoadBalancer#filterServers()}}, as follow: {code} return filterServers(RSGroupInfo.getServers(), onlineServers); {code} {{RSGroupInfo#getServers()}} returns servers, a SortedSet. It is a TreeSet actually, built by its constructor. Given a TreeSet, there are 2 ways: (Let's say when calling {{filterServers()}}, size of servers is n and size of onlineServers is m) # Keep using TreeSet. Time complexity is O(m * logn). Because TreeSet#contains() is logn and we loop for m. # Turn TreeSet into HashSet, to pursue O(1) for contains(). Time complexity is O(m + n), as the following 2 steps are included: ## Construct a HashSet from a TreeSet. It is O(n) for time complexity (if I get it correctly) as it needs to iterate the TreeSet ## Calculate the union of severs and onlineServers. The time complexity is m * O(1). I think #1 is good enough, although it is worse than #2 which is linear. What is your opinion? Regarding bq. If possible, we should change those to using HashSet. In RSGroupInfo, servers as well as tables is TreeSet. According to the comments, {code} // Keep servers in a sorted set so has an expected ordering when displayed. private final SortedSet servers; // Keep tables sorted too. private final SortedSet tables; {code} TreeSet is only used for display purpose. I am checking if HashSet could be used to replace TreeSet throughout the calling chain. > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-19917.master.000.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351389#comment-16351389 ] Ted Yu commented on HBASE-19917: {code} 298 } else { // not a HashSet yet 299 serverAddressSet = new HashSet(servers); {code} Can you identify the caller(s) where non-HashSet parameter is passed ? If possible, we should change those to using HashSet. > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-19917.master.000.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351271#comment-16351271 ] Hadoop QA commented on HBASE-19917: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 9s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 52s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 39s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 18m 12s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 7s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 36m 44s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19917 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12909082/HBASE-19917.master.000.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 87d66b2e93af 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 41974efa85 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11372/testReport/ | | Max. process+thread count | 1528 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11372/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Improve
[jira] [Commented] (HBASE-19917) Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient
[ https://issues.apache.org/jira/browse/HBASE-19917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351247#comment-16351247 ] Xiang Li commented on HBASE-19917: -- Uploaded the very first patch. All UT under hbase-rsgroup get passed on my local machine. Running full UT. > Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient > - > > Key: HBASE-19917 > URL: https://issues.apache.org/jira/browse/HBASE-19917 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Reporter: Xiang Li >Assignee: Xiang Li >Priority: Minor > Attachments: HBASE-19917.master.000.patch > > > {code:title=hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java|borderStyle=solid} > private List filterServers(Collection servers, > Collection onlineServers) { > ArrayList finalList = new ArrayList(); > for (Address server : servers) { > for(ServerName curr: onlineServers) { > if(curr.getAddress().equals(server)) { > finalList.add(curr); > } > } > } > return finalList; > } > {code} > filterServers is to return the union of servers and onlineServers. The > current implementation has time complexity as O(m * n) (2 loops), could be in > O(m + n) if HashSet is used. The trade-off is space complexity is increased. > Another point which could be improved: filterServers() is only called in > filterOfflineServers(). filterOfflineServers calls filterServers(Set, List). > The current filterServers(Collection, Collection) seems could be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)